[INFO] updating cached repository seven1m/boardslam-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/seven1m/boardslam-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/seven1m/boardslam-rust" "work/ex/clippy-test-run/sources/stable/gh/seven1m/boardslam-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/seven1m/boardslam-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/seven1m/boardslam-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seven1m/boardslam-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seven1m/boardslam-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 07719975bf320a344de8d616d4f1ce3d0ab8f267 [INFO] sha for GitHub repo seven1m/boardslam-rust: 07719975bf320a344de8d616d4f1ce3d0ab8f267 [INFO] validating manifest of seven1m/boardslam-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of seven1m/boardslam-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing seven1m/boardslam-rust [INFO] finished frobbing seven1m/boardslam-rust [INFO] frobbed toml for seven1m/boardslam-rust written to work/ex/clippy-test-run/sources/stable/gh/seven1m/boardslam-rust/Cargo.toml [INFO] started frobbing seven1m/boardslam-rust [INFO] finished frobbing seven1m/boardslam-rust [INFO] frobbed toml for seven1m/boardslam-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seven1m/boardslam-rust/Cargo.toml [INFO] crate seven1m/boardslam-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting seven1m/boardslam-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/seven1m/boardslam-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 53c399cf2421f23774bf83977b4f30fa60aa34cbaf6a4ba584e84822b9de64b8 [INFO] running `"docker" "start" "-a" "53c399cf2421f23774bf83977b4f30fa60aa34cbaf6a4ba584e84822b9de64b8"` [INFO] [stderr] Checking boardslam v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 16 | | &Op::Add => "+", [INFO] [stderr] 17 | | &Op::Subtract => "-", [INFO] [stderr] 18 | | &Op::Multipy => "*", [INFO] [stderr] 19 | | &Op::Divide => "/", [INFO] [stderr] 20 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | let s = match *self { [INFO] [stderr] 16 | Op::Add => "+", [INFO] [stderr] 17 | Op::Subtract => "-", [INFO] [stderr] 18 | Op::Multipy => "*", [INFO] [stderr] 19 | Op::Divide => "/", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn from( [INFO] [stderr] 50 | | x: &u8, [INFO] [stderr] 51 | | x_power: &u32, [INFO] [stderr] 52 | | op1: &Op, [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | x: &u8, [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | x_power: &u32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | y: &u8, [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | y_power: &u32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | z: &u8, [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | z_power: &u32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:61:25 [INFO] [stderr] | [INFO] [stderr] 61 | number: x.clone(), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | power: x_power.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*x_power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | number: y.clone(), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:67:24 [INFO] [stderr] | [INFO] [stderr] 67 | power: y_power.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*y_power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | number: z.clone(), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | power: z_power.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*z_power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:136:52 [INFO] [stderr] | [INFO] [stderr] 136 | let possible: HashSet = HashSet::from_iter(1..BOARD_SIZE + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `1..=BOARD_SIZE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / match op { [INFO] [stderr] 144 | | &Op::Add => n1.saturating_add(n2), [INFO] [stderr] 145 | | &Op::Subtract => n1.saturating_sub(n2), [INFO] [stderr] 146 | | &Op::Multipy => n1.saturating_mul(n2), [INFO] [stderr] ... | [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 143 | match *op { [INFO] [stderr] 144 | Op::Add => n1.saturating_add(n2), [INFO] [stderr] 145 | Op::Subtract => n1.saturating_sub(n2), [INFO] [stderr] 146 | Op::Multipy => n1.saturating_mul(n2), [INFO] [stderr] 147 | Op::Divide => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:159:26 [INFO] [stderr] | [INFO] [stderr] 159 | fn permutations(numbers: &Vec) -> Vec<(u8, u8, u8)> { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 159 | fn permutations(numbers: &[u8]) -> Vec<(u8, u8, u8)> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `numbers.clone()` to [INFO] [stderr] | [INFO] [stderr] 162 | let mut numbers_without_x = numbers.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 16 | | &Op::Add => "+", [INFO] [stderr] 17 | | &Op::Subtract => "-", [INFO] [stderr] 18 | | &Op::Multipy => "*", [INFO] [stderr] 19 | | &Op::Divide => "/", [INFO] [stderr] 20 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | let s = match *self { [INFO] [stderr] 16 | Op::Add => "+", [INFO] [stderr] 17 | Op::Subtract => "-", [INFO] [stderr] 18 | Op::Multipy => "*", [INFO] [stderr] 19 | Op::Divide => "/", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / pub fn from( [INFO] [stderr] 50 | | x: &u8, [INFO] [stderr] 51 | | x_power: &u32, [INFO] [stderr] 52 | | op1: &Op, [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | x: &u8, [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | x_power: &u32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | y: &u8, [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | y_power: &u32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | z: &u8, [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | z_power: &u32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:61:25 [INFO] [stderr] | [INFO] [stderr] 61 | number: x.clone(), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:62:24 [INFO] [stderr] | [INFO] [stderr] 62 | power: x_power.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*x_power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | number: y.clone(), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:67:24 [INFO] [stderr] | [INFO] [stderr] 67 | power: y_power.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*y_power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | number: z.clone(), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | power: z_power.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*z_power` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:136:52 [INFO] [stderr] | [INFO] [stderr] 136 | let possible: HashSet = HashSet::from_iter(1..BOARD_SIZE + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `1..=BOARD_SIZE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / match op { [INFO] [stderr] 144 | | &Op::Add => n1.saturating_add(n2), [INFO] [stderr] 145 | | &Op::Subtract => n1.saturating_sub(n2), [INFO] [stderr] 146 | | &Op::Multipy => n1.saturating_mul(n2), [INFO] [stderr] ... | [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 143 | match *op { [INFO] [stderr] 144 | Op::Add => n1.saturating_add(n2), [INFO] [stderr] 145 | Op::Subtract => n1.saturating_sub(n2), [INFO] [stderr] 146 | Op::Multipy => n1.saturating_mul(n2), [INFO] [stderr] 147 | Op::Divide => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:159:26 [INFO] [stderr] | [INFO] [stderr] 159 | fn permutations(numbers: &Vec) -> Vec<(u8, u8, u8)> { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 159 | fn permutations(numbers: &[u8]) -> Vec<(u8, u8, u8)> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `numbers.clone()` to [INFO] [stderr] | [INFO] [stderr] 162 | let mut numbers_without_x = numbers.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:208:22 [INFO] [stderr] | [INFO] [stderr] 208 | let answer = results.get(&22).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&results[&22]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bin/cgi.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / let final_html; [INFO] [stderr] 57 | | if n1 == 0 || n2 == 0 || n3 == 0 { [INFO] [stderr] 58 | | output = "Please specify 3 numbers between 1 and 6".to_string(); [INFO] [stderr] 59 | | final_html = html.replace("{n1}", "").replace("{n2}", "").replace("{n3}", "").replace("{output}", &output); [INFO] [stderr] ... | [INFO] [stderr] 70 | | final_html = html.replace("{n1}", &n1.to_string()).replace("{n2}", &n2.to_string()).replace("{n3}", &n3.to_string()).replace("{output}", &output); [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let final_html = if n1 == 0 || n2 == 0 || n3 == 0 { ..; html.replace("{n1}", "").replace("{n2}", "").replace("{n3}", "").replace("{output}", &output) } else { ..; html.replace("{n1}", &n1.to_string()).replace("{n2}", &n2.to_string()).replace("{n3}", &n3.to_string()).replace("{output}", &output) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/cgi.rs:50:42 [INFO] [stderr] | [INFO] [stderr] 50 | let query = env::var("QUERY_STRING").unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/cgi.rs:77:29 [INFO] [stderr] | [INFO] [stderr] 77 | let pairs = query.split("&"); [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/cgi.rs:79:43 [INFO] [stderr] | [INFO] [stderr] 79 | let parts: Vec<&str> = pair.split("=").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/bin/cgi.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / let final_html; [INFO] [stderr] 57 | | if n1 == 0 || n2 == 0 || n3 == 0 { [INFO] [stderr] 58 | | output = "Please specify 3 numbers between 1 and 6".to_string(); [INFO] [stderr] 59 | | final_html = html.replace("{n1}", "").replace("{n2}", "").replace("{n3}", "").replace("{output}", &output); [INFO] [stderr] ... | [INFO] [stderr] 70 | | final_html = html.replace("{n1}", &n1.to_string()).replace("{n2}", &n2.to_string()).replace("{n3}", &n3.to_string()).replace("{output}", &output); [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let final_html = if n1 == 0 || n2 == 0 || n3 == 0 { ..; html.replace("{n1}", "").replace("{n2}", "").replace("{n3}", "").replace("{output}", &output) } else { ..; html.replace("{n1}", &n1.to_string()).replace("{n2}", &n2.to_string()).replace("{n3}", &n3.to_string()).replace("{output}", &output) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/cgi.rs:50:42 [INFO] [stderr] | [INFO] [stderr] 50 | let query = env::var("QUERY_STRING").unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/cgi.rs:77:29 [INFO] [stderr] | [INFO] [stderr] 77 | let pairs = query.split("&"); [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/cgi.rs:79:43 [INFO] [stderr] | [INFO] [stderr] 79 | let parts: Vec<&str> = pair.split("=").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.28s [INFO] running `"docker" "inspect" "53c399cf2421f23774bf83977b4f30fa60aa34cbaf6a4ba584e84822b9de64b8"` [INFO] running `"docker" "rm" "-f" "53c399cf2421f23774bf83977b4f30fa60aa34cbaf6a4ba584e84822b9de64b8"` [INFO] [stdout] 53c399cf2421f23774bf83977b4f30fa60aa34cbaf6a4ba584e84822b9de64b8