[INFO] updating cached repository sethsamuel/adventofcode-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sethsamuel/adventofcode-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sethsamuel/adventofcode-2018" "work/ex/clippy-test-run/sources/stable/gh/sethsamuel/adventofcode-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sethsamuel/adventofcode-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sethsamuel/adventofcode-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sethsamuel/adventofcode-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sethsamuel/adventofcode-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6644d3395ce6f7ef4cdb9629c38d348d3efdd905 [INFO] sha for GitHub repo sethsamuel/adventofcode-2018: 6644d3395ce6f7ef4cdb9629c38d348d3efdd905 [INFO] validating manifest of sethsamuel/adventofcode-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sethsamuel/adventofcode-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sethsamuel/adventofcode-2018 [INFO] finished frobbing sethsamuel/adventofcode-2018 [INFO] frobbed toml for sethsamuel/adventofcode-2018 written to work/ex/clippy-test-run/sources/stable/gh/sethsamuel/adventofcode-2018/Cargo.toml [INFO] started frobbing sethsamuel/adventofcode-2018 [INFO] finished frobbing sethsamuel/adventofcode-2018 [INFO] frobbed toml for sethsamuel/adventofcode-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sethsamuel/adventofcode-2018/Cargo.toml [INFO] crate sethsamuel/adventofcode-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sethsamuel/adventofcode-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sethsamuel/adventofcode-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 92052c1b691fd816d1a55d613933295cc96a48a7a6f8b57fd5507487076cb758 [INFO] running `"docker" "start" "-a" "92052c1b691fd816d1a55d613933295cc96a48a7a6f8b57fd5507487076cb758"` [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Checking clicolors-control v0.3.0 [INFO] [stderr] Checking number_prefix v0.2.8 [INFO] [stderr] Checking rand v0.6.1 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking skiplist v0.2.10 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking parking_lot v0.7.0 [INFO] [stderr] Checking console v0.7.0 [INFO] [stderr] Checking dialoguer v0.3.0 [INFO] [stderr] Checking indicatif v0.10.1 [INFO] [stderr] Checking adventofcode-2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day_10/mod.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | particle [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day_10/mod.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | let particle = Particle { [INFO] [stderr] | ____________________^ [INFO] [stderr] 42 | | x: captures [INFO] [stderr] 43 | | .get(1) [INFO] [stderr] 44 | | .unwrap() [INFO] [stderr] ... | [INFO] [stderr] 69 | | .unwrap(), [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day_10/mod.rs:85:18 [INFO] [stderr] | [INFO] [stderr] 85 | while tick < 100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day_10/mod.rs:147:18 [INFO] [stderr] | [INFO] [stderr] 147 | while tick < 100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day_11/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | power [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day_11/mod.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | let power = ((rack_id * y + serial) * rack_id / 100) % 10 - 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day_10/mod.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | particle [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day_10/mod.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | let particle = Particle { [INFO] [stderr] | ____________________^ [INFO] [stderr] 42 | | x: captures [INFO] [stderr] 43 | | .get(1) [INFO] [stderr] 44 | | .unwrap() [INFO] [stderr] ... | [INFO] [stderr] 69 | | .unwrap(), [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day_10/mod.rs:85:18 [INFO] [stderr] | [INFO] [stderr] 85 | while tick < 100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/day_10/mod.rs:147:18 [INFO] [stderr] | [INFO] [stderr] 147 | while tick < 100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/day_11/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | power [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/day_11/mod.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | let power = ((rack_id * y + serial) * rack_id / 100) % 10 - 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: variable `total_plants` is assigned to, but never used [INFO] [stderr] --> src/day_12/mod.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | let mut total_plants = initial_state.clone().filter(|c| *c == PLANT).count(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_total_plants` instead [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/day_10/mod.rs:123:47 [INFO] [stderr] | [INFO] [stderr] 123 | let _ = term.write_line(&line.into_iter().collect::()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_10/mod.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | particle.x = particle.x + particle.dx; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `particle.x += particle.dx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_10/mod.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | particle.y = particle.y + particle.dy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `particle.y += particle.dy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/day_10/mod.rs:187:47 [INFO] [stderr] | [INFO] [stderr] 187 | let _ = term.write_line(&line.into_iter().collect::()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_10/mod.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | particle.x = particle.x + particle.dx; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `particle.x += particle.dx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_10/mod.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | particle.y = particle.y + particle.dy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `particle.y += particle.dy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `last_state` [INFO] [stderr] --> src/day_12/mod.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..last_state.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 57 | for (i, ) in last_state.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `last_state` [INFO] [stderr] --> src/day_12/mod.rs:107:14 [INFO] [stderr] | [INFO] [stderr] 107 | for i in 0..last_state.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 107 | for (i, ) in last_state.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/day_7/mod.rs:62:18 [INFO] [stderr] | [INFO] [stderr] 62 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/day_7/mod.rs:136:30 [INFO] [stderr] | [INFO] [stderr] 136 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_9/mod.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | current_marble = current_marble + 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_marble += 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_9/mod.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | current_marble = current_marble % marbles.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_marble %= marbles.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_9/mod.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | current_marble = current_marble + 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_marble += 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_9/mod.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | current_marble = current_marble % marbles.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_marble %= marbles.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: variable `total_plants` is assigned to, but never used [INFO] [stderr] --> src/day_12/mod.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | let mut total_plants = initial_state.clone().filter(|c| *c == PLANT).count(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_total_plants` instead [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/day_10/mod.rs:123:47 [INFO] [stderr] | [INFO] [stderr] 123 | let _ = term.write_line(&line.into_iter().collect::()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_10/mod.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | particle.x = particle.x + particle.dx; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `particle.x += particle.dx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_10/mod.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | particle.y = particle.y + particle.dy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `particle.y += particle.dy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/day_10/mod.rs:187:47 [INFO] [stderr] | [INFO] [stderr] 187 | let _ = term.write_line(&line.into_iter().collect::()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_10/mod.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | particle.x = particle.x + particle.dx; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `particle.x += particle.dx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_10/mod.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | particle.y = particle.y + particle.dy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `particle.y += particle.dy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `last_state` [INFO] [stderr] --> src/day_12/mod.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..last_state.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 57 | for (i, ) in last_state.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `last_state` [INFO] [stderr] --> src/day_12/mod.rs:107:14 [INFO] [stderr] | [INFO] [stderr] 107 | for i in 0..last_state.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 107 | for (i, ) in last_state.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/day_7/mod.rs:62:18 [INFO] [stderr] | [INFO] [stderr] 62 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/day_7/mod.rs:136:30 [INFO] [stderr] | [INFO] [stderr] 136 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_9/mod.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | current_marble = current_marble + 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_marble += 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_9/mod.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | current_marble = current_marble % marbles.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_marble %= marbles.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_9/mod.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | current_marble = current_marble + 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_marble += 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day_9/mod.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | current_marble = current_marble % marbles.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_marble %= marbles.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.09s [INFO] running `"docker" "inspect" "92052c1b691fd816d1a55d613933295cc96a48a7a6f8b57fd5507487076cb758"` [INFO] running `"docker" "rm" "-f" "92052c1b691fd816d1a55d613933295cc96a48a7a6f8b57fd5507487076cb758"` [INFO] [stdout] 92052c1b691fd816d1a55d613933295cc96a48a7a6f8b57fd5507487076cb758