[INFO] updating cached repository serprex/ninja [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/serprex/ninja [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/serprex/ninja" "work/ex/clippy-test-run/sources/stable/gh/serprex/ninja"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/serprex/ninja'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/serprex/ninja" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/serprex/ninja"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/serprex/ninja'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 79ab47602ec4fa6da709f4824c1bc683efe8a84f [INFO] sha for GitHub repo serprex/ninja: 79ab47602ec4fa6da709f4824c1bc683efe8a84f [INFO] validating manifest of serprex/ninja on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serprex/ninja on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serprex/ninja [INFO] finished frobbing serprex/ninja [INFO] frobbed toml for serprex/ninja written to work/ex/clippy-test-run/sources/stable/gh/serprex/ninja/Cargo.toml [INFO] started frobbing serprex/ninja [INFO] finished frobbing serprex/ninja [INFO] frobbed toml for serprex/ninja written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/serprex/ninja/Cargo.toml [INFO] crate serprex/ninja has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serprex/ninja against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/serprex/ninja:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1be0527dcd499a38cabe4bbdbd6044dfb75912e3488dc994598437cb08b2e14e [INFO] running `"docker" "start" "-a" "1be0527dcd499a38cabe4bbdbd6044dfb75912e3488dc994598437cb08b2e14e"` [INFO] [stderr] Checking ninja v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:223:4 [INFO] [stderr] | [INFO] [stderr] 223 | explicit_deps: explicit_deps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `explicit_deps` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:224:4 [INFO] [stderr] | [INFO] [stderr] 224 | implicit_deps: implicit_deps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `implicit_deps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:225:4 [INFO] [stderr] | [INFO] [stderr] 225 | order_deps: order_deps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `order_deps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:223:4 [INFO] [stderr] | [INFO] [stderr] 223 | explicit_deps: explicit_deps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `explicit_deps` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:224:4 [INFO] [stderr] | [INFO] [stderr] 224 | implicit_deps: implicit_deps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `implicit_deps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:225:4 [INFO] [stderr] | [INFO] [stderr] 225 | order_deps: order_deps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `order_deps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Pool` [INFO] [stderr] --> src/parser.rs:10:2 [INFO] [stderr] | [INFO] [stderr] 10 | Pool, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Gcc` [INFO] [stderr] --> src/parser.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | Gcc, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Msvc` [INFO] [stderr] --> src/parser.rs:22:2 [INFO] [stderr] | [INFO] [stderr] 22 | Msvc, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/parser.rs:8:2 [INFO] [stderr] | [INFO] [stderr] 8 | Rule(String, Rule), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/parser.rs:8:2 [INFO] [stderr] | [INFO] [stderr] 8 | Rule(String, Rule), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:77:4 [INFO] [stderr] | [INFO] [stderr] 77 | match self.mode { [INFO] [stderr] | _____________^ [INFO] [stderr] 78 | | ParseMode::Normal => return Err(String::from("Unexpected indent")), [INFO] [stderr] 79 | | _ => (), [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ help: try this: `if let ParseMode::Normal = self.mode { return Err(String::from("Unexpected indent")) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Pool` [INFO] [stderr] --> src/parser.rs:10:2 [INFO] [stderr] | [INFO] [stderr] 10 | Pool, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Gcc` [INFO] [stderr] --> src/parser.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | Gcc, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Msvc` [INFO] [stderr] --> src/parser.rs:22:2 [INFO] [stderr] | [INFO] [stderr] 22 | Msvc, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/parser.rs:8:2 [INFO] [stderr] | [INFO] [stderr] 8 | Rule(String, Rule), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/parser.rs:8:2 [INFO] [stderr] | [INFO] [stderr] 8 | Rule(String, Rule), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:77:4 [INFO] [stderr] | [INFO] [stderr] 77 | match self.mode { [INFO] [stderr] | _____________^ [INFO] [stderr] 78 | | ParseMode::Normal => return Err(String::from("Unexpected indent")), [INFO] [stderr] 79 | | _ => (), [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ help: try this: `if let ParseMode::Normal = self.mode { return Err(String::from("Unexpected indent")) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.45s [INFO] running `"docker" "inspect" "1be0527dcd499a38cabe4bbdbd6044dfb75912e3488dc994598437cb08b2e14e"` [INFO] running `"docker" "rm" "-f" "1be0527dcd499a38cabe4bbdbd6044dfb75912e3488dc994598437cb08b2e14e"` [INFO] [stdout] 1be0527dcd499a38cabe4bbdbd6044dfb75912e3488dc994598437cb08b2e14e