[INFO] updating cached repository seritools/st_startup_manager [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/seritools/st_startup_manager [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/seritools/st_startup_manager" "work/ex/clippy-test-run/sources/stable/gh/seritools/st_startup_manager"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/seritools/st_startup_manager'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/seritools/st_startup_manager" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seritools/st_startup_manager"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seritools/st_startup_manager'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fa93916770b66aa3c1a9d42ba74025d1f8c6671d [INFO] sha for GitHub repo seritools/st_startup_manager: fa93916770b66aa3c1a9d42ba74025d1f8c6671d [INFO] validating manifest of seritools/st_startup_manager on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of seritools/st_startup_manager on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing seritools/st_startup_manager [INFO] finished frobbing seritools/st_startup_manager [INFO] frobbed toml for seritools/st_startup_manager written to work/ex/clippy-test-run/sources/stable/gh/seritools/st_startup_manager/Cargo.toml [INFO] started frobbing seritools/st_startup_manager [INFO] finished frobbing seritools/st_startup_manager [INFO] frobbed toml for seritools/st_startup_manager written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seritools/st_startup_manager/Cargo.toml [INFO] crate seritools/st_startup_manager has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting seritools/st_startup_manager against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/seritools/st_startup_manager:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1eea04b46bfdf06a93f7ba1795fcd243f49412b0991267f96d3649cb2530a413 [INFO] running `"docker" "start" "-a" "1eea04b46bfdf06a93f7ba1795fcd243f49412b0991267f96d3649cb2530a413"` [INFO] [stderr] Checking serde v0.9.11 [INFO] [stderr] Compiling syn v0.11.9 [INFO] [stderr] Compiling serde_codegen_internals v0.14.1 [INFO] [stderr] Compiling serde_derive v0.9.11 [INFO] [stderr] Checking toml v0.3.1 [INFO] [stderr] Checking st_startup_manager v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:24:88 [INFO] [stderr] | [INFO] [stderr] 24 | let elapsed_ms = (elapsed.as_secs() * 1000) + (elapsed.subsec_nanos() as u64 / 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:24:56 [INFO] [stderr] | [INFO] [stderr] 24 | let elapsed_ms = (elapsed.as_secs() * 1000) + (elapsed.subsec_nanos() as u64 / 1000000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:36:31 [INFO] [stderr] | [INFO] [stderr] 36 | fn run_command(command: &String, parameters: I) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:24:88 [INFO] [stderr] | [INFO] [stderr] 24 | let elapsed_ms = (elapsed.as_secs() * 1000) + (elapsed.subsec_nanos() as u64 / 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:24:56 [INFO] [stderr] | [INFO] [stderr] 24 | let elapsed_ms = (elapsed.as_secs() * 1000) + (elapsed.subsec_nanos() as u64 / 1000000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:36:31 [INFO] [stderr] | [INFO] [stderr] 36 | fn run_command(command: &String, parameters: I) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.52s [INFO] running `"docker" "inspect" "1eea04b46bfdf06a93f7ba1795fcd243f49412b0991267f96d3649cb2530a413"` [INFO] running `"docker" "rm" "-f" "1eea04b46bfdf06a93f7ba1795fcd243f49412b0991267f96d3649cb2530a413"` [INFO] [stdout] 1eea04b46bfdf06a93f7ba1795fcd243f49412b0991267f96d3649cb2530a413