[INFO] updating cached repository sergorl/merkle_hash_tree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sergorl/merkle_hash_tree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sergorl/merkle_hash_tree" "work/ex/clippy-test-run/sources/stable/gh/sergorl/merkle_hash_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sergorl/merkle_hash_tree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sergorl/merkle_hash_tree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sergorl/merkle_hash_tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sergorl/merkle_hash_tree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 27429dcf39c550bb473f4c7907ca5c3de4e5aacf [INFO] sha for GitHub repo sergorl/merkle_hash_tree: 27429dcf39c550bb473f4c7907ca5c3de4e5aacf [INFO] validating manifest of sergorl/merkle_hash_tree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sergorl/merkle_hash_tree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sergorl/merkle_hash_tree [INFO] finished frobbing sergorl/merkle_hash_tree [INFO] frobbed toml for sergorl/merkle_hash_tree written to work/ex/clippy-test-run/sources/stable/gh/sergorl/merkle_hash_tree/Cargo.toml [INFO] started frobbing sergorl/merkle_hash_tree [INFO] finished frobbing sergorl/merkle_hash_tree [INFO] frobbed toml for sergorl/merkle_hash_tree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sergorl/merkle_hash_tree/Cargo.toml [INFO] crate sergorl/merkle_hash_tree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sergorl/merkle_hash_tree against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sergorl/merkle_hash_tree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3d5ead601f28cca35ddb48d4fb7f7ac4f46f0cf7ad45f4c7275685f1b01557f9 [INFO] running `"docker" "start" "-a" "3d5ead601f28cca35ddb48d4fb7f7ac4f46f0cf7ad45f4c7275685f1b01557f9"` [INFO] [stderr] Checking num_cpus v0.2.13 [INFO] [stderr] Checking rayon-core v1.3.0 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking rayon v0.9.0 [INFO] [stderr] Checking merkle_hash_tree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lib.rs:158:27 [INFO] [stderr] | [INFO] [stderr] 158 | write!(f, "{}\n", "Tree: "); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | write!(f, "{}\n", "Tree: "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | write!(f, "Level {}: \n", level); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | write!(f, "hash {}: {}\n", index, to_hex_string(hash)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lib.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | "--------------------------------------------------------------------" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | / write!( [INFO] [stderr] 171 | | f, [INFO] [stderr] 172 | | "{}\n", [INFO] [stderr] 173 | | "--------------------------------------------------------------------" [INFO] [stderr] 174 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lib.rs:158:27 [INFO] [stderr] | [INFO] [stderr] 158 | write!(f, "{}\n", "Tree: "); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | write!(f, "{}\n", "Tree: "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | write!(f, "Level {}: \n", level); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | write!(f, "hash {}: {}\n", index, to_hex_string(hash)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lib.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | "--------------------------------------------------------------------" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | / write!( [INFO] [stderr] 171 | | f, [INFO] [stderr] 172 | | "{}\n", [INFO] [stderr] 173 | | "--------------------------------------------------------------------" [INFO] [stderr] 174 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num_thread` [INFO] [stderr] --> src/lib.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | let num_thread: usize; [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_num_thread` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num_cpus` [INFO] [stderr] --> src/lib.rs:255:78 [INFO] [stderr] | [INFO] [stderr] 255 | fn create_hash_level(hash_tree: &mut Vec>, pool: &rayon::ThreadPool, num_cpus: usize) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_num_cpus` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num_cpus` [INFO] [stderr] --> src/lib.rs:305:5 [INFO] [stderr] | [INFO] [stderr] 305 | num_cpus: usize, [INFO] [stderr] | ^^^^^^^^ help: consider using `_num_cpus` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num_thread` [INFO] [stderr] --> src/lib.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | let num_thread: usize; [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_num_thread` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num_cpus` [INFO] [stderr] --> src/lib.rs:255:78 [INFO] [stderr] | [INFO] [stderr] 255 | fn create_hash_level(hash_tree: &mut Vec>, pool: &rayon::ThreadPool, num_cpus: usize) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_num_cpus` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `num_cpus` [INFO] [stderr] --> src/lib.rs:305:5 [INFO] [stderr] | [INFO] [stderr] 305 | num_cpus: usize, [INFO] [stderr] | ^^^^^^^^ help: consider using `_num_cpus` instead [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:46:24 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn new(blocks: &Vec>, num_cpus: usize) -> MerkleTree { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | write!(f, "{}\n", "Tree: "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the variable `level` is used as a loop counter. Consider using `for (level, item) in &self.tree.enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:160:27 [INFO] [stderr] | [INFO] [stderr] 160 | for hash_level in &self.tree { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | write!(f, "Level {}: \n", level); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | write!(f, "hash {}: {}\n", index, to_hex_string(hash)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | / write!( [INFO] [stderr] 171 | | f, [INFO] [stderr] 172 | | "{}\n", [INFO] [stderr] 173 | | "--------------------------------------------------------------------" [INFO] [stderr] 174 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:237:60 [INFO] [stderr] | [INFO] [stderr] 237 | *dst.offset((i + SIZE_BLOCK_HASH) as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:237:14 [INFO] [stderr] | [INFO] [stderr] 237 | *dst.offset((i + SIZE_BLOCK_HASH) as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dst.add((i + SIZE_BLOCK_HASH))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:243:30 [INFO] [stderr] | [INFO] [stderr] 243 | fn par_hash_hash(prev_level: &Vec, new_level: &mut Vec, pool: &rayon::ThreadPool) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:260:5 [INFO] [stderr] | [INFO] [stderr] 260 | / let num_block_in_new_level: usize; [INFO] [stderr] 261 | | [INFO] [stderr] 262 | | if num_block_in_prev_level > 2 { [INFO] [stderr] 263 | | num_block_in_new_level = num_block_in_prev_level / 2 + addition; [INFO] [stderr] 264 | | } else { [INFO] [stderr] 265 | | num_block_in_new_level = 1; [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let num_block_in_new_level = if num_block_in_prev_level > 2 { num_block_in_prev_level / 2 + addition } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:292:26 [INFO] [stderr] | [INFO] [stderr] 292 | fn par_zero_hash(blocks: &Vec>, base: &mut Vec, pool: &rayon::ThreadPool) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:302:13 [INFO] [stderr] | [INFO] [stderr] 302 | blocks: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:46:24 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn new(blocks: &Vec>, num_cpus: usize) -> MerkleTree { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | write!(f, "{}\n", "Tree: "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the variable `level` is used as a loop counter. Consider using `for (level, item) in &self.tree.enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:160:27 [INFO] [stderr] | [INFO] [stderr] 160 | for hash_level in &self.tree { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | write!(f, "Level {}: \n", level); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | write!(f, "hash {}: {}\n", index, to_hex_string(hash)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/lib.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | / write!( [INFO] [stderr] 171 | | f, [INFO] [stderr] 172 | | "{}\n", [INFO] [stderr] 173 | | "--------------------------------------------------------------------" [INFO] [stderr] 174 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:237:60 [INFO] [stderr] | [INFO] [stderr] 237 | *dst.offset((i + SIZE_BLOCK_HASH) as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:237:14 [INFO] [stderr] | [INFO] [stderr] 237 | *dst.offset((i + SIZE_BLOCK_HASH) as isize) = *src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dst.add((i + SIZE_BLOCK_HASH))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:243:30 [INFO] [stderr] | [INFO] [stderr] 243 | fn par_hash_hash(prev_level: &Vec, new_level: &mut Vec, pool: &rayon::ThreadPool) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:260:5 [INFO] [stderr] | [INFO] [stderr] 260 | / let num_block_in_new_level: usize; [INFO] [stderr] 261 | | [INFO] [stderr] 262 | | if num_block_in_prev_level > 2 { [INFO] [stderr] 263 | | num_block_in_new_level = num_block_in_prev_level / 2 + addition; [INFO] [stderr] 264 | | } else { [INFO] [stderr] 265 | | num_block_in_new_level = 1; [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let num_block_in_new_level = if num_block_in_prev_level > 2 { num_block_in_prev_level / 2 + addition } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:292:26 [INFO] [stderr] | [INFO] [stderr] 292 | fn par_zero_hash(blocks: &Vec>, base: &mut Vec, pool: &rayon::ThreadPool) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:302:13 [INFO] [stderr] | [INFO] [stderr] 302 | blocks: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> tests/test.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `merkle_hash_tree`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `merkle_hash_tree`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `merkle_tree::to_hex_string` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use merkle_tree::to_hex_string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `start` [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let start = PreciseTime::now(); [INFO] [stderr] | ^^^^^ help: consider using `_start` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `end` [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let end = PreciseTime::now(); [INFO] [stderr] | ^^^ help: consider using `_end` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let mut num_block: usize = 8 * 2; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | let mut size_block: usize = 32; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused import: `merkle_tree::to_hex_string` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use merkle_tree::to_hex_string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `start` [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let start = PreciseTime::now(); [INFO] [stderr] | ^^^^^ help: consider using `_start` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `end` [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let end = PreciseTime::now(); [INFO] [stderr] | ^^^ help: consider using `_end` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let mut num_block: usize = 8 * 2; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | let mut size_block: usize = 32; [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "3d5ead601f28cca35ddb48d4fb7f7ac4f46f0cf7ad45f4c7275685f1b01557f9"` [INFO] running `"docker" "rm" "-f" "3d5ead601f28cca35ddb48d4fb7f7ac4f46f0cf7ad45f4c7275685f1b01557f9"` [INFO] [stdout] 3d5ead601f28cca35ddb48d4fb7f7ac4f46f0cf7ad45f4c7275685f1b01557f9