[INFO] updating cached repository sergeysova/inquirer.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sergeysova/inquirer.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sergeysova/inquirer.rs" "work/ex/clippy-test-run/sources/stable/gh/sergeysova/inquirer.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sergeysova/inquirer.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sergeysova/inquirer.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sergeysova/inquirer.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sergeysova/inquirer.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 184cca3f1b27c04169ab40946467a9d0d793e80c [INFO] sha for GitHub repo sergeysova/inquirer.rs: 184cca3f1b27c04169ab40946467a9d0d793e80c [INFO] validating manifest of sergeysova/inquirer.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sergeysova/inquirer.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sergeysova/inquirer.rs [INFO] finished frobbing sergeysova/inquirer.rs [INFO] frobbed toml for sergeysova/inquirer.rs written to work/ex/clippy-test-run/sources/stable/gh/sergeysova/inquirer.rs/Cargo.toml [INFO] started frobbing sergeysova/inquirer.rs [INFO] finished frobbing sergeysova/inquirer.rs [INFO] frobbed toml for sergeysova/inquirer.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sergeysova/inquirer.rs/Cargo.toml [INFO] crate sergeysova/inquirer.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sergeysova/inquirer.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sergeysova/inquirer.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 424efce41543c715aeee7884c6bed50eabdc6b30ca77fd33410b24a779367c2b [INFO] running `"docker" "start" "-a" "424efce41543c715aeee7884c6bed50eabdc6b30ca77fd33410b24a779367c2b"` [INFO] [stderr] Checking inquirer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn run(list: &Vec) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Question]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:16:8 [INFO] [stderr] | [INFO] [stderr] 16 | if list.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn run(list: &Vec) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Question]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:16:8 [INFO] [stderr] | [INFO] [stderr] 16 | if list.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.40s [INFO] running `"docker" "inspect" "424efce41543c715aeee7884c6bed50eabdc6b30ca77fd33410b24a779367c2b"` [INFO] running `"docker" "rm" "-f" "424efce41543c715aeee7884c6bed50eabdc6b30ca77fd33410b24a779367c2b"` [INFO] [stdout] 424efce41543c715aeee7884c6bed50eabdc6b30ca77fd33410b24a779367c2b