[INFO] updating cached repository sepanmaa/rust_raytracer
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/sepanmaa/rust_raytracer
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/sepanmaa/rust_raytracer" "work/ex/clippy-test-run/sources/stable/gh/sepanmaa/rust_raytracer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sepanmaa/rust_raytracer'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/sepanmaa/rust_raytracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sepanmaa/rust_raytracer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sepanmaa/rust_raytracer'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ad6aa353839b390699eb19b883e3795318537745
[INFO] sha for GitHub repo sepanmaa/rust_raytracer: ad6aa353839b390699eb19b883e3795318537745
[INFO] validating manifest of sepanmaa/rust_raytracer on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sepanmaa/rust_raytracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sepanmaa/rust_raytracer
[INFO] finished frobbing sepanmaa/rust_raytracer
[INFO] frobbed toml for sepanmaa/rust_raytracer written to work/ex/clippy-test-run/sources/stable/gh/sepanmaa/rust_raytracer/Cargo.toml
[INFO] started frobbing sepanmaa/rust_raytracer
[INFO] finished frobbing sepanmaa/rust_raytracer
[INFO] frobbed toml for sepanmaa/rust_raytracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sepanmaa/rust_raytracer/Cargo.toml
[INFO] crate sepanmaa/rust_raytracer has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sepanmaa/rust_raytracer against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sepanmaa/rust_raytracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 24fcc2db5677ec87a2c302b6b82711ec52edd52d33be7830dbc4e09c03de4382
[INFO] running `"docker" "start" "-a" "24fcc2db5677ec87a2c302b6b82711ec52edd52d33be7830dbc4e09c03de4382"`
[INFO] [stderr]     Checking rust_raytracer v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/raytracer.rs:141:13
[INFO] [stderr]     |
[INFO] [stderr] 141 |         let n = (p-self.pos).normalize();
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/raytracer.rs:161:17
[INFO] [stderr]     |
[INFO] [stderr] 161 |                 material: material,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `material`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/raytracer.rs:264:16
[INFO] [stderr]     |
[INFO] [stderr] 264 |                color: color,
[INFO] [stderr]     |                ^^^^^^^^^^^^ help: replace it with: `color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/raytracer.rs:141:13
[INFO] [stderr]     |
[INFO] [stderr] 141 |         let n = (p-self.pos).normalize();
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/raytracer.rs:161:17
[INFO] [stderr]     |
[INFO] [stderr] 161 |                 material: material,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `material`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/raytracer.rs:264:16
[INFO] [stderr]     |
[INFO] [stderr] 264 |                color: color,
[INFO] [stderr]     |                ^^^^^^^^^^^^ help: replace it with: `color`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/raytracer.rs:196:5
[INFO] [stderr]     |
[INFO] [stderr] 196 |     return material.color * diffuse + material.spec_color * specular;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `material.color * diffuse + material.spec_color * specular`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/raytracer.rs:226:5
[INFO] [stderr]     |
[INFO] [stderr] 226 |     return pixel;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `pixel`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/raytracer.rs:196:5
[INFO] [stderr]     |
[INFO] [stderr] 196 |     return material.color * diffuse + material.spec_color * specular;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `material.color * diffuse + material.spec_color * specular`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/raytracer.rs:226:5
[INFO] [stderr]     |
[INFO] [stderr] 226 |     return pixel;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `pixel`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/raytracer.rs:155:21
[INFO] [stderr]     |
[INFO] [stderr] 155 |             let c = ((((2.0*p.z).floor() + (2.0*p.x).floor()) as i32) % 2) as f64;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((((2.0*p.z).floor() + (2.0*p.x).floor()) as i32) % 2)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/raytracer.rs:173:9
[INFO] [stderr]     |
[INFO] [stderr] 173 | /         match o.intersects(&ray) {
[INFO] [stderr] 174 | |             Some(i) => {
[INFO] [stderr] 175 | |                 if i.dist < closest {
[INFO] [stderr] 176 | |                     closest = i.dist;
[INFO] [stderr] ...   |
[INFO] [stderr] 180 | |             _ => {}
[INFO] [stderr] 181 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 173 |         if let Some(i) = o.intersects(&ray) {
[INFO] [stderr] 174 |     if i.dist < closest {
[INFO] [stderr] 175 |         closest = i.dist;
[INFO] [stderr] 176 |         isect = Some(i);
[INFO] [stderr] 177 |     }
[INFO] [stderr] 178 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/raytracer.rs:189:5
[INFO] [stderr]     |
[INFO] [stderr] 189 | /     let mut specular = 0.0;
[INFO] [stderr] 190 | |     if diffuse > 0.0 {
[INFO] [stderr] 191 | |         let view_dir = (isect.pos * (-1.0)).normalize();
[INFO] [stderr] 192 | |         let half_dir = (light_dir + view_dir).normalize();
[INFO] [stderr] 193 | |         let spec_angle = half_dir.dot(isect.normal).max(0.0);
[INFO] [stderr] 194 | |         specular = spec_angle.powf(material.shininess);
[INFO] [stderr] 195 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> specular = if diffuse > 0.0 { ..; spec_angle.powf(material.shininess) } else { 0.0 };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/raytracer.rs:204:17
[INFO] [stderr]     |
[INFO] [stderr] 204 |             for ref light in &scene.lights {
[INFO] [stderr]     |                 ^^^^^^^^^    ------------- help: try: `let light = &&scene.lights;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/raytracer.rs:243:37
[INFO] [stderr]     |
[INFO] [stderr] 243 |             let ray = Ray { origin: camera.pos.clone(), dir: ray_dir };
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `camera.pos`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/raytracer.rs:155:21
[INFO] [stderr]     |
[INFO] [stderr] 155 |             let c = ((((2.0*p.z).floor() + (2.0*p.x).floor()) as i32) % 2) as f64;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((((2.0*p.z).floor() + (2.0*p.x).floor()) as i32) % 2)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/raytracer.rs:173:9
[INFO] [stderr]     |
[INFO] [stderr] 173 | /         match o.intersects(&ray) {
[INFO] [stderr] 174 | |             Some(i) => {
[INFO] [stderr] 175 | |                 if i.dist < closest {
[INFO] [stderr] 176 | |                     closest = i.dist;
[INFO] [stderr] ...   |
[INFO] [stderr] 180 | |             _ => {}
[INFO] [stderr] 181 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 173 |         if let Some(i) = o.intersects(&ray) {
[INFO] [stderr] 174 |     if i.dist < closest {
[INFO] [stderr] 175 |         closest = i.dist;
[INFO] [stderr] 176 |         isect = Some(i);
[INFO] [stderr] 177 |     }
[INFO] [stderr] 178 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/raytracer.rs:189:5
[INFO] [stderr]     |
[INFO] [stderr] 189 | /     let mut specular = 0.0;
[INFO] [stderr] 190 | |     if diffuse > 0.0 {
[INFO] [stderr] 191 | |         let view_dir = (isect.pos * (-1.0)).normalize();
[INFO] [stderr] 192 | |         let half_dir = (light_dir + view_dir).normalize();
[INFO] [stderr] 193 | |         let spec_angle = half_dir.dot(isect.normal).max(0.0);
[INFO] [stderr] 194 | |         specular = spec_angle.powf(material.shininess);
[INFO] [stderr] 195 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> specular = if diffuse > 0.0 { ..; spec_angle.powf(material.shininess) } else { 0.0 };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/raytracer.rs:204:17
[INFO] [stderr]     |
[INFO] [stderr] 204 |             for ref light in &scene.lights {
[INFO] [stderr]     |                 ^^^^^^^^^    ------------- help: try: `let light = &&scene.lights;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/raytracer.rs:243:37
[INFO] [stderr]     |
[INFO] [stderr] 243 |             let ray = Ray { origin: camera.pos.clone(), dir: ray_dir };
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `camera.pos`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.57s
[INFO] running `"docker" "inspect" "24fcc2db5677ec87a2c302b6b82711ec52edd52d33be7830dbc4e09c03de4382"`
[INFO] running `"docker" "rm" "-f" "24fcc2db5677ec87a2c302b6b82711ec52edd52d33be7830dbc4e09c03de4382"`
[INFO] [stdout] 24fcc2db5677ec87a2c302b6b82711ec52edd52d33be7830dbc4e09c03de4382