[INFO] updating cached repository semyon2105/authsrv [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/semyon2105/authsrv [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/semyon2105/authsrv" "work/ex/clippy-test-run/sources/stable/gh/semyon2105/authsrv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/semyon2105/authsrv'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/semyon2105/authsrv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/semyon2105/authsrv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/semyon2105/authsrv'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 54f81464aae02cbf91540b8c3507f17669099d53 [INFO] sha for GitHub repo semyon2105/authsrv: 54f81464aae02cbf91540b8c3507f17669099d53 [INFO] validating manifest of semyon2105/authsrv on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of semyon2105/authsrv on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing semyon2105/authsrv [INFO] finished frobbing semyon2105/authsrv [INFO] frobbed toml for semyon2105/authsrv written to work/ex/clippy-test-run/sources/stable/gh/semyon2105/authsrv/Cargo.toml [INFO] started frobbing semyon2105/authsrv [INFO] finished frobbing semyon2105/authsrv [INFO] frobbed toml for semyon2105/authsrv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/semyon2105/authsrv/Cargo.toml [INFO] crate semyon2105/authsrv has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting semyon2105/authsrv against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/semyon2105/authsrv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5fb163d5bb9023137949298b65185fac29b23f3c2362086a1b39ef7a095d0f29 [INFO] running `"docker" "start" "-a" "5fb163d5bb9023137949298b65185fac29b23f3c2362086a1b39ef7a095d0f29"` [INFO] [stderr] Compiling proc-macro2 v0.4.16 [INFO] [stderr] Compiling rand_core v0.2.1 [INFO] [stderr] Checking lazycell v1.0.0 [INFO] [stderr] Checking htmlescape v0.3.1 [INFO] [stderr] Checking termcolor v1.0.3 [INFO] [stderr] Compiling actix-web v0.7.4 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Compiling ring v0.13.2 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Checking socket2 v0.3.8 [INFO] [stderr] Checking encoding_rs v0.8.6 [INFO] [stderr] Checking tokio-executor v0.1.4 [INFO] [stderr] Compiling openssl-sys v0.9.35 [INFO] [stderr] Checking bytes v0.4.9 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Compiling rand v0.5.5 [INFO] [stderr] Checking serde v1.0.76 [INFO] [stderr] Checking parking_lot_core v0.3.0 [INFO] [stderr] Checking tokio-current-thread v0.1.1 [INFO] [stderr] Checking tokio-timer v0.2.6 [INFO] [stderr] Checking backoff v0.1.2 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking url v1.7.1 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Compiling phf_shared v0.7.23 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Checking http v0.1.10 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking libflate v0.1.16 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Checking phf v0.7.23 [INFO] [stderr] Checking sha2 v0.7.1 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking crossbeam-channel v0.2.4 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Checking tokio-threadpool v0.1.6 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking serde-hjson v0.8.1 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-signal v0.2.5 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking redis-async v0.4.1 [INFO] [stderr] Checking trust-dns-proto v0.4.0 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking serde_json v1.0.26 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking config v0.9.0 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling actix_derive v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.76 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking actix v0.7.4 [INFO] [stderr] Checking actix-redis v0.5.1 [INFO] [stderr] Checking authsrv v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/store.rs:152:71 [INFO] [stderr] | [INFO] [stderr] 152 | future::ok(GetTokenResult::InvalidCredentials(login.into())) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `login` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/store.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / match secret.contains(expected_secret) { [INFO] [stderr] 187 | | false => future::Either::A( [INFO] [stderr] 188 | | future::ok(GetTokenResult::InvalidCredentials(login.to_string())) [INFO] [stderr] 189 | | ), [INFO] [stderr] ... | [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 186 | if secret.contains(expected_secret) { [INFO] [stderr] 187 | let token = Uuid::new_v4().hyphenated().to_string(); [INFO] [stderr] 188 | let token_key = get_redis_token_key(&token); [INFO] [stderr] 189 | let command = Command(resp_array!["SETEX", token_key, "60", login.clone()]); [INFO] [stderr] 190 | [INFO] [stderr] 191 | let fut = redis.send(command) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | / match was_added { [INFO] [stderr] 108 | | false => Json(SignupResponse::UserAlreadyExists(login)), [INFO] [stderr] 109 | | true => Json(SignupResponse::Ok), [INFO] [stderr] 110 | | }) [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if was_added { Json(SignupResponse::Ok) } else { Json(SignupResponse::UserAlreadyExists(login)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:152:21 [INFO] [stderr] | [INFO] [stderr] 152 | / match was_added { [INFO] [stderr] 153 | | false => Json(SignupResponse::UserAlreadyExists(id)), [INFO] [stderr] 154 | | true => Json(SignupResponse::Ok), [INFO] [stderr] 155 | | }) [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if was_added { Json(SignupResponse::Ok) } else { Json(SignupResponse::UserAlreadyExists(id)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/store.rs:152:71 [INFO] [stderr] | [INFO] [stderr] 152 | future::ok(GetTokenResult::InvalidCredentials(login.into())) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `login` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/store.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / match secret.contains(expected_secret) { [INFO] [stderr] 187 | | false => future::Either::A( [INFO] [stderr] 188 | | future::ok(GetTokenResult::InvalidCredentials(login.to_string())) [INFO] [stderr] 189 | | ), [INFO] [stderr] ... | [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 186 | if secret.contains(expected_secret) { [INFO] [stderr] 187 | let token = Uuid::new_v4().hyphenated().to_string(); [INFO] [stderr] 188 | let token_key = get_redis_token_key(&token); [INFO] [stderr] 189 | let command = Command(resp_array!["SETEX", token_key, "60", login.clone()]); [INFO] [stderr] 190 | [INFO] [stderr] 191 | let fut = redis.send(command) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | / match was_added { [INFO] [stderr] 108 | | false => Json(SignupResponse::UserAlreadyExists(login)), [INFO] [stderr] 109 | | true => Json(SignupResponse::Ok), [INFO] [stderr] 110 | | }) [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if was_added { Json(SignupResponse::Ok) } else { Json(SignupResponse::UserAlreadyExists(login)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:152:21 [INFO] [stderr] | [INFO] [stderr] 152 | / match was_added { [INFO] [stderr] 153 | | false => Json(SignupResponse::UserAlreadyExists(id)), [INFO] [stderr] 154 | | true => Json(SignupResponse::Ok), [INFO] [stderr] 155 | | }) [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if was_added { Json(SignupResponse::Ok) } else { Json(SignupResponse::UserAlreadyExists(id)) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 35s [INFO] running `"docker" "inspect" "5fb163d5bb9023137949298b65185fac29b23f3c2362086a1b39ef7a095d0f29"` [INFO] running `"docker" "rm" "-f" "5fb163d5bb9023137949298b65185fac29b23f3c2362086a1b39ef7a095d0f29"` [INFO] [stdout] 5fb163d5bb9023137949298b65185fac29b23f3c2362086a1b39ef7a095d0f29