[INFO] updating cached repository semrov/Chat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/semrov/Chat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/semrov/Chat" "work/ex/clippy-test-run/sources/stable/gh/semrov/Chat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/semrov/Chat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/semrov/Chat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/semrov/Chat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/semrov/Chat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ac79789905fc5748da7636f6a645a1d5a89f14bd [INFO] sha for GitHub repo semrov/Chat: ac79789905fc5748da7636f6a645a1d5a89f14bd [INFO] validating manifest of semrov/Chat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of semrov/Chat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing semrov/Chat [INFO] finished frobbing semrov/Chat [INFO] frobbed toml for semrov/Chat written to work/ex/clippy-test-run/sources/stable/gh/semrov/Chat/Cargo.toml [INFO] started frobbing semrov/Chat [INFO] finished frobbing semrov/Chat [INFO] frobbed toml for semrov/Chat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/semrov/Chat/Cargo.toml [INFO] crate semrov/Chat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting semrov/Chat against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/semrov/Chat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36df9757bf697586bbe3471373aae7d57ef7ecd1176a55e7091d85753a80e6d1 [INFO] running `"docker" "start" "-a" "36df9757bf697586bbe3471373aae7d57ef7ecd1176a55e7091d85753a80e6d1"` [INFO] [stderr] Checking lazycell v0.4.0 [INFO] [stderr] Compiling http-muncher v0.3.1 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking net2 v0.2.27 [INFO] [stderr] Checking sha1 v0.1.1 [INFO] [stderr] Checking mio v0.6.5 [INFO] [stderr] Checking chat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http_parser.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | current_key : current_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http_parser.rs:20:14 [INFO] [stderr] | [INFO] [stderr] 20 | current_key : current_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpStream` [INFO] [stderr] --> src/server.rs:3:28 [INFO] [stderr] | [INFO] [stderr] 3 | use mio::tcp::{TcpListener,TcpStream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Events`, `PollOpt`, `Poll`, `Ready` [INFO] [stderr] --> src/server.rs:4:11 [INFO] [stderr] | [INFO] [stderr] 4 | use mio::{Ready, Poll, PollOpt, Token,Events}; [INFO] [stderr] | ^^^^^ ^^^^ ^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ParserHandler` [INFO] [stderr] --> src/client.rs:1:27 [INFO] [stderr] | [INFO] [stderr] 1 | use http_muncher::{Parser,ParserHandler}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpStream` [INFO] [stderr] --> src/main.rs:13:28 [INFO] [stderr] | [INFO] [stderr] 13 | use mio::tcp::{TcpListener,TcpStream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpStream` [INFO] [stderr] --> src/server.rs:3:28 [INFO] [stderr] | [INFO] [stderr] 3 | use mio::tcp::{TcpListener,TcpStream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Events`, `PollOpt`, `Poll`, `Ready` [INFO] [stderr] --> src/server.rs:4:11 [INFO] [stderr] | [INFO] [stderr] 4 | use mio::{Ready, Poll, PollOpt, Token,Events}; [INFO] [stderr] | ^^^^^ ^^^^ ^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `ParserHandler` [INFO] [stderr] --> src/client.rs:1:27 [INFO] [stderr] | [INFO] [stderr] 1 | use http_muncher::{Parser,ParserHandler}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `TcpStream` [INFO] [stderr] --> src/main.rs:13:28 [INFO] [stderr] | [INFO] [stderr] 13 | use mio::tcp::{TcpListener,TcpStream}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `parser` [INFO] [stderr] --> src/http_parser.rs:28:35 [INFO] [stderr] | [INFO] [stderr] 28 | fn on_header_field(&mut self, parser : &mut Parser, header : &[u8]) -> bool [INFO] [stderr] | ^^^^^^ help: consider using `_parser` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `parser` [INFO] [stderr] --> src/http_parser.rs:34:35 [INFO] [stderr] | [INFO] [stderr] 34 | fn on_header_value(&mut self, parser: &mut Parser, value: &[u8]) -> bool [INFO] [stderr] | ^^^^^^ help: consider using `_parser` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `parser` [INFO] [stderr] --> src/http_parser.rs:43:39 [INFO] [stderr] | [INFO] [stderr] 43 | fn on_headers_complete(&mut self, parser : &mut Parser) -> bool [INFO] [stderr] | ^^^^^^ help: consider using `_parser` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `parser` [INFO] [stderr] --> src/http_parser.rs:28:35 [INFO] [stderr] | [INFO] [stderr] 28 | fn on_header_field(&mut self, parser : &mut Parser, header : &[u8]) -> bool [INFO] [stderr] | ^^^^^^ help: consider using `_parser` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `parser` [INFO] [stderr] --> src/http_parser.rs:34:35 [INFO] [stderr] | [INFO] [stderr] 34 | fn on_header_value(&mut self, parser: &mut Parser, value: &[u8]) -> bool [INFO] [stderr] | ^^^^^^ help: consider using `_parser` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `parser` [INFO] [stderr] --> src/http_parser.rs:43:39 [INFO] [stderr] | [INFO] [stderr] 43 | fn on_headers_complete(&mut self, parser : &mut Parser) -> bool [INFO] [stderr] | ^^^^^^ help: consider using `_parser` instead [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/server.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn get_client_ref(&self, token : &Token) -> Option<&WebSocketClient> [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/server.rs:48:50 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn get_client_mut_ref(&mut self, token : &Token) -> Option<&mut WebSocketClient> [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/server.rs:54:44 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn remove_client(&mut self, token : &Token) -> Option [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn gen_key(key: &String) -> String [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/client.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | self.client_socket.write(response.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `chat`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/server.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn get_client_ref(&self, token : &Token) -> Option<&WebSocketClient> [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/server.rs:48:50 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn get_client_mut_ref(&mut self, token : &Token) -> Option<&mut WebSocketClient> [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/server.rs:54:44 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn remove_client(&mut self, token : &Token) -> Option [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn gen_key(key: &String) -> String [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/client.rs:127:9 [INFO] [stderr] | [INFO] [stderr] 127 | self.client_socket.write(response.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `chat`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "36df9757bf697586bbe3471373aae7d57ef7ecd1176a55e7091d85753a80e6d1"` [INFO] running `"docker" "rm" "-f" "36df9757bf697586bbe3471373aae7d57ef7ecd1176a55e7091d85753a80e6d1"` [INFO] [stdout] 36df9757bf697586bbe3471373aae7d57ef7ecd1176a55e7091d85753a80e6d1