[INFO] updating cached repository semperos/github-line-link
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/semperos/github-line-link
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/semperos/github-line-link" "work/ex/clippy-test-run/sources/stable/gh/semperos/github-line-link"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/semperos/github-line-link'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/semperos/github-line-link" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/semperos/github-line-link"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/semperos/github-line-link'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a4aae476dadc6e7115113dd80b22fa0e05efde73
[INFO] sha for GitHub repo semperos/github-line-link: a4aae476dadc6e7115113dd80b22fa0e05efde73
[INFO] validating manifest of semperos/github-line-link on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of semperos/github-line-link on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing semperos/github-line-link
[INFO] finished frobbing semperos/github-line-link
[INFO] frobbed toml for semperos/github-line-link written to work/ex/clippy-test-run/sources/stable/gh/semperos/github-line-link/Cargo.toml
[INFO] started frobbing semperos/github-line-link
[INFO] finished frobbing semperos/github-line-link
[INFO] frobbed toml for semperos/github-line-link written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/semperos/github-line-link/Cargo.toml
[INFO] crate semperos/github-line-link has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting semperos/github-line-link against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/semperos/github-line-link:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7945d1bde1e76223276f8d079f5d9bfdc631fe65cd63d4395b2103f9fa8576e8
[INFO] running `"docker" "start" "-a" "7945d1bde1e76223276f8d079f5d9bfdc631fe65cd63d4395b2103f9fa8576e8"`
[INFO] [stderr]    Compiling gcc v0.3.41
[INFO] [stderr]     Checking openssl-probe v0.1.0
[INFO] [stderr]    Compiling openssl-sys v0.9.4
[INFO] [stderr]     Checking memchr v1.0.0
[INFO] [stderr]     Checking url v1.2.4
[INFO] [stderr]     Checking aho-corasick v0.6.1
[INFO] [stderr]     Checking regex v0.2.1
[INFO] [stderr]    Compiling libz-sys v1.0.10
[INFO] [stderr]    Compiling cmake v0.1.20
[INFO] [stderr]    Compiling curl-sys v0.3.6
[INFO] [stderr]    Compiling libssh2-sys v0.2.5
[INFO] [stderr]    Compiling libgit2-sys v0.6.5
[INFO] [stderr]     Checking git2 v0.6.3
[INFO] [stderr]     Checking github-line-link v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     oid
[INFO] [stderr]    |     ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:20:15
[INFO] [stderr]    |
[INFO] [stderr] 20 |       let oid = match branch_ref.target() {
[INFO] [stderr]    |  _______________^
[INFO] [stderr] 21 | |         Some(target) => target,
[INFO] [stderr] 22 | |         None => panic!("failed to get oid for master branch ref"),
[INFO] [stderr] 23 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:88:12
[INFO] [stderr]    |
[INFO] [stderr] 88 |       } else {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 89 | |         if env::args().len() > 2 {
[INFO] [stderr] 90 | |             let remote_name = match env::args().nth(2) {
[INFO] [stderr] 91 | |                 Some(name) => name,
[INFO] [stderr] ...  |
[INFO] [stderr] 97 | |         }
[INFO] [stderr] 98 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 88 |     } else if env::args().len() > 2 {
[INFO] [stderr] 89 |     let remote_name = match env::args().nth(2) {
[INFO] [stderr] 90 |         Some(name) => name,
[INFO] [stderr] 91 |         None => panic!("rust itself is broken")
[INFO] [stderr] 92 |     };
[INFO] [stderr] 93 |     print_url(&repo, &remote_name);
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     oid
[INFO] [stderr]    |     ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:20:15
[INFO] [stderr]    |
[INFO] [stderr] 20 |       let oid = match branch_ref.target() {
[INFO] [stderr]    |  _______________^
[INFO] [stderr] 21 | |         Some(target) => target,
[INFO] [stderr] 22 | |         None => panic!("failed to get oid for master branch ref"),
[INFO] [stderr] 23 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:88:12
[INFO] [stderr]    |
[INFO] [stderr] 88 |       } else {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 89 | |         if env::args().len() > 2 {
[INFO] [stderr] 90 | |             let remote_name = match env::args().nth(2) {
[INFO] [stderr] 91 | |                 Some(name) => name,
[INFO] [stderr] ...  |
[INFO] [stderr] 97 | |         }
[INFO] [stderr] 98 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 88 |     } else if env::args().len() > 2 {
[INFO] [stderr] 89 |     let remote_name = match env::args().nth(2) {
[INFO] [stderr] 90 |         Some(name) => name,
[INFO] [stderr] 91 |         None => panic!("rust itself is broken")
[INFO] [stderr] 92 |     };
[INFO] [stderr] 93 |     print_url(&repo, &remote_name);
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2m 57s
[INFO] running `"docker" "inspect" "7945d1bde1e76223276f8d079f5d9bfdc631fe65cd63d4395b2103f9fa8576e8"`
[INFO] running `"docker" "rm" "-f" "7945d1bde1e76223276f8d079f5d9bfdc631fe65cd63d4395b2103f9fa8576e8"`
[INFO] [stdout] 7945d1bde1e76223276f8d079f5d9bfdc631fe65cd63d4395b2103f9fa8576e8