[INFO] updating cached repository semantic-rs/semantic-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/semantic-rs/semantic-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/semantic-rs/semantic-rs" "work/ex/clippy-test-run/sources/stable/gh/semantic-rs/semantic-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/semantic-rs/semantic-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/semantic-rs/semantic-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/semantic-rs/semantic-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/semantic-rs/semantic-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 144168b9aff72fee45be0a232cf66dd2ef1de128
[INFO] sha for GitHub repo semantic-rs/semantic-rs: 144168b9aff72fee45be0a232cf66dd2ef1de128
[INFO] validating manifest of semantic-rs/semantic-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of semantic-rs/semantic-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing semantic-rs/semantic-rs
[INFO] finished frobbing semantic-rs/semantic-rs
[INFO] frobbed toml for semantic-rs/semantic-rs written to work/ex/clippy-test-run/sources/stable/gh/semantic-rs/semantic-rs/Cargo.toml
[INFO] started frobbing semantic-rs/semantic-rs
[INFO] finished frobbing semantic-rs/semantic-rs
[INFO] frobbed toml for semantic-rs/semantic-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/semantic-rs/semantic-rs/Cargo.toml
[INFO] crate semantic-rs/semantic-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting semantic-rs/semantic-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/semantic-rs/semantic-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bc50f359b52e807fb485fbc026f9409fe67bb64162ef7345e3996dbb8d063888
[INFO] running `"docker" "start" "-a" "bc50f359b52e807fb485fbc026f9409fe67bb64162ef7345e3996dbb8d063888"`
[INFO] [stderr]     Checking serde v0.9.13
[INFO] [stderr]     Checking nom v1.2.4
[INFO] [stderr]     Checking openssl-probe v0.1.0
[INFO] [stderr]    Compiling openssl-sys v0.9.10
[INFO] [stderr]     Checking time v0.1.36
[INFO] [stderr]     Checking num_cpus v1.3.0
[INFO] [stderr]     Checking memchr v0.1.11
[INFO] [stderr]    Compiling cmake v0.1.32
[INFO] [stderr]     Checking toml v0.1.30
[INFO] [stderr]    Compiling hyper v0.10.6
[INFO] [stderr]     Checking aho-corasick v0.5.3
[INFO] [stderr]     Checking thread-id v2.0.0
[INFO] [stderr]     Checking term v0.2.14
[INFO] [stderr]    Compiling serde_derive v0.9.13
[INFO] [stderr]    Compiling libssh2-sys v0.2.10
[INFO] [stderr]    Compiling libgit2-sys v0.7.7
[INFO] [stderr]     Checking semver v0.2.3
[INFO] [stderr]     Checking thread_local v0.2.7
[INFO] [stderr]    Compiling openssl v0.9.10
[INFO] [stderr]    Compiling curl-sys v0.4.8
[INFO] [stderr]     Checking regex v0.1.80
[INFO] [stderr]     Checking env_logger v0.3.5
[INFO] [stderr]     Checking clog v0.9.1
[INFO] [stderr]     Checking native-tls v0.1.2
[INFO] [stderr]     Checking hyper-native-tls v0.2.2
[INFO] [stderr]     Checking serde_urlencoded v0.4.2
[INFO] [stderr]     Checking serde_json v0.9.9
[INFO] [stderr]     Checking reqwest v0.4.0
[INFO] [stderr]     Checking hubcaps v0.3.1
[INFO] [stderr]     Checking travis-after-all v2.0.0
[INFO] [stderr]     Checking git2 v0.7.5
[INFO] [stderr]     Checking semantic-rs v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:44:17
[INFO] [stderr]    |
[INFO] [stderr] 44 | const VERSION: &'static str = env!("CARGO_PKG_VERSION");
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:45:19
[INFO] [stderr]    |
[INFO] [stderr] 45 | const USERAGENT: &'static str = concat!("semantic-rs/", env!("CARGO_PKG_VERSION"));
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:47:33
[INFO] [stderr]    |
[INFO] [stderr] 47 | const COMMITTER_ERROR_MESSAGE: &'static str = r"
[INFO] [stderr]    |                                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:44:17
[INFO] [stderr]    |
[INFO] [stderr] 44 | const VERSION: &'static str = env!("CARGO_PKG_VERSION");
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:45:19
[INFO] [stderr]    |
[INFO] [stderr] 45 | const USERAGENT: &'static str = concat!("semantic-rs/", env!("CARGO_PKG_VERSION"));
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:47:33
[INFO] [stderr]    |
[INFO] [stderr] 47 | const COMMITTER_ERROR_MESSAGE: &'static str = r"
[INFO] [stderr]    |                                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/git.rs:122:5
[INFO] [stderr]     |
[INFO] [stderr] 122 |     format!("Bump version to {}", new_version).into()
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Bump version to {}", new_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:133:33
[INFO] [stderr]     |
[INFO] [stderr] 133 |             branch: self.branch.unwrap_or("master".into()),
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "master".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:141:33
[INFO] [stderr]     |
[INFO] [stderr] 141 |             remote: self.remote.unwrap_or(Err("No remote found".into()))
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Err("No remote found".into()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/utils.rs:6:29
[INFO] [stderr]   |
[INFO] [stderr] 6 |             match url.rfind(":") {
[INFO] [stderr]   |                             ^^^ help: try using a char instead: `':'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:147:78
[INFO] [stderr]     |
[INFO] [stderr] 147 | fn generate_changelog(repository_path: &str, version: &Version, new_version: &String) -> String {
[INFO] [stderr]     |                                                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/toml_file.rs:111:67
[INFO] [stderr]     |
[INFO] [stderr] 111 |         let new_toml_file = file_with_new_version(example_file(), "0.2.0".into());
[INFO] [stderr]     |                                                                   ^^^^^^^^^^^^^^ help: consider removing `.into()`: `"0.2.0"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/git.rs:122:5
[INFO] [stderr]     |
[INFO] [stderr] 122 |     format!("Bump version to {}", new_version).into()
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Bump version to {}", new_version)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:133:33
[INFO] [stderr]     |
[INFO] [stderr] 133 |             branch: self.branch.unwrap_or("master".into()),
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "master".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:141:33
[INFO] [stderr]     |
[INFO] [stderr] 141 |             remote: self.remote.unwrap_or(Err("No remote found".into()))
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Err("No remote found".into()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/utils.rs:6:29
[INFO] [stderr]   |
[INFO] [stderr] 6 |             match url.rfind(":") {
[INFO] [stderr]   |                             ^^^ help: try using a char instead: `':'`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:147:78
[INFO] [stderr]     |
[INFO] [stderr] 147 | fn generate_changelog(repository_path: &str, version: &Version, new_version: &String) -> String {
[INFO] [stderr]     |                                                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3m 09s
[INFO] running `"docker" "inspect" "bc50f359b52e807fb485fbc026f9409fe67bb64162ef7345e3996dbb8d063888"`
[INFO] running `"docker" "rm" "-f" "bc50f359b52e807fb485fbc026f9409fe67bb64162ef7345e3996dbb8d063888"`
[INFO] [stdout] bc50f359b52e807fb485fbc026f9409fe67bb64162ef7345e3996dbb8d063888