[INFO] updating cached repository seiks/bitbar-ip-addr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/seiks/bitbar-ip-addr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/seiks/bitbar-ip-addr" "work/ex/clippy-test-run/sources/stable/gh/seiks/bitbar-ip-addr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/seiks/bitbar-ip-addr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/seiks/bitbar-ip-addr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seiks/bitbar-ip-addr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seiks/bitbar-ip-addr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1445df362ea6591832f216c69dcb5e4433109849 [INFO] sha for GitHub repo seiks/bitbar-ip-addr: 1445df362ea6591832f216c69dcb5e4433109849 [INFO] validating manifest of seiks/bitbar-ip-addr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of seiks/bitbar-ip-addr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing seiks/bitbar-ip-addr [INFO] finished frobbing seiks/bitbar-ip-addr [INFO] frobbed toml for seiks/bitbar-ip-addr written to work/ex/clippy-test-run/sources/stable/gh/seiks/bitbar-ip-addr/Cargo.toml [INFO] started frobbing seiks/bitbar-ip-addr [INFO] finished frobbing seiks/bitbar-ip-addr [INFO] frobbed toml for seiks/bitbar-ip-addr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seiks/bitbar-ip-addr/Cargo.toml [INFO] crate seiks/bitbar-ip-addr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting seiks/bitbar-ip-addr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/seiks/bitbar-ip-addr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 26504e980277a15f609f5403cc2b464229d1a9972753e1e9e7e1a98f0403f6d7 [INFO] running `"docker" "start" "-a" "26504e980277a15f609f5403cc2b464229d1a9972753e1e9e7e1a98f0403f6d7"` [INFO] [stderr] Checking bitbar-ip-addr v1.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitbar_plugin.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | Ok(BitBarPlugin { ifconfig: ifconfig }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ifconfig` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitbar_plugin.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | Ok(BitBarPlugin { ifconfig: ifconfig }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ifconfig` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bitbar_plugin.rs:123:11 [INFO] [stderr] | [INFO] [stderr] 123 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 124 | | if !regex_section_start.is_match(line) { [INFO] [stderr] 125 | | result.push_str(line); [INFO] [stderr] 126 | | } else { [INFO] [stderr] 127 | | return Ok(result); [INFO] [stderr] 128 | | } [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 123 | } else if !regex_section_start.is_match(line) { [INFO] [stderr] 124 | result.push_str(line); [INFO] [stderr] 125 | } else { [INFO] [stderr] 126 | return Ok(result); [INFO] [stderr] 127 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bitbar_plugin.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | if regex_section_start.is_match(line) { [INFO] [stderr] | _________________^ [INFO] [stderr] 118 | | if line.starts_with(interface) { [INFO] [stderr] 119 | | result.push_str(line); [INFO] [stderr] 120 | | starting_point_found = true; [INFO] [stderr] 121 | | } [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 117 | if regex_section_start.is_match(line) && line.starts_with(interface) { [INFO] [stderr] 118 | result.push_str(line); [INFO] [stderr] 119 | starting_point_found = true; [INFO] [stderr] 120 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bitbar_plugin.rs:123:11 [INFO] [stderr] | [INFO] [stderr] 123 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 124 | | if !regex_section_start.is_match(line) { [INFO] [stderr] 125 | | result.push_str(line); [INFO] [stderr] 126 | | } else { [INFO] [stderr] 127 | | return Ok(result); [INFO] [stderr] 128 | | } [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 123 | } else if !regex_section_start.is_match(line) { [INFO] [stderr] 124 | result.push_str(line); [INFO] [stderr] 125 | } else { [INFO] [stderr] 126 | return Ok(result); [INFO] [stderr] 127 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bitbar_plugin.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | if regex_section_start.is_match(line) { [INFO] [stderr] | _________________^ [INFO] [stderr] 118 | | if line.starts_with(interface) { [INFO] [stderr] 119 | | result.push_str(line); [INFO] [stderr] 120 | | starting_point_found = true; [INFO] [stderr] 121 | | } [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 117 | if regex_section_start.is_match(line) && line.starts_with(interface) { [INFO] [stderr] 118 | result.push_str(line); [INFO] [stderr] 119 | starting_point_found = true; [INFO] [stderr] 120 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bitbar_plugin.rs:39:15 [INFO] [stderr] | [INFO] [stderr] 39 | interfaces: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bitbar_plugin.rs:56:15 [INFO] [stderr] | [INFO] [stderr] 56 | interfaces: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bitbar_plugin.rs:77:38 [INFO] [stderr] | [INFO] [stderr] 77 | let ifconfig_iter = ifconfig.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bitbar_plugin.rs:109:41 [INFO] [stderr] | [INFO] [stderr] 109 | fn interface_section(&self, interface: &String) -> Result> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bitbar_plugin.rs:136:44 [INFO] [stderr] | [INFO] [stderr] 136 | fn local_ipv4_addresses(&self, interface: &String) -> Result, Box> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bitbar_plugin.rs:160:44 [INFO] [stderr] | [INFO] [stderr] 160 | fn local_ipv6_addresses(&self, interface: &String) -> Result, Box> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bitbar_plugin.rs:39:15 [INFO] [stderr] | [INFO] [stderr] 39 | interfaces: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bitbar_plugin.rs:56:15 [INFO] [stderr] | [INFO] [stderr] 56 | interfaces: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bitbar_plugin.rs:77:38 [INFO] [stderr] | [INFO] [stderr] 77 | let ifconfig_iter = ifconfig.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bitbar_plugin.rs:109:41 [INFO] [stderr] | [INFO] [stderr] 109 | fn interface_section(&self, interface: &String) -> Result> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bitbar_plugin.rs:136:44 [INFO] [stderr] | [INFO] [stderr] 136 | fn local_ipv4_addresses(&self, interface: &String) -> Result, Box> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bitbar_plugin.rs:160:44 [INFO] [stderr] | [INFO] [stderr] 160 | fn local_ipv6_addresses(&self, interface: &String) -> Result, Box> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.19s [INFO] running `"docker" "inspect" "26504e980277a15f609f5403cc2b464229d1a9972753e1e9e7e1a98f0403f6d7"` [INFO] running `"docker" "rm" "-f" "26504e980277a15f609f5403cc2b464229d1a9972753e1e9e7e1a98f0403f6d7"` [INFO] [stdout] 26504e980277a15f609f5403cc2b464229d1a9972753e1e9e7e1a98f0403f6d7