[INFO] updating cached repository seiks/bitbar-bandwidth-monitor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/seiks/bitbar-bandwidth-monitor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/seiks/bitbar-bandwidth-monitor" "work/ex/clippy-test-run/sources/stable/gh/seiks/bitbar-bandwidth-monitor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/seiks/bitbar-bandwidth-monitor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/seiks/bitbar-bandwidth-monitor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seiks/bitbar-bandwidth-monitor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seiks/bitbar-bandwidth-monitor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 40c77366c7a569c46d78fa3f43d76f09ec4c5c91 [INFO] sha for GitHub repo seiks/bitbar-bandwidth-monitor: 40c77366c7a569c46d78fa3f43d76f09ec4c5c91 [INFO] validating manifest of seiks/bitbar-bandwidth-monitor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of seiks/bitbar-bandwidth-monitor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing seiks/bitbar-bandwidth-monitor [INFO] finished frobbing seiks/bitbar-bandwidth-monitor [INFO] frobbed toml for seiks/bitbar-bandwidth-monitor written to work/ex/clippy-test-run/sources/stable/gh/seiks/bitbar-bandwidth-monitor/Cargo.toml [INFO] started frobbing seiks/bitbar-bandwidth-monitor [INFO] finished frobbing seiks/bitbar-bandwidth-monitor [INFO] frobbed toml for seiks/bitbar-bandwidth-monitor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seiks/bitbar-bandwidth-monitor/Cargo.toml [INFO] crate seiks/bitbar-bandwidth-monitor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting seiks/bitbar-bandwidth-monitor against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/seiks/bitbar-bandwidth-monitor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d262d6dbe62f1b8e5b28800d8891a8e37aca7efd310bb6c7ea5c911f78d69a8e [INFO] running `"docker" "start" "-a" "d262d6dbe62f1b8e5b28800d8891a8e37aca7efd310bb6c7ea5c911f78d69a8e"` [INFO] [stderr] Checking bitbar-bandwidth-monitor v1.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:29 [INFO] [stderr] | [INFO] [stderr] 10 | const ERR_COMMAND_FAILURE: &'static str = "failed to execute process"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | const ERR_ENV_FAILURE: &'static str = "failed in fetching environment variable"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:12:30 [INFO] [stderr] | [INFO] [stderr] 12 | const ERR_ITERATOR_FAILURE: &'static str = "failed while iterating"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:39 [INFO] [stderr] | [INFO] [stderr] 13 | const ERR_STRING_CONVERSION_FAILURE: &'static str = "failed in string conversion"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:34:2 [INFO] [stderr] | [INFO] [stderr] 34 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:67:2 [INFO] [stderr] | [INFO] [stderr] 67 | return values; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:55:16 [INFO] [stderr] | [INFO] [stderr] 55 | for (a, b) in output [INFO] [stderr] | ___________________^ [INFO] [stderr] 56 | | .lines() [INFO] [stderr] 57 | | .skip(2) [INFO] [stderr] 58 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:77:36 [INFO] [stderr] | [INFO] [stderr] 77 | for interface in interfaces.split(",").skip(1) { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:29 [INFO] [stderr] | [INFO] [stderr] 10 | const ERR_COMMAND_FAILURE: &'static str = "failed to execute process"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | const ERR_ENV_FAILURE: &'static str = "failed in fetching environment variable"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:12:30 [INFO] [stderr] | [INFO] [stderr] 12 | const ERR_ITERATOR_FAILURE: &'static str = "failed while iterating"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:39 [INFO] [stderr] | [INFO] [stderr] 13 | const ERR_STRING_CONVERSION_FAILURE: &'static str = "failed in string conversion"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:34:2 [INFO] [stderr] | [INFO] [stderr] 34 | return output; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:67:2 [INFO] [stderr] | [INFO] [stderr] 67 | return values; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:55:16 [INFO] [stderr] | [INFO] [stderr] 55 | for (a, b) in output [INFO] [stderr] | ___________________^ [INFO] [stderr] 56 | | .lines() [INFO] [stderr] 57 | | .skip(2) [INFO] [stderr] 58 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:77:36 [INFO] [stderr] | [INFO] [stderr] 77 | for interface in interfaces.split(",").skip(1) { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.74s [INFO] running `"docker" "inspect" "d262d6dbe62f1b8e5b28800d8891a8e37aca7efd310bb6c7ea5c911f78d69a8e"` [INFO] running `"docker" "rm" "-f" "d262d6dbe62f1b8e5b28800d8891a8e37aca7efd310bb6c7ea5c911f78d69a8e"` [INFO] [stdout] d262d6dbe62f1b8e5b28800d8891a8e37aca7efd310bb6c7ea5c911f78d69a8e