[INFO] updating cached repository seifriedc/blackjack-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/seifriedc/blackjack-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/seifriedc/blackjack-rust" "work/ex/clippy-test-run/sources/stable/gh/seifriedc/blackjack-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/seifriedc/blackjack-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/seifriedc/blackjack-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seifriedc/blackjack-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seifriedc/blackjack-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7e43a6c4a9bda67ced5570244b009e00dc166408 [INFO] sha for GitHub repo seifriedc/blackjack-rust: 7e43a6c4a9bda67ced5570244b009e00dc166408 [INFO] validating manifest of seifriedc/blackjack-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of seifriedc/blackjack-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing seifriedc/blackjack-rust [INFO] finished frobbing seifriedc/blackjack-rust [INFO] frobbed toml for seifriedc/blackjack-rust written to work/ex/clippy-test-run/sources/stable/gh/seifriedc/blackjack-rust/Cargo.toml [INFO] started frobbing seifriedc/blackjack-rust [INFO] finished frobbing seifriedc/blackjack-rust [INFO] frobbed toml for seifriedc/blackjack-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seifriedc/blackjack-rust/Cargo.toml [INFO] crate seifriedc/blackjack-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting seifriedc/blackjack-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/seifriedc/blackjack-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2bc9e90143f16859d1ffbb70116a46769f783e3949063f489d0a0cf1dccbca1d [INFO] running `"docker" "start" "-a" "2bc9e90143f16859d1ffbb70116a46769f783e3949063f489d0a0cf1dccbca1d"` [INFO] [stderr] Checking blackjack v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | return temp; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `temp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | return temp; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `temp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | self.hand = self.hand - (self.num_aces * 10); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.hand -= (self.num_aces * 10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | self.hand = self.hand - (self.num_aces * 10); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.hand -= (self.num_aces * 10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "2bc9e90143f16859d1ffbb70116a46769f783e3949063f489d0a0cf1dccbca1d"` [INFO] running `"docker" "rm" "-f" "2bc9e90143f16859d1ffbb70116a46769f783e3949063f489d0a0cf1dccbca1d"` [INFO] [stdout] 2bc9e90143f16859d1ffbb70116a46769f783e3949063f489d0a0cf1dccbca1d