[INFO] updating cached repository segler-alex/stream-check-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/segler-alex/stream-check-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/segler-alex/stream-check-rust" "work/ex/clippy-test-run/sources/stable/gh/segler-alex/stream-check-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/segler-alex/stream-check-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/segler-alex/stream-check-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segler-alex/stream-check-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segler-alex/stream-check-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cc2f4f1b1cdb33ee721f182b8342ecee37acd8ea [INFO] sha for GitHub repo segler-alex/stream-check-rust: cc2f4f1b1cdb33ee721f182b8342ecee37acd8ea [INFO] validating manifest of segler-alex/stream-check-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of segler-alex/stream-check-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing segler-alex/stream-check-rust [INFO] finished frobbing segler-alex/stream-check-rust [INFO] frobbed toml for segler-alex/stream-check-rust written to work/ex/clippy-test-run/sources/stable/gh/segler-alex/stream-check-rust/Cargo.toml [INFO] started frobbing segler-alex/stream-check-rust [INFO] finished frobbing segler-alex/stream-check-rust [INFO] frobbed toml for segler-alex/stream-check-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segler-alex/stream-check-rust/Cargo.toml [INFO] crate segler-alex/stream-check-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting segler-alex/stream-check-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/segler-alex/stream-check-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4f1aea0b42d056280c959b50826d63d142a19e33fe61c0c09eac3d860ca34473 [INFO] running `"docker" "start" "-a" "4f1aea0b42d056280c959b50826d63d142a19e33fe61c0c09eac3d860ca34473"` [INFO] [stderr] Checking crossbeam-utils v0.3.2 [INFO] [stderr] Checking hostname v0.1.4 [INFO] [stderr] Checking nix v0.9.0 [INFO] [stderr] Checking atoi v0.2.3 [INFO] [stderr] Checking serde_json v1.0.13 [INFO] [stderr] Checking hls_m3u8 v0.1.1 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking chrono v0.4.1 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking regex v0.2.10 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking crossbeam-epoch v0.4.1 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Checking quick-xml v0.12.1 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.4 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-threadpool v0.1.3 [INFO] [stderr] Checking mysql_common v0.5.0 [INFO] [stderr] Checking playlist-decoder v0.7.0 [INFO] [stderr] Checking website-icon-extract v0.3.0 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking av-stream-info-rust v0.4.0 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking mysql v12.3.1 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking stream-check-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/check.rs:165:37 [INFO] [stderr] | [INFO] [stderr] 165 | codec: codec, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `codec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/check.rs:165:37 [INFO] [stderr] | [INFO] [stderr] 165 | codec: codec, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `codec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/check.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | return (retval, result.green().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(retval, result.green().to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/check.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | return (retval, result.red().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(retval, result.red().to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/check.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return (retval, result.yellow().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(retval, result.yellow().to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/check.rs:89:12 [INFO] [stderr] | [INFO] [stderr] 89 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 90 | | if verbosity > 0 { [INFO] [stderr] 91 | | println!("{}", change_str.dimmed()); [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 89 | } else if verbosity > 0 { [INFO] [stderr] 90 | println!("{}", change_str.dimmed()); [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/favicon.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 28 | | if verbosity > 0 { [INFO] [stderr] 29 | | println!("No favicons found for: {}", homepage); [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 27 | } else if verbosity > 0 { [INFO] [stderr] 28 | println!("No favicons found for: {}", homepage); [INFO] [stderr] 29 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/favicon.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/favicon.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/check.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | return (retval, result.green().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(retval, result.green().to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/check.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | return (retval, result.red().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(retval, result.red().to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/check.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return (retval, result.yellow().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(retval, result.yellow().to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/check.rs:89:12 [INFO] [stderr] | [INFO] [stderr] 89 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 90 | | if verbosity > 0 { [INFO] [stderr] 91 | | println!("{}", change_str.dimmed()); [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 89 | } else if verbosity > 0 { [INFO] [stderr] 90 | println!("{}", change_str.dimmed()); [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/favicon.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 28 | | if verbosity > 0 { [INFO] [stderr] 29 | | println!("No favicons found for: {}", homepage); [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 27 | } else if verbosity > 0 { [INFO] [stderr] 28 | println!("No favicons found for: {}", homepage); [INFO] [stderr] 29 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/favicon.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/favicon.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/check.rs:96:1 [INFO] [stderr] | [INFO] [stderr] 96 | / pub fn dbcheck( [INFO] [stderr] 97 | | connection_str: &str, [INFO] [stderr] 98 | | source: &str, [INFO] [stderr] 99 | | concurrency: usize, [INFO] [stderr] ... | [INFO] [stderr] 195 | | checked_count [INFO] [stderr] 196 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/check.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | checked_count = checked_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `checked_count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/check.rs:123:39 [INFO] [stderr] | [INFO] [stderr] 123 | let max_timeout = (retries as u32) * timeout * 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(retries)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/check.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | / match item { [INFO] [stderr] 156 | | &Ok(ref item) => { [INFO] [stderr] 157 | | let mut codec = item.CodecAudio.clone(); [INFO] [stderr] 158 | | if let Some(ref video) = item.CodecVideo { [INFO] [stderr] ... | [INFO] [stderr] 172 | | &Err(_) => {} [INFO] [stderr] 173 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *item { [INFO] [stderr] 156 | Ok(ref item) => { [INFO] [stderr] 157 | let mut codec = item.CodecAudio.clone(); [INFO] [stderr] 158 | if let Some(ref video) = item.CodecVideo { [INFO] [stderr] 159 | codec.push_str(","); [INFO] [stderr] 160 | codec.push_str(&video); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_result)] on by default [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:21:58 [INFO] [stderr] | [INFO] [stderr] 21 | uuid: row.take("StationUuid").unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:22:85 [INFO] [stderr] | [INFO] [stderr] 22 | name: row.take_opt("Name").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:22:55 [INFO] [stderr] | [INFO] [stderr] 22 | name: row.take_opt("Name").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok("".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:23:84 [INFO] [stderr] | [INFO] [stderr] 23 | url: row.take_opt("Url").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:23:54 [INFO] [stderr] | [INFO] [stderr] 23 | url: row.take_opt("Url").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok("".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:24:89 [INFO] [stderr] | [INFO] [stderr] 24 | urlcache: row.take_opt("UrlCache").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:24:59 [INFO] [stderr] | [INFO] [stderr] 24 | urlcache: row.take_opt("UrlCache").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok("".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:25:86 [INFO] [stderr] | [INFO] [stderr] 25 | codec: row.take_opt("Codec").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:25:56 [INFO] [stderr] | [INFO] [stderr] 25 | codec: row.take_opt("Codec").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok("".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:29:88 [INFO] [stderr] | [INFO] [stderr] 29 | favicon: row.take_opt("Favicon").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:29:58 [INFO] [stderr] | [INFO] [stderr] 29 | favicon: row.take_opt("Favicon").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok("".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:30:89 [INFO] [stderr] | [INFO] [stderr] 30 | homepage: row.take_opt("Homepage").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:30:59 [INFO] [stderr] | [INFO] [stderr] 30 | homepage: row.take_opt("Homepage").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok("".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/db.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | let query = format!("SELECT COUNT(*) AS Items FROM radio.Station WHERE LastCheckOK=0 OR LastCheckOK IS NULL"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SELECT COUNT(*) AS Items FROM radio.Station WHERE LastCheckOK=0 OR LastCheckOK IS NULL".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:42:19 [INFO] [stderr] | [INFO] [stderr] 42 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/db.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / for row_ in result { [INFO] [stderr] 44 | | let mut row = row_.unwrap(); [INFO] [stderr] 45 | | let items: u32 = row.take_opt("Items").unwrap_or(Ok(0)).unwrap_or(0); [INFO] [stderr] 46 | | return items; [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/db.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | let query = format!("SELECT COUNT(*) AS Items FROM radio.Station WHERE LastCheckOK=1"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SELECT COUNT(*) AS Items FROM radio.Station WHERE LastCheckOK=1".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:55:19 [INFO] [stderr] | [INFO] [stderr] 55 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/db.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / for row_ in result { [INFO] [stderr] 57 | | let mut row = row_.unwrap(); [INFO] [stderr] 58 | | let items: u32 = row.take_opt("Items").unwrap_or(Ok(0)).unwrap_or(0); [INFO] [stderr] 59 | | return items; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/db.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / for row_ in result { [INFO] [stderr] 70 | | let mut row = row_.unwrap(); [INFO] [stderr] 71 | | let items: u32 = row.take_opt("Items").unwrap_or(Ok(0)).unwrap_or(0); [INFO] [stderr] 72 | | return items; [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/db.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / for row_ in result { [INFO] [stderr] 83 | | let mut row = row_.unwrap(); [INFO] [stderr] 84 | | let items: u32 = row.take_opt("Items").unwrap_or(Ok(0)).unwrap_or(0); [INFO] [stderr] 85 | | return items; [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/db.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / for row_ in result { [INFO] [stderr] 96 | | let mut row = row_.unwrap(); [INFO] [stderr] 97 | | let items: u32 = row.take_opt("Items").unwrap_or(Ok(0)).unwrap_or(0); [INFO] [stderr] 98 | | return items; [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:107:19 [INFO] [stderr] | [INFO] [stderr] 107 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/db.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | / for row_ in result { [INFO] [stderr] 109 | | let mut row = row_.unwrap(); [INFO] [stderr] 110 | | let items: u32 = row.take_opt("Items").unwrap_or(Ok(0)).unwrap_or(0); [INFO] [stderr] 111 | | return items; [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/db.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / let mut query: String = String::from("UPDATE Station SET LastCheckTime=NOW(),LastCheckOkTime=NOW(),LastCheckOk=?,Codec=?,Bitrate=?,UrlCache=? WHERE StationUuid=?"); [INFO] [stderr] 149 | | if !item.check_ok{ [INFO] [stderr] 150 | | query = format!("UPDATE Station SET LastCheckTime=NOW(),LastCheckOk=?,Codec=?,Bitrate=?,UrlCache=? WHERE StationUuid=?"); [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let query = if !item.check_ok { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { String::from("UPDATE Station SET LastCheckTime=NOW(),LastCheckOkTime=NOW(),LastCheckOk=?,Codec=?,Bitrate=?,UrlCache=? WHERE StationUuid=?") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/db.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | query = format!("UPDATE Station SET LastCheckTime=NOW(),LastCheckOk=?,Codec=?,Bitrate=?,UrlCache=? WHERE StationUuid=?"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"UPDATE Station SET LastCheckTime=NOW(),LastCheckOk=?,Codec=?,Bitrate=?,UrlCache=? WHERE StationUuid=?".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/favicon.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | if icons.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!icons.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:26:43 [INFO] [stderr] | [INFO] [stderr] 26 | let hostname: String = get_hostname().unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 13 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `stream-check-rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/check.rs:96:1 [INFO] [stderr] | [INFO] [stderr] 96 | / pub fn dbcheck( [INFO] [stderr] 97 | | connection_str: &str, [INFO] [stderr] 98 | | source: &str, [INFO] [stderr] 99 | | concurrency: usize, [INFO] [stderr] ... | [INFO] [stderr] 195 | | checked_count [INFO] [stderr] 196 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/check.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | checked_count = checked_count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `checked_count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/check.rs:123:39 [INFO] [stderr] | [INFO] [stderr] 123 | let max_timeout = (retries as u32) * timeout * 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(retries)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/check.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | / match item { [INFO] [stderr] 156 | | &Ok(ref item) => { [INFO] [stderr] 157 | | let mut codec = item.CodecAudio.clone(); [INFO] [stderr] 158 | | if let Some(ref video) = item.CodecVideo { [INFO] [stderr] ... | [INFO] [stderr] 172 | | &Err(_) => {} [INFO] [stderr] 173 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *item { [INFO] [stderr] 156 | Ok(ref item) => { [INFO] [stderr] 157 | let mut codec = item.CodecAudio.clone(); [INFO] [stderr] 158 | if let Some(ref video) = item.CodecVideo { [INFO] [stderr] 159 | codec.push_str(","); [INFO] [stderr] 160 | codec.push_str(&video); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_result)] on by default [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:21:58 [INFO] [stderr] | [INFO] [stderr] 21 | uuid: row.take("StationUuid").unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:22:85 [INFO] [stderr] | [INFO] [stderr] 22 | name: row.take_opt("Name").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:22:55 [INFO] [stderr] | [INFO] [stderr] 22 | name: row.take_opt("Name").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok("".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:23:84 [INFO] [stderr] | [INFO] [stderr] 23 | url: row.take_opt("Url").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:23:54 [INFO] [stderr] | [INFO] [stderr] 23 | url: row.take_opt("Url").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok("".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:24:89 [INFO] [stderr] | [INFO] [stderr] 24 | urlcache: row.take_opt("UrlCache").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:24:59 [INFO] [stderr] | [INFO] [stderr] 24 | urlcache: row.take_opt("UrlCache").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok("".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:25:86 [INFO] [stderr] | [INFO] [stderr] 25 | codec: row.take_opt("Codec").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:25:56 [INFO] [stderr] | [INFO] [stderr] 25 | codec: row.take_opt("Codec").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok("".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:29:88 [INFO] [stderr] | [INFO] [stderr] 29 | favicon: row.take_opt("Favicon").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:29:58 [INFO] [stderr] | [INFO] [stderr] 29 | favicon: row.take_opt("Favicon").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok("".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:30:89 [INFO] [stderr] | [INFO] [stderr] 30 | homepage: row.take_opt("Homepage").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db.rs:30:59 [INFO] [stderr] | [INFO] [stderr] 30 | homepage: row.take_opt("Homepage").unwrap_or(Ok("".to_string())).unwrap_or("".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok("".to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/db.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | let query = format!("SELECT COUNT(*) AS Items FROM radio.Station WHERE LastCheckOK=0 OR LastCheckOK IS NULL"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SELECT COUNT(*) AS Items FROM radio.Station WHERE LastCheckOK=0 OR LastCheckOK IS NULL".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:42:19 [INFO] [stderr] | [INFO] [stderr] 42 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/db.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / for row_ in result { [INFO] [stderr] 44 | | let mut row = row_.unwrap(); [INFO] [stderr] 45 | | let items: u32 = row.take_opt("Items").unwrap_or(Ok(0)).unwrap_or(0); [INFO] [stderr] 46 | | return items; [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/db.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | let query = format!("SELECT COUNT(*) AS Items FROM radio.Station WHERE LastCheckOK=1"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SELECT COUNT(*) AS Items FROM radio.Station WHERE LastCheckOK=1".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:55:19 [INFO] [stderr] | [INFO] [stderr] 55 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/db.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / for row_ in result { [INFO] [stderr] 57 | | let mut row = row_.unwrap(); [INFO] [stderr] 58 | | let items: u32 = row.take_opt("Items").unwrap_or(Ok(0)).unwrap_or(0); [INFO] [stderr] 59 | | return items; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/db.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / for row_ in result { [INFO] [stderr] 70 | | let mut row = row_.unwrap(); [INFO] [stderr] 71 | | let items: u32 = row.take_opt("Items").unwrap_or(Ok(0)).unwrap_or(0); [INFO] [stderr] 72 | | return items; [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/db.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / for row_ in result { [INFO] [stderr] 83 | | let mut row = row_.unwrap(); [INFO] [stderr] 84 | | let items: u32 = row.take_opt("Items").unwrap_or(Ok(0)).unwrap_or(0); [INFO] [stderr] 85 | | return items; [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/db.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / for row_ in result { [INFO] [stderr] 96 | | let mut row = row_.unwrap(); [INFO] [stderr] 97 | | let items: u32 = row.take_opt("Items").unwrap_or(Ok(0)).unwrap_or(0); [INFO] [stderr] 98 | | return items; [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/db.rs:107:19 [INFO] [stderr] | [INFO] [stderr] 107 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/db.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | / for row_ in result { [INFO] [stderr] 109 | | let mut row = row_.unwrap(); [INFO] [stderr] 110 | | let items: u32 = row.take_opt("Items").unwrap_or(Ok(0)).unwrap_or(0); [INFO] [stderr] 111 | | return items; [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/db.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | / let mut query: String = String::from("UPDATE Station SET LastCheckTime=NOW(),LastCheckOkTime=NOW(),LastCheckOk=?,Codec=?,Bitrate=?,UrlCache=? WHERE StationUuid=?"); [INFO] [stderr] 149 | | if !item.check_ok{ [INFO] [stderr] 150 | | query = format!("UPDATE Station SET LastCheckTime=NOW(),LastCheckOk=?,Codec=?,Bitrate=?,UrlCache=? WHERE StationUuid=?"); [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let query = if !item.check_ok { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { String::from("UPDATE Station SET LastCheckTime=NOW(),LastCheckOkTime=NOW(),LastCheckOk=?,Codec=?,Bitrate=?,UrlCache=? WHERE StationUuid=?") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/db.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | query = format!("UPDATE Station SET LastCheckTime=NOW(),LastCheckOk=?,Codec=?,Bitrate=?,UrlCache=? WHERE StationUuid=?"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"UPDATE Station SET LastCheckTime=NOW(),LastCheckOk=?,Codec=?,Bitrate=?,UrlCache=? WHERE StationUuid=?".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/favicon.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | if icons.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!icons.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:26:43 [INFO] [stderr] | [INFO] [stderr] 26 | let hostname: String = get_hostname().unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 13 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `stream-check-rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4f1aea0b42d056280c959b50826d63d142a19e33fe61c0c09eac3d860ca34473"` [INFO] running `"docker" "rm" "-f" "4f1aea0b42d056280c959b50826d63d142a19e33fe61c0c09eac3d860ca34473"` [INFO] [stdout] 4f1aea0b42d056280c959b50826d63d142a19e33fe61c0c09eac3d860ca34473