[INFO] updating cached repository segler-alex/radiobrowser-cleanup-tasks-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/segler-alex/radiobrowser-cleanup-tasks-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/segler-alex/radiobrowser-cleanup-tasks-rust" "work/ex/clippy-test-run/sources/stable/gh/segler-alex/radiobrowser-cleanup-tasks-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/segler-alex/radiobrowser-cleanup-tasks-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/segler-alex/radiobrowser-cleanup-tasks-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segler-alex/radiobrowser-cleanup-tasks-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segler-alex/radiobrowser-cleanup-tasks-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1296e88860c23967965af38721d6941794199f68 [INFO] sha for GitHub repo segler-alex/radiobrowser-cleanup-tasks-rust: 1296e88860c23967965af38721d6941794199f68 [INFO] validating manifest of segler-alex/radiobrowser-cleanup-tasks-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of segler-alex/radiobrowser-cleanup-tasks-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing segler-alex/radiobrowser-cleanup-tasks-rust [INFO] finished frobbing segler-alex/radiobrowser-cleanup-tasks-rust [INFO] frobbed toml for segler-alex/radiobrowser-cleanup-tasks-rust written to work/ex/clippy-test-run/sources/stable/gh/segler-alex/radiobrowser-cleanup-tasks-rust/Cargo.toml [INFO] started frobbing segler-alex/radiobrowser-cleanup-tasks-rust [INFO] finished frobbing segler-alex/radiobrowser-cleanup-tasks-rust [INFO] frobbed toml for segler-alex/radiobrowser-cleanup-tasks-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segler-alex/radiobrowser-cleanup-tasks-rust/Cargo.toml [INFO] crate segler-alex/radiobrowser-cleanup-tasks-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting segler-alex/radiobrowser-cleanup-tasks-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/segler-alex/radiobrowser-cleanup-tasks-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 820946bc233d8a463324abc60413aa3eb5aca6758d361c8d5ca7bcd86aa3212a [INFO] running `"docker" "start" "-a" "820946bc233d8a463324abc60413aa3eb5aca6758d361c8d5ca7bcd86aa3212a"` [INFO] [stderr] Checking unicode-normalization v0.1.6 [INFO] [stderr] Checking serde v1.0.45 [INFO] [stderr] Checking bit-vec v0.4.4 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking atoi v0.2.3 [INFO] [stderr] Checking nix v0.9.0 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking twox-hash v1.1.0 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] Checking mysql_common v0.5.0 [INFO] [stderr] Checking idna v0.1.4 [INFO] [stderr] Checking url v1.7.0 [INFO] [stderr] Checking mysql v12.3.1 [INFO] [stderr] Checking update-caches-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_result)] on by default [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | .unwrap_or(String::from("")).to_lowercase(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | .unwrap_or(Ok(String::from(""))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok(String::from("")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:60:19 [INFO] [stderr] | [INFO] [stderr] 60 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | .unwrap_or(String::from("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:64:18 [INFO] [stderr] | [INFO] [stderr] 64 | .unwrap_or(Ok(String::from(""))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok(String::from("")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:98:11 [INFO] [stderr] | [INFO] [stderr] 98 | name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:120:11 [INFO] [stderr] | [INFO] [stderr] 120 | name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:141:11 [INFO] [stderr] | [INFO] [stderr] 141 | name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:157:10 [INFO] [stderr] | [INFO] [stderr] 157 | .unwrap_or(String::from("10")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("10"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:161:10 [INFO] [stderr] | [INFO] [stderr] 161 | .unwrap_or(String::from("false")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("false"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `update-caches-rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_result)] on by default [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | .unwrap_or(String::from("")).to_lowercase(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | .unwrap_or(Ok(String::from(""))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok(String::from("")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: for loop over `results`, which is a `Result`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:60:19 [INFO] [stderr] | [INFO] [stderr] 60 | for result in results { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider replacing `for result in results` with `if let Ok(result) = results` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_result [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | .unwrap_or(String::from("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:64:18 [INFO] [stderr] | [INFO] [stderr] 64 | .unwrap_or(Ok(String::from(""))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ok(String::from("")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:98:11 [INFO] [stderr] | [INFO] [stderr] 98 | name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:120:11 [INFO] [stderr] | [INFO] [stderr] 120 | name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:141:11 [INFO] [stderr] | [INFO] [stderr] 141 | name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:157:10 [INFO] [stderr] | [INFO] [stderr] 157 | .unwrap_or(String::from("10")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("10"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:161:10 [INFO] [stderr] | [INFO] [stderr] 161 | .unwrap_or(String::from("false")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("false"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `update-caches-rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "820946bc233d8a463324abc60413aa3eb5aca6758d361c8d5ca7bcd86aa3212a"` [INFO] running `"docker" "rm" "-f" "820946bc233d8a463324abc60413aa3eb5aca6758d361c8d5ca7bcd86aa3212a"` [INFO] [stdout] 820946bc233d8a463324abc60413aa3eb5aca6758d361c8d5ca7bcd86aa3212a