[INFO] updating cached repository segfo/rust_ssh [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/segfo/rust_ssh [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/segfo/rust_ssh" "work/ex/clippy-test-run/sources/stable/gh/segfo/rust_ssh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/segfo/rust_ssh'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/segfo/rust_ssh" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segfo/rust_ssh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segfo/rust_ssh'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9bc240574079e9f80917dcdb3d0978d458f2de87 [INFO] sha for GitHub repo segfo/rust_ssh: 9bc240574079e9f80917dcdb3d0978d458f2de87 [INFO] validating manifest of segfo/rust_ssh on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of segfo/rust_ssh on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing segfo/rust_ssh [INFO] finished frobbing segfo/rust_ssh [INFO] frobbed toml for segfo/rust_ssh written to work/ex/clippy-test-run/sources/stable/gh/segfo/rust_ssh/Cargo.toml [INFO] started frobbing segfo/rust_ssh [INFO] finished frobbing segfo/rust_ssh [INFO] frobbed toml for segfo/rust_ssh written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segfo/rust_ssh/Cargo.toml [INFO] crate segfo/rust_ssh has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting segfo/rust_ssh against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/segfo/rust_ssh:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c70f352977be252dce2956bc785d59a3935f3e92fa1d78c48d514fcd1e7c4dd3 [INFO] running `"docker" "start" "-a" "c70f352977be252dce2956bc785d59a3935f3e92fa1d78c48d514fcd1e7c4dd3"` [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Checking libz-sys v1.0.18 [INFO] [stderr] Checking ssh2 v0.3.2 [INFO] [stderr] Checking ssh_test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | port:port, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ssh.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | port:port, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> src/ssh.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ssh.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | ssh [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ssh.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let ssh=SSH2{ [INFO] [stderr] | _________________^ [INFO] [stderr] 33 | | socket:None, [INFO] [stderr] 34 | | session:None, [INFO] [stderr] 35 | | host:host.to_owned(), [INFO] [stderr] 36 | | port:port, [INFO] [stderr] 37 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ssh.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | let mut channel = self.session.as_ref().unwrap().channel_session()?; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SSH_CONNECT_INFO` [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | struct SSH_CONNECT_INFO{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/ssh.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | sess.userauth_password(user,pass); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> src/ssh.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ssh.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | ssh [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ssh.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let ssh=SSH2{ [INFO] [stderr] | _________________^ [INFO] [stderr] 33 | | socket:None, [INFO] [stderr] 34 | | session:None, [INFO] [stderr] 35 | | host:host.to_owned(), [INFO] [stderr] 36 | | port:port, [INFO] [stderr] 37 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ssh.rs:67:26 [INFO] [stderr] | [INFO] [stderr] 67 | .ok_or(::std::io::Error::new( [INFO] [stderr] | __________________________^ [INFO] [stderr] 68 | | ::std::io::ErrorKind::ConnectionAborted, [INFO] [stderr] 69 | | "session-object not generated."))?; [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 67 | .ok_or_else(|| ::std::io::Error::new( [INFO] [stderr] 68 | ::std::io::ErrorKind::ConnectionAborted, [INFO] [stderr] 69 | "session-object not generated."))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: type `SSH_CONNECT_INFO` should have a camel case name such as `SshConnectInfo` [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / struct SSH_CONNECT_INFO{ [INFO] [stderr] 6 | | host:String, [INFO] [stderr] 7 | | port:u16, [INFO] [stderr] 8 | | user:String, [INFO] [stderr] 9 | | pass:Option, [INFO] [stderr] 10 | | agent_auth:bool [INFO] [stderr] 11 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ssh.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | let mut channel = self.session.as_ref().unwrap().channel_session()?; [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SSH_CONNECT_INFO` [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | struct SSH_CONNECT_INFO{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/ssh.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | sess.userauth_password(user,pass); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ssh.rs:67:26 [INFO] [stderr] | [INFO] [stderr] 67 | .ok_or(::std::io::Error::new( [INFO] [stderr] | __________________________^ [INFO] [stderr] 68 | | ::std::io::ErrorKind::ConnectionAborted, [INFO] [stderr] 69 | | "session-object not generated."))?; [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 67 | .ok_or_else(|| ::std::io::Error::new( [INFO] [stderr] 68 | ::std::io::ErrorKind::ConnectionAborted, [INFO] [stderr] 69 | "session-object not generated."))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: type `SSH_CONNECT_INFO` should have a camel case name such as `SshConnectInfo` [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / struct SSH_CONNECT_INFO{ [INFO] [stderr] 6 | | host:String, [INFO] [stderr] 7 | | port:u16, [INFO] [stderr] 8 | | user:String, [INFO] [stderr] 9 | | pass:Option, [INFO] [stderr] 10 | | agent_auth:bool [INFO] [stderr] 11 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.18s [INFO] running `"docker" "inspect" "c70f352977be252dce2956bc785d59a3935f3e92fa1d78c48d514fcd1e7c4dd3"` [INFO] running `"docker" "rm" "-f" "c70f352977be252dce2956bc785d59a3935f3e92fa1d78c48d514fcd1e7c4dd3"` [INFO] [stdout] c70f352977be252dce2956bc785d59a3935f3e92fa1d78c48d514fcd1e7c4dd3