[INFO] updating cached repository segfo/qrcode [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/segfo/qrcode [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/segfo/qrcode" "work/ex/clippy-test-run/sources/stable/gh/segfo/qrcode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/segfo/qrcode'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/segfo/qrcode" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segfo/qrcode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segfo/qrcode'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ffb9a41e9c31e5a97bb0b329e57758914e79b68f [INFO] sha for GitHub repo segfo/qrcode: ffb9a41e9c31e5a97bb0b329e57758914e79b68f [INFO] validating manifest of segfo/qrcode on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of segfo/qrcode on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing segfo/qrcode [INFO] finished frobbing segfo/qrcode [INFO] frobbed toml for segfo/qrcode written to work/ex/clippy-test-run/sources/stable/gh/segfo/qrcode/Cargo.toml [INFO] started frobbing segfo/qrcode [INFO] finished frobbing segfo/qrcode [INFO] frobbed toml for segfo/qrcode written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segfo/qrcode/Cargo.toml [INFO] crate segfo/qrcode has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting segfo/qrcode against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/segfo/qrcode:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] abd40eff83c4b02cf5080713cade34963f7c434307e67e7c4cd3ae5d1d0e10f0 [INFO] running `"docker" "start" "-a" "abd40eff83c4b02cf5080713cade34963f7c434307e67e7c4cd3ae5d1d0e10f0"` [INFO] [stderr] Checking qrcodegen v1.4.0 [INFO] [stderr] Checking qrcode v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_type.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | v:v, [INFO] [stderr] | ^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_type.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | v:v, [INFO] [stderr] | ^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data_type.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return &mut self.v; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/data_type.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::*` [INFO] [stderr] --> src/data_type.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | use std::io::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/data_type.rs:131:1 [INFO] [stderr] | [INFO] [stderr] 131 | / macro_rules! input { [INFO] [stderr] 132 | | (source = $s:expr, $($r:tt)*) => { [INFO] [stderr] 133 | | let mut iter = $s.split_whitespace(); [INFO] [stderr] 134 | | let mut next = || { iter.next().unwrap() }; [INFO] [stderr] ... | [INFO] [stderr] 149 | | }; [INFO] [stderr] 150 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/data_type.rs:152:1 [INFO] [stderr] | [INFO] [stderr] 152 | / macro_rules! input_inner { [INFO] [stderr] 153 | | ($next:expr) => {}; [INFO] [stderr] 154 | | ($next:expr, ) => {}; [INFO] [stderr] 155 | | [INFO] [stderr] ... | [INFO] [stderr] 159 | | }; [INFO] [stderr] 160 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/data_type.rs:162:1 [INFO] [stderr] | [INFO] [stderr] 162 | / macro_rules! read_value { [INFO] [stderr] 163 | | ($next:expr, ( $($t:tt),* )) => { [INFO] [stderr] 164 | | ( $(read_value!($next, $t)),* ) [INFO] [stderr] 165 | | }; [INFO] [stderr] ... | [INFO] [stderr] 181 | | }; [INFO] [stderr] 182 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `data_type` [INFO] [stderr] --> src/test.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use data_type; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `data_type::*` [INFO] [stderr] --> src/test.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use data_type::*; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data_type.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return &mut self.v; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/data_type.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::*` [INFO] [stderr] --> src/data_type.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | use std::io::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/data_type.rs:131:1 [INFO] [stderr] | [INFO] [stderr] 131 | / macro_rules! input { [INFO] [stderr] 132 | | (source = $s:expr, $($r:tt)*) => { [INFO] [stderr] 133 | | let mut iter = $s.split_whitespace(); [INFO] [stderr] 134 | | let mut next = || { iter.next().unwrap() }; [INFO] [stderr] ... | [INFO] [stderr] 149 | | }; [INFO] [stderr] 150 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/data_type.rs:152:1 [INFO] [stderr] | [INFO] [stderr] 152 | / macro_rules! input_inner { [INFO] [stderr] 153 | | ($next:expr) => {}; [INFO] [stderr] 154 | | ($next:expr, ) => {}; [INFO] [stderr] 155 | | [INFO] [stderr] ... | [INFO] [stderr] 159 | | }; [INFO] [stderr] 160 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/data_type.rs:162:1 [INFO] [stderr] | [INFO] [stderr] 162 | / macro_rules! read_value { [INFO] [stderr] 163 | | ($next:expr, ( $($t:tt),* )) => { [INFO] [stderr] 164 | | ( $(read_value!($next, $t)),* ) [INFO] [stderr] 165 | | }; [INFO] [stderr] ... | [INFO] [stderr] 181 | | }; [INFO] [stderr] 182 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/data_type.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | if c.is_ascii_hexdigit()==false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!c.is_ascii_hexdigit()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/main.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | input_filename.as_bytes().iter().cloned().collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/data_type.rs:82:16 [INFO] [stderr] | [INFO] [stderr] 82 | if c.is_ascii_hexdigit()==false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!c.is_ascii_hexdigit()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/main.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | input_filename.as_bytes().iter().cloned().collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.90s [INFO] running `"docker" "inspect" "abd40eff83c4b02cf5080713cade34963f7c434307e67e7c4cd3ae5d1d0e10f0"` [INFO] running `"docker" "rm" "-f" "abd40eff83c4b02cf5080713cade34963f7c434307e67e7c4cd3ae5d1d0e10f0"` [INFO] [stdout] abd40eff83c4b02cf5080713cade34963f7c434307e67e7c4cd3ae5d1d0e10f0