[INFO] updating cached repository sector-f/diskdestroyer
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/sector-f/diskdestroyer
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/sector-f/diskdestroyer" "work/ex/clippy-test-run/sources/stable/gh/sector-f/diskdestroyer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sector-f/diskdestroyer'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/sector-f/diskdestroyer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sector-f/diskdestroyer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sector-f/diskdestroyer'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] edbbf115dd81a133d20d8ee357cf8a6ee9f3697a
[INFO] sha for GitHub repo sector-f/diskdestroyer: edbbf115dd81a133d20d8ee357cf8a6ee9f3697a
[INFO] validating manifest of sector-f/diskdestroyer on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sector-f/diskdestroyer on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sector-f/diskdestroyer
[INFO] finished frobbing sector-f/diskdestroyer
[INFO] frobbed toml for sector-f/diskdestroyer written to work/ex/clippy-test-run/sources/stable/gh/sector-f/diskdestroyer/Cargo.toml
[INFO] started frobbing sector-f/diskdestroyer
[INFO] finished frobbing sector-f/diskdestroyer
[INFO] frobbed toml for sector-f/diskdestroyer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sector-f/diskdestroyer/Cargo.toml
[INFO] crate sector-f/diskdestroyer has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sector-f/diskdestroyer against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sector-f/diskdestroyer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cfd4509928695babfd539f78d2d0314aa5d036a1b9deedbf0f5b2371f206a32c
[INFO] running `"docker" "start" "-a" "cfd4509928695babfd539f78d2d0314aa5d036a1b9deedbf0f5b2371f206a32c"`
[INFO] [stderr]     Checking clicolors-control v0.2.0
[INFO] [stderr]     Checking parking_lot_core v0.2.13
[INFO] [stderr]     Checking parking_lot v0.5.4
[INFO] [stderr]     Checking console v0.6.1
[INFO] [stderr]     Checking indicatif v0.9.0
[INFO] [stderr]     Checking diskdestroyer v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             data_type: data_type,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             data_type: data_type,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:92:20
[INFO] [stderr]    |
[INFO] [stderr] 92 |       let datatype = match matches.is_present("zero") {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 93 | |         false => DataType::Random,
[INFO] [stderr] 94 | |         true => DataType::Zeroes,
[INFO] [stderr] 95 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if matches.is_present("zero") { DataType::Zeroes } else { DataType::Random }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:102:74
[INFO] [stderr]     |
[INFO] [stderr] 102 |     let paths: Vec<PathBuf> = matches.values_of_os("files").unwrap().map(|f| PathBuf::from(f)).collect();
[INFO] [stderr]     |                                                                          ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:92:20
[INFO] [stderr]    |
[INFO] [stderr] 92 |       let datatype = match matches.is_present("zero") {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 93 | |         false => DataType::Random,
[INFO] [stderr] 94 | |         true => DataType::Zeroes,
[INFO] [stderr] 95 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if matches.is_present("zero") { DataType::Zeroes } else { DataType::Random }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:102:74
[INFO] [stderr]     |
[INFO] [stderr] 102 |     let paths: Vec<PathBuf> = matches.values_of_os("files").unwrap().map(|f| PathBuf::from(f)).collect();
[INFO] [stderr]     |                                                                          ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.32s
[INFO] running `"docker" "inspect" "cfd4509928695babfd539f78d2d0314aa5d036a1b9deedbf0f5b2371f206a32c"`
[INFO] running `"docker" "rm" "-f" "cfd4509928695babfd539f78d2d0314aa5d036a1b9deedbf0f5b2371f206a32c"`
[INFO] [stdout] cfd4509928695babfd539f78d2d0314aa5d036a1b9deedbf0f5b2371f206a32c