[INFO] updating cached repository sebglazebrook/ping-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sebglazebrook/ping-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sebglazebrook/ping-rs" "work/ex/clippy-test-run/sources/stable/gh/sebglazebrook/ping-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sebglazebrook/ping-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sebglazebrook/ping-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebglazebrook/ping-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebglazebrook/ping-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b4208ffff37cdfcdf8671ef369f10e4d498c79b8 [INFO] sha for GitHub repo sebglazebrook/ping-rs: b4208ffff37cdfcdf8671ef369f10e4d498c79b8 [INFO] validating manifest of sebglazebrook/ping-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sebglazebrook/ping-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sebglazebrook/ping-rs [INFO] finished frobbing sebglazebrook/ping-rs [INFO] frobbed toml for sebglazebrook/ping-rs written to work/ex/clippy-test-run/sources/stable/gh/sebglazebrook/ping-rs/Cargo.toml [INFO] started frobbing sebglazebrook/ping-rs [INFO] finished frobbing sebglazebrook/ping-rs [INFO] frobbed toml for sebglazebrook/ping-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebglazebrook/ping-rs/Cargo.toml [INFO] crate sebglazebrook/ping-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sebglazebrook/ping-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sebglazebrook/ping-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 47e69b606a8384d08e547afb0d8a1fc1bb7490ac9a00e2964fbe52b0010b6b60 [INFO] running `"docker" "start" "-a" "47e69b606a8384d08e547afb0d8a1fc1bb7490ac9a00e2964fbe52b0010b6b60"` [INFO] [stderr] Compiling term v0.4.6 [INFO] [stderr] Compiling unicode-xid v0.0.3 [INFO] [stderr] Compiling bitflags v0.5.0 [INFO] [stderr] Compiling regex-syntax v0.4.2 [INFO] [stderr] Checking pnet_base v0.20.0 [INFO] [stderr] Checking ipnetwork v0.12.7 [INFO] [stderr] Compiling pnet v0.20.0 [INFO] [stderr] Compiling syntex_pos v0.42.0 [INFO] [stderr] Compiling memchr v2.0.1 [INFO] [stderr] Checking pnet_sys v0.20.0 [INFO] [stderr] Compiling thread_local v0.3.5 [INFO] [stderr] Checking pnet_macros_support v0.20.0 [INFO] [stderr] Checking pnet_datalink v0.20.0 [INFO] [stderr] Compiling aho-corasick v0.6.4 [INFO] [stderr] Compiling syntex_errors v0.42.0 [INFO] [stderr] Compiling syntex_syntax v0.42.0 [INFO] [stderr] Compiling regex v0.2.6 [INFO] [stderr] Compiling syntex v0.42.2 [INFO] [stderr] Compiling pnet_macros v0.20.0 [INFO] [stderr] Compiling pnet_packet v0.20.0 [INFO] [stderr] Checking pnet_transport v0.20.0 [INFO] [stderr] Checking ping-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ping/network_layer.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | interface: interface, // TODO this should be able to be dynamic [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interface` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ping/network_layer.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | interface: interface, // TODO this should be able to be dynamic [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interface` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ping/network_layer.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | let (mut tx, mut rx) = match datalink::channel(&interface, datalink::Config::default()) { [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ping/network_layer.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | let (mut tx, mut rx) = match datalink::channel(&interface, datalink::Config::default()) { [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `interface` [INFO] [stderr] --> src/ping/network_layer.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | interface: datalink::NetworkInterface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `receiver` [INFO] [stderr] --> src/ping/network_layer.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | receiver: Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/ping/ping_packet.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn into_bytes(&self) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/ping/ip_datagram.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn into_bytes(&self) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/ping/ip_header.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | version: 0x0800, // TODO correct value ?? [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(overflowing_literals)] on by default [INFO] [stderr] = note: the literal `0x0800` (decimal `2048`) does not fit into an `u8` and will become `0u8` [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/ping/ip_header.rs:47:23 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn into_bytes(&self) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/ping/ip_header.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | header_checksum.write_u16::(self.header_checksum); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/ping/icmp_packet.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn into_bytes(&self) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ping/network_layer.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | let (mut tx, mut rx) = match datalink::channel(&interface, datalink::Config::default()) { [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/ping/network_layer.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | let (mut tx, mut rx) = match datalink::channel(&interface, datalink::Config::default()) { [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `interface` [INFO] [stderr] --> src/ping/network_layer.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | interface: datalink::NetworkInterface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `receiver` [INFO] [stderr] --> src/ping/network_layer.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | receiver: Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/ping/ping_packet.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn into_bytes(&self) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/ping/ip_datagram.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn into_bytes(&self) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: literal out of range for u8 [INFO] [stderr] --> src/ping/ip_header.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | version: 0x0800, // TODO correct value ?? [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(overflowing_literals)] on by default [INFO] [stderr] = note: the literal `0x0800` (decimal `2048`) does not fit into an `u8` and will become `0u8` [INFO] [stderr] = help: consider using `u16` instead [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/ping/ip_header.rs:47:23 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn into_bytes(&self) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/ping/ip_header.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | header_checksum.write_u16::(self.header_checksum); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/ping/icmp_packet.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn into_bytes(&self) -> Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 59.36s [INFO] running `"docker" "inspect" "47e69b606a8384d08e547afb0d8a1fc1bb7490ac9a00e2964fbe52b0010b6b60"` [INFO] running `"docker" "rm" "-f" "47e69b606a8384d08e547afb0d8a1fc1bb7490ac9a00e2964fbe52b0010b6b60"` [INFO] [stdout] 47e69b606a8384d08e547afb0d8a1fc1bb7490ac9a00e2964fbe52b0010b6b60