[INFO] updating cached repository sebastianseitz/adventofcode [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sebastianseitz/adventofcode [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sebastianseitz/adventofcode" "work/ex/clippy-test-run/sources/stable/gh/sebastianseitz/adventofcode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sebastianseitz/adventofcode'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sebastianseitz/adventofcode" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebastianseitz/adventofcode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebastianseitz/adventofcode'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b7ccd86d7a5151d9f7e2c80bc4d4d6f9bf12f0c1 [INFO] sha for GitHub repo sebastianseitz/adventofcode: b7ccd86d7a5151d9f7e2c80bc4d4d6f9bf12f0c1 [INFO] validating manifest of sebastianseitz/adventofcode on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sebastianseitz/adventofcode on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sebastianseitz/adventofcode [INFO] finished frobbing sebastianseitz/adventofcode [INFO] frobbed toml for sebastianseitz/adventofcode written to work/ex/clippy-test-run/sources/stable/gh/sebastianseitz/adventofcode/Cargo.toml [INFO] started frobbing sebastianseitz/adventofcode [INFO] finished frobbing sebastianseitz/adventofcode [INFO] frobbed toml for sebastianseitz/adventofcode written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebastianseitz/adventofcode/Cargo.toml [INFO] crate sebastianseitz/adventofcode has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sebastianseitz/adventofcode against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sebastianseitz/adventofcode:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 742c01f0f2162f6e9acbb1225ca59fe363cebb57bc923b07483f946382e0cbc9 [INFO] running `"docker" "start" "-a" "742c01f0f2162f6e9acbb1225ca59fe363cebb57bc923b07483f946382e0cbc9"` [INFO] [stderr] Checking adventofcode v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day5.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return counter; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day5.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return counter; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/day6.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 59 | | if lookup.contains(&real) { [INFO] [stderr] 60 | | println!("First cycles: {}", counter); [INFO] [stderr] 61 | | seen = true; [INFO] [stderr] ... | [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | } else if lookup.contains(&real) { [INFO] [stderr] 59 | println!("First cycles: {}", counter); [INFO] [stderr] 60 | seen = true; [INFO] [stderr] 61 | counter = 0; [INFO] [stderr] 62 | search = real.clone(); [INFO] [stderr] 63 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day4.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return counter; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day4.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return counter; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return result.unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return sum [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return sum [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day5.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return counter; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day5.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return counter; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day1.rs:2:22 [INFO] [stderr] | [INFO] [stderr] 2 | fn part_one(numbers: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is used to index `real` [INFO] [stderr] --> src/day6.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | for idx in 0..real.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for (idx, ) in real.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/day4.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | let cur_word = word.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 15 | let cur_word = &(*word).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 15 | let cur_word = &str::clone(word); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `adventofcode`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day1.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | fn part_two(numbers: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day4.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return counter; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day4.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return counter; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `counter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/day4.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | let cur_word = word.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 15 | let cur_word = &(*word).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 15 | let cur_word = &str::clone(word); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx_2` is only used to index `numbers`. [INFO] [stderr] --> src/day2.rs:56:26 [INFO] [stderr] | [INFO] [stderr] 56 | for idx_2 in idx+1..numbers.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 56 | for in numbers.iter().skip(idx+1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: Could not compile `adventofcode`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/day6.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 59 | | if lookup.contains(&real) { [INFO] [stderr] 60 | | println!("First cycles: {}", counter); [INFO] [stderr] 61 | | seen = true; [INFO] [stderr] ... | [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 58 | } else if lookup.contains(&real) { [INFO] [stderr] 59 | println!("First cycles: {}", counter); [INFO] [stderr] 60 | seen = true; [INFO] [stderr] 61 | counter = 0; [INFO] [stderr] 62 | search = real.clone(); [INFO] [stderr] 63 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is used to index `real` [INFO] [stderr] --> src/day6.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | for idx in 0..real.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for (idx, ) in real.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "742c01f0f2162f6e9acbb1225ca59fe363cebb57bc923b07483f946382e0cbc9"` [INFO] running `"docker" "rm" "-f" "742c01f0f2162f6e9acbb1225ca59fe363cebb57bc923b07483f946382e0cbc9"` [INFO] [stdout] 742c01f0f2162f6e9acbb1225ca59fe363cebb57bc923b07483f946382e0cbc9