[INFO] updating cached repository sebasmagri/rust-concurrency-patterns [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sebasmagri/rust-concurrency-patterns [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sebasmagri/rust-concurrency-patterns" "work/ex/clippy-test-run/sources/stable/gh/sebasmagri/rust-concurrency-patterns"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sebasmagri/rust-concurrency-patterns'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sebasmagri/rust-concurrency-patterns" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebasmagri/rust-concurrency-patterns"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebasmagri/rust-concurrency-patterns'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c916fe831faec73a7fb5d652e91fa9da528d85c4 [INFO] sha for GitHub repo sebasmagri/rust-concurrency-patterns: c916fe831faec73a7fb5d652e91fa9da528d85c4 [INFO] validating manifest of sebasmagri/rust-concurrency-patterns on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sebasmagri/rust-concurrency-patterns on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sebasmagri/rust-concurrency-patterns [INFO] finished frobbing sebasmagri/rust-concurrency-patterns [INFO] frobbed toml for sebasmagri/rust-concurrency-patterns written to work/ex/clippy-test-run/sources/stable/gh/sebasmagri/rust-concurrency-patterns/Cargo.toml [INFO] started frobbing sebasmagri/rust-concurrency-patterns [INFO] finished frobbing sebasmagri/rust-concurrency-patterns [INFO] frobbed toml for sebasmagri/rust-concurrency-patterns written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebasmagri/rust-concurrency-patterns/Cargo.toml [INFO] crate sebasmagri/rust-concurrency-patterns has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sebasmagri/rust-concurrency-patterns against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sebasmagri/rust-concurrency-patterns:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5d543117c0f903b033bd0305a52734f1503ffec605de48207d7e98263e435370 [INFO] running `"docker" "start" "-a" "5d543117c0f903b033bd0305a52734f1503ffec605de48207d7e98263e435370"` [INFO] [stderr] Checking concurrency-patterns v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> examples/05-workers.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | / if n != 0 { [INFO] [stderr] 38 | | if is_prime(n) { [INFO] [stderr] 39 | | println!("worker {} found a prime: {}", id, n); [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | if n != 0 && is_prime(n) { [INFO] [stderr] 38 | println!("worker {} found a prime: {}", id, n); [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> examples/04-fan-in.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | consumer(Arc::new(Mutex::new(rx))).join(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/05-workers.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / match shared_rx.lock() { [INFO] [stderr] 26 | | Ok(rx) => { [INFO] [stderr] 27 | | match rx.try_recv() { [INFO] [stderr] 28 | | Ok(_n) => { [INFO] [stderr] ... | [INFO] [stderr] 34 | | Err(_) => () [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | if let Ok(rx) = shared_rx.lock() { [INFO] [stderr] 26 | match rx.try_recv() { [INFO] [stderr] 27 | Ok(_n) => { [INFO] [stderr] 28 | n = _n; [INFO] [stderr] 29 | }, [INFO] [stderr] 30 | Err(_) => () [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/05-workers.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | / match rx.try_recv() { [INFO] [stderr] 28 | | Ok(_n) => { [INFO] [stderr] 29 | | n = _n; [INFO] [stderr] 30 | | }, [INFO] [stderr] 31 | | Err(_) => () [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | if let Ok(_n) = rx.try_recv() { [INFO] [stderr] 28 | n = _n; [INFO] [stderr] 29 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> examples/03-ping-pong.rs:26:28 [INFO] [stderr] | [INFO] [stderr] 26 | let ball = (*locked_table).recv().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> examples/03-ping-pong.rs:30:41 [INFO] [stderr] | [INFO] [stderr] 30 | let mut hit_count = ball.lock().unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> examples/03-ping-pong.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | racket.send(ball).unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> examples/03-ping-pong.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | racket.send(Mutex::new(0)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> examples/03-ping-pong.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | table_lock.recv().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.65s [INFO] running `"docker" "inspect" "5d543117c0f903b033bd0305a52734f1503ffec605de48207d7e98263e435370"` [INFO] running `"docker" "rm" "-f" "5d543117c0f903b033bd0305a52734f1503ffec605de48207d7e98263e435370"` [INFO] [stdout] 5d543117c0f903b033bd0305a52734f1503ffec605de48207d7e98263e435370