[INFO] updating cached repository sebasmagri/mopidy-ctl [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sebasmagri/mopidy-ctl [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sebasmagri/mopidy-ctl" "work/ex/clippy-test-run/sources/stable/gh/sebasmagri/mopidy-ctl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sebasmagri/mopidy-ctl'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sebasmagri/mopidy-ctl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebasmagri/mopidy-ctl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebasmagri/mopidy-ctl'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7c418acfbc84060c953b1e33f9236335085e097b [INFO] sha for GitHub repo sebasmagri/mopidy-ctl: 7c418acfbc84060c953b1e33f9236335085e097b [INFO] validating manifest of sebasmagri/mopidy-ctl on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sebasmagri/mopidy-ctl on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sebasmagri/mopidy-ctl [INFO] finished frobbing sebasmagri/mopidy-ctl [INFO] frobbed toml for sebasmagri/mopidy-ctl written to work/ex/clippy-test-run/sources/stable/gh/sebasmagri/mopidy-ctl/Cargo.toml [INFO] started frobbing sebasmagri/mopidy-ctl [INFO] finished frobbing sebasmagri/mopidy-ctl [INFO] frobbed toml for sebasmagri/mopidy-ctl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebasmagri/mopidy-ctl/Cargo.toml [INFO] crate sebasmagri/mopidy-ctl has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sebasmagri/mopidy-ctl against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sebasmagri/mopidy-ctl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 03183542772ccbf51b1f1fc80ca518fceaf6685270ac1ade4801413e7762bf80 [INFO] running `"docker" "start" "-a" "03183542772ccbf51b1f1fc80ca518fceaf6685270ac1ade4801413e7762bf80"` [INFO] [stderr] Compiling error-chain v0.7.2 [INFO] [stderr] Compiling gio v0.1.2 [INFO] [stderr] Compiling gdk-pixbuf v0.1.2 [INFO] [stderr] Compiling cairo-rs v0.1.2 [INFO] [stderr] Checking c_vec v1.2.0 [INFO] [stderr] Compiling gdk v0.5.2 [INFO] [stderr] Compiling gtk v0.1.2 [INFO] [stderr] Compiling glib-sys v0.3.3 [INFO] [stderr] Compiling gobject-sys v0.3.3 [INFO] [stderr] Compiling gio-sys v0.3.3 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.3.3 [INFO] [stderr] Compiling cairo-sys-rs v0.3.3 [INFO] [stderr] Compiling pango-sys v0.3.3 [INFO] [stderr] Compiling gdk-sys v0.3.3 [INFO] [stderr] Compiling atk-sys v0.3.3 [INFO] [stderr] Compiling gtk-sys v0.3.3 [INFO] [stderr] Compiling dbus v0.4.1 [INFO] [stderr] Compiling metadeps v1.1.1 [INFO] [stderr] Compiling dbus v0.5.2 [INFO] [stderr] warning: redundant linker flag specified for library `dbus-1` [INFO] [stderr] [INFO] [stderr] Checking notify-rust v3.2.1 [INFO] [stderr] Checking glib v0.1.2 [INFO] [stderr] warning: redundant linker flag specified for library `dbus-1` [INFO] [stderr] [INFO] [stderr] Checking pango v0.1.2 [INFO] [stderr] Checking mpris-ctl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | const PREVIOUS: &'static str = "Previous"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | const PLAY_PAUSE: &'static str = "PlayPause"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | const STOP: &'static str = "Stop"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | const NEXT: &'static str = "Next"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | / match item { [INFO] [stderr] 75 | | ConnectionItem::Signal(ref msg) => { [INFO] [stderr] 76 | | println!("{:?}", msg); [INFO] [stderr] 77 | | println!("{:?}", msg.get_items()); [INFO] [stderr] ... | [INFO] [stderr] 80 | | _ => () [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 74 | if let ConnectionItem::Signal(ref msg) = item { [INFO] [stderr] 75 | println!("{:?}", msg); [INFO] [stderr] 76 | println!("{:?}", msg.get_items()); [INFO] [stderr] 77 | handle_properties_changed_message(msg); [INFO] [stderr] 78 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | const PREVIOUS: &'static str = "Previous"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | const PLAY_PAUSE: &'static str = "PlayPause"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | const STOP: &'static str = "Stop"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | const NEXT: &'static str = "Next"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | / match item { [INFO] [stderr] 75 | | ConnectionItem::Signal(ref msg) => { [INFO] [stderr] 76 | | println!("{:?}", msg); [INFO] [stderr] 77 | | println!("{:?}", msg.get_items()); [INFO] [stderr] ... | [INFO] [stderr] 80 | | _ => () [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 74 | if let ConnectionItem::Signal(ref msg) = item { [INFO] [stderr] 75 | println!("{:?}", msg); [INFO] [stderr] 76 | println!("{:?}", msg.get_items()); [INFO] [stderr] 77 | handle_properties_changed_message(msg); [INFO] [stderr] 78 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 50.00s [INFO] running `"docker" "inspect" "03183542772ccbf51b1f1fc80ca518fceaf6685270ac1ade4801413e7762bf80"` [INFO] running `"docker" "rm" "-f" "03183542772ccbf51b1f1fc80ca518fceaf6685270ac1ade4801413e7762bf80"` [INFO] [stdout] 03183542772ccbf51b1f1fc80ca518fceaf6685270ac1ade4801413e7762bf80