[INFO] updating cached repository seb-odessa/dataLock [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/seb-odessa/dataLock [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/seb-odessa/dataLock" "work/ex/clippy-test-run/sources/stable/gh/seb-odessa/dataLock"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/seb-odessa/dataLock'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/seb-odessa/dataLock" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seb-odessa/dataLock"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seb-odessa/dataLock'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] deed96235be5f3c4f6db2a5f432bd671f1a460db [INFO] sha for GitHub repo seb-odessa/dataLock: deed96235be5f3c4f6db2a5f432bd671f1a460db [INFO] validating manifest of seb-odessa/dataLock on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of seb-odessa/dataLock on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing seb-odessa/dataLock [INFO] finished frobbing seb-odessa/dataLock [INFO] frobbed toml for seb-odessa/dataLock written to work/ex/clippy-test-run/sources/stable/gh/seb-odessa/dataLock/Cargo.toml [INFO] started frobbing seb-odessa/dataLock [INFO] finished frobbing seb-odessa/dataLock [INFO] frobbed toml for seb-odessa/dataLock written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seb-odessa/dataLock/Cargo.toml [INFO] crate seb-odessa/dataLock has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting seb-odessa/dataLock against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/seb-odessa/dataLock:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 11f628cc7fe0edf96d82b0fc65ebada91feb1d965b0cf8ef6dad989001bd53a4 [INFO] running `"docker" "start" "-a" "11f628cc7fe0edf96d82b0fc65ebada91feb1d965b0cf8ef6dad989001bd53a4"` [INFO] [stderr] Checking data_lock v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return *counter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*counter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/main.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | thread::sleep_ms(timeout); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return *counter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*counter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/main.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | thread::sleep_ms(timeout); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | *counter = *counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | *counter = *counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.68s [INFO] running `"docker" "inspect" "11f628cc7fe0edf96d82b0fc65ebada91feb1d965b0cf8ef6dad989001bd53a4"` [INFO] running `"docker" "rm" "-f" "11f628cc7fe0edf96d82b0fc65ebada91feb1d965b0cf8ef6dad989001bd53a4"` [INFO] [stdout] 11f628cc7fe0edf96d82b0fc65ebada91feb1d965b0cf8ef6dad989001bd53a4