[INFO] updating cached repository seanmheff/ascii-pixels [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/seanmheff/ascii-pixels [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/seanmheff/ascii-pixels" "work/ex/clippy-test-run/sources/stable/gh/seanmheff/ascii-pixels"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/seanmheff/ascii-pixels'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/seanmheff/ascii-pixels" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seanmheff/ascii-pixels"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seanmheff/ascii-pixels'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a8e7056ba40596e2f6e60f0772e0fabcc3f63381 [INFO] sha for GitHub repo seanmheff/ascii-pixels: a8e7056ba40596e2f6e60f0772e0fabcc3f63381 [INFO] validating manifest of seanmheff/ascii-pixels on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of seanmheff/ascii-pixels on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing seanmheff/ascii-pixels [INFO] finished frobbing seanmheff/ascii-pixels [INFO] frobbed toml for seanmheff/ascii-pixels written to work/ex/clippy-test-run/sources/stable/gh/seanmheff/ascii-pixels/Cargo.toml [INFO] started frobbing seanmheff/ascii-pixels [INFO] finished frobbing seanmheff/ascii-pixels [INFO] frobbed toml for seanmheff/ascii-pixels written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seanmheff/ascii-pixels/Cargo.toml [INFO] crate seanmheff/ascii-pixels has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting seanmheff/ascii-pixels against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/seanmheff/ascii-pixels:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aa8bde074d31c2600fdf0be9b1299ef2e8d11b92a21ac32bcf1928067f1cbf2b [INFO] running `"docker" "start" "-a" "aa8bde074d31c2600fdf0be9b1299ef2e8d11b92a21ac32bcf1928067f1cbf2b"` [INFO] [stderr] Checking libc v0.2.19 [INFO] [stderr] Checking adler32 v0.3.0 [INFO] [stderr] Checking gif v0.9.0 [INFO] [stderr] Checking deflate v0.7.2 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking num_cpus v1.2.1 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking jpeg-decoder v0.1.11 [INFO] [stderr] Checking image v0.12.0 [INFO] [stderr] Checking ascii_pixels v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | positions[i] = positions[i] - positions[i-1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `positions[i] -= positions[i-1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `positions`. [INFO] [stderr] --> src/main.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..positions.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 32 | for in &positions { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | positions[i] = positions[i] - positions[i-1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `positions[i] -= positions[i-1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `positions`. [INFO] [stderr] --> src/main.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..positions.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 32 | for in &positions { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.59s [INFO] running `"docker" "inspect" "aa8bde074d31c2600fdf0be9b1299ef2e8d11b92a21ac32bcf1928067f1cbf2b"` [INFO] running `"docker" "rm" "-f" "aa8bde074d31c2600fdf0be9b1299ef2e8d11b92a21ac32bcf1928067f1cbf2b"` [INFO] [stdout] aa8bde074d31c2600fdf0be9b1299ef2e8d11b92a21ac32bcf1928067f1cbf2b