[INFO] updating cached repository seanlth/sulfide
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/seanlth/sulfide
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/seanlth/sulfide" "work/ex/clippy-test-run/sources/stable/gh/seanlth/sulfide"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/seanlth/sulfide'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/seanlth/sulfide" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seanlth/sulfide"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seanlth/sulfide'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a63ca8894e2734a2d86251e2c9126089898b04b4
[INFO] sha for GitHub repo seanlth/sulfide: a63ca8894e2734a2d86251e2c9126089898b04b4
[INFO] validating manifest of seanlth/sulfide on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of seanlth/sulfide on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing seanlth/sulfide
[INFO] finished frobbing seanlth/sulfide
[INFO] frobbed toml for seanlth/sulfide written to work/ex/clippy-test-run/sources/stable/gh/seanlth/sulfide/Cargo.toml
[INFO] started frobbing seanlth/sulfide
[INFO] finished frobbing seanlth/sulfide
[INFO] frobbed toml for seanlth/sulfide written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seanlth/sulfide/Cargo.toml
[INFO] crate seanlth/sulfide has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting seanlth/sulfide against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/seanlth/sulfide:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f364f19e07974fb98fd443884c1c9b569b8da6ed53ee4a18f1d258000b9ab0ce
[INFO] running `"docker" "start" "-a" "f364f19e07974fb98fd443884c1c9b569b8da6ed53ee4a18f1d258000b9ab0ce"`
[INFO] [stderr]     Checking sulfide v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/geometry.rs:112:13
[INFO] [stderr]     |
[INFO] [stderr] 112 |             x: x,
[INFO] [stderr]     |             ^^^^ help: replace it with: `x`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/geometry.rs:113:13
[INFO] [stderr]     |
[INFO] [stderr] 113 |             y: y
[INFO] [stderr]     |             ^^^^ help: replace it with: `y`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/geometry.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             width: width,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/geometry.rs:130:13
[INFO] [stderr]     |
[INFO] [stderr] 130 |             height: height,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/geometry.rs:131:13
[INFO] [stderr]     |
[INFO] [stderr] 131 |             position: position
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `position`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/geometry.rs:112:13
[INFO] [stderr]     |
[INFO] [stderr] 112 |             x: x,
[INFO] [stderr]     |             ^^^^ help: replace it with: `x`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/geometry.rs:113:13
[INFO] [stderr]     |
[INFO] [stderr] 113 |             y: y
[INFO] [stderr]     |             ^^^^ help: replace it with: `y`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/geometry.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             width: width,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/geometry.rs:130:13
[INFO] [stderr]     |
[INFO] [stderr] 130 |             height: height,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/geometry.rs:131:13
[INFO] [stderr]     |
[INFO] [stderr] 131 |             position: position
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `position`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::ops::Mul`
[INFO] [stderr]  --> src/geometry.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::ops::Mul;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::ops::Neg`
[INFO] [stderr]  --> src/geometry.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 | use std::ops::Neg;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `geometry::Rect`
[INFO] [stderr]  --> src/document.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use geometry::Rect;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/container.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     return id;
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/text.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     return id;
[INFO] [stderr]   |     ^^^^^^^^^^ help: remove `return` as shown: `id`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/list.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     return id;
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::ops::Mul`
[INFO] [stderr]  --> src/geometry.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::ops::Mul;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::ops::Neg`
[INFO] [stderr]  --> src/geometry.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 | use std::ops::Neg;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `geometry::Rect`
[INFO] [stderr]  --> src/document.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use geometry::Rect;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/container.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     return id;
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/text.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     return id;
[INFO] [stderr]   |     ^^^^^^^^^^ help: remove `return` as shown: `id`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/list.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     return id;
[INFO] [stderr]    |     ^^^^^^^^^^ help: remove `return` as shown: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `c`
[INFO] [stderr]   --> src/list.rs:51:21
[INFO] [stderr]    |
[INFO] [stderr] 51 |             let (h, c) = i.generate( format!("{}    ", indent) );
[INFO] [stderr]    |                     ^ help: consider using `_c` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: enum is never used: `Origin`
[INFO] [stderr]   --> src/container.rs:21:1
[INFO] [stderr]    |
[INFO] [stderr] 21 | enum Origin {
[INFO] [stderr]    | ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/geometry.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 | /         match self {
[INFO] [stderr] 21 | |             &Unit::Default => format!(""),
[INFO] [stderr] 22 | |             &Unit::Percent(v) => format!("{}%", v),
[INFO] [stderr] 23 | |             &Unit::Pixel(v) => format!("{}px", v),
[INFO] [stderr] 24 | |             &Unit::Calc(ref v) => format!("calc({})", v)
[INFO] [stderr] 25 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 20 |         match *self {
[INFO] [stderr] 21 |             Unit::Default => format!(""),
[INFO] [stderr] 22 |             Unit::Percent(v) => format!("{}%", v),
[INFO] [stderr] 23 |             Unit::Pixel(v) => format!("{}px", v),
[INFO] [stderr] 24 |             Unit::Calc(ref v) => format!("calc({})", v)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/geometry.rs:21:31
[INFO] [stderr]    |
[INFO] [stderr] 21 |             &Unit::Default => format!(""),
[INFO] [stderr]    |                               ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `document::Document`
[INFO] [stderr]   --> src/document.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     pub fn new() -> Document {
[INFO] [stderr] 13 | |         Document {
[INFO] [stderr] 14 | |             root: None
[INFO] [stderr] 15 | |         }
[INFO] [stderr] 16 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 7  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/document.rs:28:22
[INFO] [stderr]    |
[INFO] [stderr] 28 |           let (h, c) = match &self.root {
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 29 | |             &Some(ref r) => r.generate("        ".to_string()),
[INFO] [stderr] 30 | |             &None => ("".to_string(), "".to_string())
[INFO] [stderr] 31 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let (h, c) = match self.root {
[INFO] [stderr] 29 |             Some(ref r) => r.generate("        ".to_string()),
[INFO] [stderr] 30 |             None => ("".to_string(), "".to_string())
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: static variable `id_counter` should have an upper case name such as `ID_COUNTER`
[INFO] [stderr]   --> src/container.rs:28:1
[INFO] [stderr]    |
[INFO] [stderr] 28 | static mut id_counter: usize = 0;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_upper_case_globals)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/container.rs:89:9
[INFO] [stderr]    |
[INFO] [stderr] 89 | /         match self.scrolling {
[INFO] [stderr] 90 | |             true => css.push_str("    overflow: scroll;\n"),
[INFO] [stderr] 91 | |             false => css.push_str("    overflow: hidden;\n"),
[INFO] [stderr] 92 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if self.scrolling { css.push_str("    overflow: scroll;\n") } else { css.push_str("    overflow: hidden;\n") }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/container.rs:101:12
[INFO] [stderr]     |
[INFO] [stderr] 101 |         if self.left == true {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.left`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: static variable `id_counter` should have an upper case name such as `ID_COUNTER`
[INFO] [stderr]  --> src/text.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | static mut id_counter: usize = 0;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/text.rs:49:33
[INFO] [stderr]    |
[INFO] [stderr] 49 |           else if self.size != 12 {
[INFO] [stderr]    |  _________________________________^
[INFO] [stderr] 50 | |             true
[INFO] [stderr] 51 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/text.rs:46:40
[INFO] [stderr]    |
[INFO] [stderr] 46 |           if self.font != "".to_string() {
[INFO] [stderr]    |  ________________________________________^
[INFO] [stderr] 47 | |             true
[INFO] [stderr] 48 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/text.rs:46:25
[INFO] [stderr]    |
[INFO] [stderr] 46 |         if self.font != "".to_string() {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/text.rs:55:14
[INFO] [stderr]    |
[INFO] [stderr] 55 |           else if self.text_decoration != TextDecoration::Normal {
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 56 | |             true
[INFO] [stderr] 57 | |         }
[INFO] [stderr] 58 | |         else {
[INFO] [stderr] 59 | |             false
[INFO] [stderr] 60 | |         }
[INFO] [stderr]    | |_________^ help: you can reduce it to: `self.text_decoration != TextDecoration::Normal`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: static variable `id_counter` should have an upper case name such as `ID_COUNTER`
[INFO] [stderr]  --> src/list.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | static mut id_counter: usize = 0;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `list::List`
[INFO] [stderr]   --> src/list.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     pub fn new() -> List {
[INFO] [stderr] 28 | |         List {
[INFO] [stderr] 29 | |             items: vec![],
[INFO] [stderr] 30 | |             list_style: ListStyle::None,
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |         }
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 26 | impl Default for list::List {
[INFO] [stderr] 27 |     fn default() -> Self {
[INFO] [stderr] 28 |         Self::new()
[INFO] [stderr] 29 |     }
[INFO] [stderr] 30 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `sulfide`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unused variable: `c`
[INFO] [stderr]   --> src/list.rs:51:21
[INFO] [stderr]    |
[INFO] [stderr] 51 |             let (h, c) = i.generate( format!("{}    ", indent) );
[INFO] [stderr]    |                     ^ help: consider using `_c` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: enum is never used: `Origin`
[INFO] [stderr]   --> src/container.rs:21:1
[INFO] [stderr]    |
[INFO] [stderr] 21 | enum Origin {
[INFO] [stderr]    | ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/geometry.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 | /         match self {
[INFO] [stderr] 21 | |             &Unit::Default => format!(""),
[INFO] [stderr] 22 | |             &Unit::Percent(v) => format!("{}%", v),
[INFO] [stderr] 23 | |             &Unit::Pixel(v) => format!("{}px", v),
[INFO] [stderr] 24 | |             &Unit::Calc(ref v) => format!("calc({})", v)
[INFO] [stderr] 25 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 20 |         match *self {
[INFO] [stderr] 21 |             Unit::Default => format!(""),
[INFO] [stderr] 22 |             Unit::Percent(v) => format!("{}%", v),
[INFO] [stderr] 23 |             Unit::Pixel(v) => format!("{}px", v),
[INFO] [stderr] 24 |             Unit::Calc(ref v) => format!("calc({})", v)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/geometry.rs:21:31
[INFO] [stderr]    |
[INFO] [stderr] 21 |             &Unit::Default => format!(""),
[INFO] [stderr]    |                               ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `document::Document`
[INFO] [stderr]   --> src/document.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     pub fn new() -> Document {
[INFO] [stderr] 13 | |         Document {
[INFO] [stderr] 14 | |             root: None
[INFO] [stderr] 15 | |         }
[INFO] [stderr] 16 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 7  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/document.rs:28:22
[INFO] [stderr]    |
[INFO] [stderr] 28 |           let (h, c) = match &self.root {
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 29 | |             &Some(ref r) => r.generate("        ".to_string()),
[INFO] [stderr] 30 | |             &None => ("".to_string(), "".to_string())
[INFO] [stderr] 31 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let (h, c) = match self.root {
[INFO] [stderr] 29 |             Some(ref r) => r.generate("        ".to_string()),
[INFO] [stderr] 30 |             None => ("".to_string(), "".to_string())
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: static variable `id_counter` should have an upper case name such as `ID_COUNTER`
[INFO] [stderr]   --> src/container.rs:28:1
[INFO] [stderr]    |
[INFO] [stderr] 28 | static mut id_counter: usize = 0;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_upper_case_globals)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/container.rs:89:9
[INFO] [stderr]    |
[INFO] [stderr] 89 | /         match self.scrolling {
[INFO] [stderr] 90 | |             true => css.push_str("    overflow: scroll;\n"),
[INFO] [stderr] 91 | |             false => css.push_str("    overflow: hidden;\n"),
[INFO] [stderr] 92 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if self.scrolling { css.push_str("    overflow: scroll;\n") } else { css.push_str("    overflow: hidden;\n") }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/container.rs:101:12
[INFO] [stderr]     |
[INFO] [stderr] 101 |         if self.left == true {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.left`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: static variable `id_counter` should have an upper case name such as `ID_COUNTER`
[INFO] [stderr]  --> src/text.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | static mut id_counter: usize = 0;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/text.rs:49:33
[INFO] [stderr]    |
[INFO] [stderr] 49 |           else if self.size != 12 {
[INFO] [stderr]    |  _________________________________^
[INFO] [stderr] 50 | |             true
[INFO] [stderr] 51 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/text.rs:46:40
[INFO] [stderr]    |
[INFO] [stderr] 46 |           if self.font != "".to_string() {
[INFO] [stderr]    |  ________________________________________^
[INFO] [stderr] 47 | |             true
[INFO] [stderr] 48 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/text.rs:46:25
[INFO] [stderr]    |
[INFO] [stderr] 46 |         if self.font != "".to_string() {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/text.rs:55:14
[INFO] [stderr]    |
[INFO] [stderr] 55 |           else if self.text_decoration != TextDecoration::Normal {
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 56 | |             true
[INFO] [stderr] 57 | |         }
[INFO] [stderr] 58 | |         else {
[INFO] [stderr] 59 | |             false
[INFO] [stderr] 60 | |         }
[INFO] [stderr]    | |_________^ help: you can reduce it to: `self.text_decoration != TextDecoration::Normal`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: static variable `id_counter` should have an upper case name such as `ID_COUNTER`
[INFO] [stderr]  --> src/list.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | static mut id_counter: usize = 0;
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `list::List`
[INFO] [stderr]   --> src/list.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     pub fn new() -> List {
[INFO] [stderr] 28 | |         List {
[INFO] [stderr] 29 | |             items: vec![],
[INFO] [stderr] 30 | |             list_style: ListStyle::None,
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |         }
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 26 | impl Default for list::List {
[INFO] [stderr] 27 |     fn default() -> Self {
[INFO] [stderr] 28 |         Self::new()
[INFO] [stderr] 29 |     }
[INFO] [stderr] 30 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `sulfide`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "f364f19e07974fb98fd443884c1c9b569b8da6ed53ee4a18f1d258000b9ab0ce"`
[INFO] running `"docker" "rm" "-f" "f364f19e07974fb98fd443884c1c9b569b8da6ed53ee4a18f1d258000b9ab0ce"`
[INFO] [stdout] f364f19e07974fb98fd443884c1c9b569b8da6ed53ee4a18f1d258000b9ab0ce