[INFO] updating cached repository sdiguana/RustVendingMachine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sdiguana/RustVendingMachine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sdiguana/RustVendingMachine" "work/ex/clippy-test-run/sources/stable/gh/sdiguana/RustVendingMachine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sdiguana/RustVendingMachine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sdiguana/RustVendingMachine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sdiguana/RustVendingMachine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sdiguana/RustVendingMachine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2f1f0e97dc988e66492d5f1b68647b855bd7a528 [INFO] sha for GitHub repo sdiguana/RustVendingMachine: 2f1f0e97dc988e66492d5f1b68647b855bd7a528 [INFO] validating manifest of sdiguana/RustVendingMachine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sdiguana/RustVendingMachine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sdiguana/RustVendingMachine [INFO] finished frobbing sdiguana/RustVendingMachine [INFO] frobbed toml for sdiguana/RustVendingMachine written to work/ex/clippy-test-run/sources/stable/gh/sdiguana/RustVendingMachine/Cargo.toml [INFO] started frobbing sdiguana/RustVendingMachine [INFO] finished frobbing sdiguana/RustVendingMachine [INFO] frobbed toml for sdiguana/RustVendingMachine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sdiguana/RustVendingMachine/Cargo.toml [INFO] crate sdiguana/RustVendingMachine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sdiguana/RustVendingMachine against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sdiguana/RustVendingMachine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f015e635c73368746ea7fde186cc04df15b6bd9c7ccf7d8310694b072f417535 [INFO] running `"docker" "start" "-a" "f015e635c73368746ea7fde186cc04df15b6bd9c7ccf7d8310694b072f417535"` [INFO] [stderr] Checking vending_machine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return u [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `u` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/main.rs:93:26 [INFO] [stderr] | [INFO] [stderr] 93 | if n+1 > *&m.contents.len() as u32 {println!("Invalid entry: {}",n); continue;} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `m.contents.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return u [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `u` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/main.rs:93:26 [INFO] [stderr] | [INFO] [stderr] 93 | if n+1 > *&m.contents.len() as u32 {println!("Invalid entry: {}",n); continue;} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `m.contents.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | let mut coffee = Item {name: String::from("coffee"), price: 1.25, stock: 3}; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | let mut fizzy_water = Item {name: String::from("cascade ice"), price: 1.5, stock: 5}; [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | let mut candy = Item {name: String::from("life savers"), price: 0.75, stock: 1}; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | let mut mints = Item {name: String::from("mints"), price: 1.0, stock: 2}; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | let mut contents = vec![coffee, fizzy_water, candy, mints]; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:195:17 [INFO] [stderr] | [INFO] [stderr] 195 | let mut c = read_line(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | let mut q = read_line(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / let mut inp = s; [INFO] [stderr] 26 | | [INFO] [stderr] 27 | | if s.parse::().is_ok() { [INFO] [stderr] 28 | | n = s.parse::().unwrap(); [INFO] [stderr] 29 | | inp = "~"; [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let inp = if s.parse::().is_ok() { ..; "~" } else { s };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: structure field `UserCredit` should have a snake case name such as `user_credit` [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | UserCredit: f32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `isValidEntry` should have a snake case name such as `is_valid_entry` [INFO] [stderr] --> src/main.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | let mut isValidEntry = false; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:143:30 [INFO] [stderr] | [INFO] [stderr] 143 | fn print_inventory(contents: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | i=i+1; [INFO] [stderr] | ^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:193:16 [INFO] [stderr] | [INFO] [stderr] 193 | if nme.len() < 1 { nme = item.name.to_string(); } [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nme.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | let mut coffee = Item {name: String::from("coffee"), price: 1.25, stock: 3}; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | let mut fizzy_water = Item {name: String::from("cascade ice"), price: 1.5, stock: 5}; [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | let mut candy = Item {name: String::from("life savers"), price: 0.75, stock: 1}; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | let mut mints = Item {name: String::from("mints"), price: 1.0, stock: 2}; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | let mut contents = vec![coffee, fizzy_water, candy, mints]; [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:195:17 [INFO] [stderr] | [INFO] [stderr] 195 | let mut c = read_line(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | let mut q = read_line(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / let mut inp = s; [INFO] [stderr] 26 | | [INFO] [stderr] 27 | | if s.parse::().is_ok() { [INFO] [stderr] 28 | | n = s.parse::().unwrap(); [INFO] [stderr] 29 | | inp = "~"; [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let inp = if s.parse::().is_ok() { ..; "~" } else { s };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: structure field `UserCredit` should have a snake case name such as `user_credit` [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | UserCredit: f32 [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `isValidEntry` should have a snake case name such as `is_valid_entry` [INFO] [stderr] --> src/main.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | let mut isValidEntry = false; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:143:30 [INFO] [stderr] | [INFO] [stderr] 143 | fn print_inventory(contents: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | i=i+1; [INFO] [stderr] | ^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:193:16 [INFO] [stderr] | [INFO] [stderr] 193 | if nme.len() < 1 { nme = item.name.to_string(); } [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nme.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.61s [INFO] running `"docker" "inspect" "f015e635c73368746ea7fde186cc04df15b6bd9c7ccf7d8310694b072f417535"` [INFO] running `"docker" "rm" "-f" "f015e635c73368746ea7fde186cc04df15b6bd9c7ccf7d8310694b072f417535"` [INFO] [stdout] f015e635c73368746ea7fde186cc04df15b6bd9c7ccf7d8310694b072f417535