[INFO] updating cached repository sdao/gammaray [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sdao/gammaray [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sdao/gammaray" "work/ex/clippy-test-run/sources/stable/gh/sdao/gammaray"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sdao/gammaray'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sdao/gammaray" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sdao/gammaray"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sdao/gammaray'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 274b898629cb1ddee79f6adbb7076c98ef384d47 [INFO] sha for GitHub repo sdao/gammaray: 274b898629cb1ddee79f6adbb7076c98ef384d47 [INFO] validating manifest of sdao/gammaray on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sdao/gammaray on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sdao/gammaray [INFO] finished frobbing sdao/gammaray [INFO] frobbed toml for sdao/gammaray written to work/ex/clippy-test-run/sources/stable/gh/sdao/gammaray/Cargo.toml [INFO] started frobbing sdao/gammaray [INFO] finished frobbing sdao/gammaray [INFO] frobbed toml for sdao/gammaray written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sdao/gammaray/Cargo.toml [INFO] crate sdao/gammaray has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sdao/gammaray against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sdao/gammaray:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8f1a18aaae99171b902bad360a7bae0f0cff6c366960446c9b3ab8d619787a49 [INFO] running `"docker" "start" "-a" "8f1a18aaae99171b902bad360a7bae0f0cff6c366960446c9b3ab8d619787a49"` [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Checking scopeguard v0.3.2 [INFO] [stderr] Checking lazy_static v1.0.0 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Checking libc v0.2.29 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Checking either v1.1.0 [INFO] [stderr] Checking bitflags v1.0.2 [INFO] [stderr] Checking byteorder v1.2.2 [INFO] [stderr] Checking wavefront_obj v5.1.0 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking gammaray v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/camera.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | focal_length: focal_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `focal_length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/camera.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | horizontal_aperture: horizontal_aperture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `horizontal_aperture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/camera.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | vertical_aperture: vertical_aperture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertical_aperture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/camera.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | f_stop: f_stop, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `f_stop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/camera.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | xform: xform, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `xform` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/core/random.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | let x = r * f32::cos(t); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/core/random.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | let y = r * f32::sin(t); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/random.rs:238:33 [INFO] [stderr] | [INFO] [stderr] 238 | CumulativeDistribution {cdf: cdf} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/ray.rs:19:14 [INFO] [stderr] | [INFO] [stderr] 19 | Ray {origin: origin, direction: direction} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/ray.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | Ray {origin: origin, direction: direction} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/vector.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | Vec {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/vector.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | Vec {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/vector.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | Vec {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/xform.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | mat: mat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/xform.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | inv_mat: inv_mat, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `inv_mat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/core/xform.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | let w = v.x * mat[0][3] + v.y * mat[1][3] + v.z * mat[2][3] + mat[3][3]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | bbox: bbox, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | centroid: centroid [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `centroid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | bbox: bbox, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | bbox: bbox, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | dist: dist, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | surface_props: surface_props, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `surface_props` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | prim_index: prim_index [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prim_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | prims: prims, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `prims` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:379:13 [INFO] [stderr] | [INFO] [stderr] 379 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:490:13 [INFO] [stderr] | [INFO] [stderr] 490 | ray: ray, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:491:13 [INFO] [stderr] | [INFO] [stderr] 491 | surface_props: surface_props, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `surface_props` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:494:13 [INFO] [stderr] | [INFO] [stderr] 494 | dir_pdf: dir_pdf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dir_pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:32 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^^^ help: replace it with: `an` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:40 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^^^ help: replace it with: `bn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:48 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^^^ help: replace it with: `cn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:56 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^^^ help: replace it with: `at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:64 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^^^ help: replace it with: `bt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:72 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^^^ help: replace it with: `ct` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | normals: normals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `normals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | uvs: uvs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | tris: tris, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tris` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | let b = &self.vertices[tri.b]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | let c = &self.vertices[tri.c]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | let t = &ray.origin - &c; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | let u = &t.dot(&p) * inv_det; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | let q = t.cross(&edge1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:295:13 [INFO] [stderr] | [INFO] [stderr] 295 | let v = ray.direction.dot(&q) * inv_det; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | let w = 1.0 - u - v; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:320:17 [INFO] [stderr] | [INFO] [stderr] 320 | let (u, v) = uniform_sample_barycentric.ind_sample(rng); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:321:13 [INFO] [stderr] | [INFO] [stderr] 321 | let w = 1.0 - u - v; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/prim.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | normal: normal, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/prim.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | tangent: tangent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tangent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/prim.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | binormal: binormal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `binormal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/prim.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | geom_normal: geom_normal [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `geom_normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/sphere.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | result: result, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | pdf: pdf [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:89:50 [INFO] [stderr] | [INFO] [stderr] 89 | DisneyDiffuseRefl {color: diffuse_color, sheen_color: sheen_color, roughness: roughness} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sheen_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:89:76 [INFO] [stderr] | [INFO] [stderr] 89 | DisneyDiffuseRefl {color: diffuse_color, sheen_color: sheen_color, roughness: roughness} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `roughness` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:178:21 [INFO] [stderr] | [INFO] [stderr] 178 | result: result, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | pdf: pdf [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:266:13 [INFO] [stderr] | [INFO] [stderr] 266 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:382:21 [INFO] [stderr] | [INFO] [stderr] 382 | result: result, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:384:21 [INFO] [stderr] | [INFO] [stderr] 384 | pdf: pdf [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:448:13 [INFO] [stderr] | [INFO] [stderr] 448 | result: result, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:450:13 [INFO] [stderr] | [INFO] [stderr] 450 | pdf: pdf [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/material.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | emission: emission, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `emission` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/material.rs:216:17 [INFO] [stderr] | [INFO] [stderr] 216 | emission: emission, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `emission` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/material.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | emission: emission, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `emission` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/material.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | radiance: radiance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `radiance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/material.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | pdf: pdf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | DisneyFresnel {color: color, spec_color: spec_color, ior: ior, metallic: metallic} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:68:38 [INFO] [stderr] | [INFO] [stderr] 68 | DisneyFresnel {color: color, spec_color: spec_color, ior: ior, metallic: metallic} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `spec_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:68:62 [INFO] [stderr] | [INFO] [stderr] 68 | DisneyFresnel {color: color, spec_color: spec_color, ior: ior, metallic: metallic} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ior` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:68:72 [INFO] [stderr] | [INFO] [stderr] 68 | DisneyFresnel {color: color, spec_color: spec_color, ior: ior, metallic: metallic} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metallic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | DielectricFresnel {ior: ior} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ior` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | SchlickFresnel {r0: r0} [INFO] [stderr] | ^^^^^^ help: replace it with: `r0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:132:26 [INFO] [stderr] | [INFO] [stderr] 132 | GgxDistribution {ax: ax, ay: ay} [INFO] [stderr] | ^^^^^^ help: replace it with: `ax` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:132:34 [INFO] [stderr] | [INFO] [stderr] 132 | GgxDistribution {ax: ax, ay: ay} [INFO] [stderr] | ^^^^^^ help: replace it with: `ay` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/material/util.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | let (s, u) = if u2 > 0.5 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/material/util.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | let z = [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/film.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/film.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/film.rs:73:68 [INFO] [stderr] | [INFO] [stderr] 73 | samples.push(FilmSample {color: core::Vec::zero(), s: s, t: t}); [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/film.rs:73:74 [INFO] [stderr] | [INFO] [stderr] 73 | samples.push(FilmSample {color: core::Vec::zero(), s: s, t: t}); [INFO] [stderr] | ^^^^ help: replace it with: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/integrators.rs:182:25 [INFO] [stderr] | [INFO] [stderr] 182 | incoming_world: incoming_world, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `incoming_world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/integrators.rs:184:25 [INFO] [stderr] | [INFO] [stderr] 184 | surface_props: surface_props, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `surface_props` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/integrators.rs:188:25 [INFO] [stderr] | [INFO] [stderr] 188 | connectible: connectible, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connectible` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/integrators.rs:189:25 [INFO] [stderr] | [INFO] [stderr] 189 | prim_index: prim_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prim_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/integrators.rs:218:25 [INFO] [stderr] | [INFO] [stderr] 218 | throughput: throughput, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `throughput` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/camera.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | focal_length: focal_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `focal_length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/camera.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | horizontal_aperture: horizontal_aperture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `horizontal_aperture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/camera.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | vertical_aperture: vertical_aperture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertical_aperture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/camera.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | f_stop: f_stop, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `f_stop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/camera.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | xform: xform, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `xform` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/core/random.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | let x = r * f32::cos(t); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/core/random.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | let y = r * f32::sin(t); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/random.rs:238:33 [INFO] [stderr] | [INFO] [stderr] 238 | CumulativeDistribution {cdf: cdf} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/ray.rs:19:14 [INFO] [stderr] | [INFO] [stderr] 19 | Ray {origin: origin, direction: direction} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/ray.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | Ray {origin: origin, direction: direction} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/vector.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | Vec {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/vector.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | Vec {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/vector.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | Vec {x: x, y: y, z: z} [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/xform.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | mat: mat, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/xform.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | inv_mat: inv_mat, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `inv_mat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/core/xform.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | let w = v.x * mat[0][3] + v.y * mat[1][3] + v.z * mat[2][3] + mat[3][3]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | bbox: bbox, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | centroid: centroid [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `centroid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | bbox: bbox, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | bbox: bbox, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | dist: dist, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | surface_props: surface_props, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `surface_props` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | prim_index: prim_index [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prim_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | prims: prims, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `prims` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:379:13 [INFO] [stderr] | [INFO] [stderr] 379 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:490:13 [INFO] [stderr] | [INFO] [stderr] 490 | ray: ray, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:491:13 [INFO] [stderr] | [INFO] [stderr] 491 | surface_props: surface_props, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `surface_props` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/bvh.rs:494:13 [INFO] [stderr] | [INFO] [stderr] 494 | dir_pdf: dir_pdf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dir_pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:32 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^^^ help: replace it with: `an` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:40 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^^^ help: replace it with: `bn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:48 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^^^ help: replace it with: `cn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:56 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^^^ help: replace it with: `at` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:64 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^^^ help: replace it with: `bt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:34:72 [INFO] [stderr] | [INFO] [stderr] 34 | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] | ^^^^^^ help: replace it with: `ct` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | normals: normals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `normals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | uvs: uvs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/mesh.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | tris: tris, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tris` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | let b = &self.vertices[tri.b]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | let c = &self.vertices[tri.c]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | let t = &ray.origin - &c; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:289:13 [INFO] [stderr] | [INFO] [stderr] 289 | let u = &t.dot(&p) * inv_det; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | let q = t.cross(&edge1); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:295:13 [INFO] [stderr] | [INFO] [stderr] 295 | let v = ray.direction.dot(&q) * inv_det; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | let w = 1.0 - u - v; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:320:17 [INFO] [stderr] | [INFO] [stderr] 320 | let (u, v) = uniform_sample_barycentric.ind_sample(rng); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geom/mesh.rs:321:13 [INFO] [stderr] | [INFO] [stderr] 321 | let w = 1.0 - u - v; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/prim.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | normal: normal, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/prim.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | tangent: tangent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `tangent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/prim.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | binormal: binormal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `binormal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/prim.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | geom_normal: geom_normal [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `geom_normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/sphere.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | result: result, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | pdf: pdf [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:89:50 [INFO] [stderr] | [INFO] [stderr] 89 | DisneyDiffuseRefl {color: diffuse_color, sheen_color: sheen_color, roughness: roughness} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sheen_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:89:76 [INFO] [stderr] | [INFO] [stderr] 89 | DisneyDiffuseRefl {color: diffuse_color, sheen_color: sheen_color, roughness: roughness} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `roughness` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:178:21 [INFO] [stderr] | [INFO] [stderr] 178 | result: result, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | pdf: pdf [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:266:13 [INFO] [stderr] | [INFO] [stderr] 266 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:382:21 [INFO] [stderr] | [INFO] [stderr] 382 | result: result, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:384:21 [INFO] [stderr] | [INFO] [stderr] 384 | pdf: pdf [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:448:13 [INFO] [stderr] | [INFO] [stderr] 448 | result: result, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/lobes.rs:450:13 [INFO] [stderr] | [INFO] [stderr] 450 | pdf: pdf [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/material.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | emission: emission, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `emission` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/material.rs:216:17 [INFO] [stderr] | [INFO] [stderr] 216 | emission: emission, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `emission` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/material.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | emission: emission, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `emission` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/material.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | radiance: radiance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `radiance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/material.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | pdf: pdf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | DisneyFresnel {color: color, spec_color: spec_color, ior: ior, metallic: metallic} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:68:38 [INFO] [stderr] | [INFO] [stderr] 68 | DisneyFresnel {color: color, spec_color: spec_color, ior: ior, metallic: metallic} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `spec_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:68:62 [INFO] [stderr] | [INFO] [stderr] 68 | DisneyFresnel {color: color, spec_color: spec_color, ior: ior, metallic: metallic} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ior` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:68:72 [INFO] [stderr] | [INFO] [stderr] 68 | DisneyFresnel {color: color, spec_color: spec_color, ior: ior, metallic: metallic} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metallic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | DielectricFresnel {ior: ior} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ior` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | SchlickFresnel {r0: r0} [INFO] [stderr] | ^^^^^^ help: replace it with: `r0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:132:26 [INFO] [stderr] | [INFO] [stderr] 132 | GgxDistribution {ax: ax, ay: ay} [INFO] [stderr] | ^^^^^^ help: replace it with: `ax` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material/util.rs:132:34 [INFO] [stderr] | [INFO] [stderr] 132 | GgxDistribution {ax: ax, ay: ay} [INFO] [stderr] | ^^^^^^ help: replace it with: `ay` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/material/util.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | let (s, u) = if u2 > 0.5 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/material/util.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | let z = [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/film.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/film.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/film.rs:73:68 [INFO] [stderr] | [INFO] [stderr] 73 | samples.push(FilmSample {color: core::Vec::zero(), s: s, t: t}); [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/film.rs:73:74 [INFO] [stderr] | [INFO] [stderr] 73 | samples.push(FilmSample {color: core::Vec::zero(), s: s, t: t}); [INFO] [stderr] | ^^^^ help: replace it with: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/integrators.rs:182:25 [INFO] [stderr] | [INFO] [stderr] 182 | incoming_world: incoming_world, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `incoming_world` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/integrators.rs:184:25 [INFO] [stderr] | [INFO] [stderr] 184 | surface_props: surface_props, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `surface_props` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/integrators.rs:188:25 [INFO] [stderr] | [INFO] [stderr] 188 | connectible: connectible, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connectible` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/integrators.rs:189:25 [INFO] [stderr] | [INFO] [stderr] 189 | prim_index: prim_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prim_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/integrators.rs:218:25 [INFO] [stderr] | [INFO] [stderr] 218 | throughput: throughput, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `throughput` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core/bbox.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return t_min < max_dist && t_max > 0.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `t_min < max_dist && t_max > 0.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core/bbox.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return t_min < max_dist && t_max > 0.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `t_min < max_dist && t_max > 0.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geom/bvh.rs:476:9 [INFO] [stderr] | [INFO] [stderr] 476 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/geom/bvh.rs:470:41 [INFO] [stderr] | [INFO] [stderr] 470 | if let Intersection::Hit {dist, surface_props: _, prim_index: _} = self.intersect(&ray) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/geom/bvh.rs:470:59 [INFO] [stderr] | [INFO] [stderr] 470 | if let Intersection::Hit {dist, surface_props: _, prim_index: _} = self.intersect(&ray) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Hit { dist, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geom/mesh.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | return (dist, surface_props); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dist, surface_props)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geom/sphere.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | return (0.0, prim::SurfaceProperties::zero()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(0.0, prim::SurfaceProperties::zero())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/lobes.rs:27:35 [INFO] [stderr] | [INFO] [stderr] 27 | const LOBE_NONE = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/lobes.rs:29:35 [INFO] [stderr] | [INFO] [stderr] 29 | const LOBE_DIFFUSE = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/lobes.rs:33:35 [INFO] [stderr] | [INFO] [stderr] 33 | const LOBE_SPECULAR = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/lobes.rs:34:35 [INFO] [stderr] | [INFO] [stderr] 34 | const LOBE_GLOSSY = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/lobes.rs:36:35 [INFO] [stderr] | [INFO] [stderr] 36 | const LOBE_REFLECTION = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/lobes.rs:38:35 [INFO] [stderr] | [INFO] [stderr] 38 | const LOBE_TRANSMISSION = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material/lobes.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return &diffuse + &(&retro + &sheen); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&diffuse + &(&retro + &sheen)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geom/bvh.rs:476:9 [INFO] [stderr] | [INFO] [stderr] 476 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/geom/bvh.rs:470:41 [INFO] [stderr] | [INFO] [stderr] 470 | if let Intersection::Hit {dist, surface_props: _, prim_index: _} = self.intersect(&ray) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/geom/bvh.rs:470:59 [INFO] [stderr] | [INFO] [stderr] 470 | if let Intersection::Hit {dist, surface_props: _, prim_index: _} = self.intersect(&ray) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Hit { dist, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material/lobes.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material/lobes.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | return self.microfacet.pdf(&i, &half) * dwh_dwi; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.microfacet.pdf(&i, &half) * dwh_dwi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geom/mesh.rs:307:9 [INFO] [stderr] | [INFO] [stderr] 307 | return (dist, surface_props); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(dist, surface_props)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/material/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | mod material; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material/material.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | return pdf / self.lobes.len() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pdf / self.lobes.len() as f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material/material.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | / return MaterialSample { [INFO] [stderr] 229 | | emission: emission, [INFO] [stderr] 230 | | radiance: radiance, [INFO] [stderr] 231 | | outgoing: outgoing_world, [INFO] [stderr] 232 | | pdf: pdf, [INFO] [stderr] 233 | | kind: lobe.kind(), [INFO] [stderr] 234 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 228 | MaterialSample { [INFO] [stderr] 229 | emission: emission, [INFO] [stderr] 230 | radiance: radiance, [INFO] [stderr] 231 | outgoing: outgoing_world, [INFO] [stderr] 232 | pdf: pdf, [INFO] [stderr] 233 | kind: lobe.kind(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material/material.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/util.rs:188:36 [INFO] [stderr] | [INFO] [stderr] 188 | (u * (u * (u * 0.093073 + 0.309420) - 1.000000) + 0.597999); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.093_073` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/util.rs:188:47 [INFO] [stderr] | [INFO] [stderr] 188 | (u * (u * (u * 0.093073 + 0.309420) - 1.000000) + 0.597999); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.309_420` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/util.rs:188:59 [INFO] [stderr] | [INFO] [stderr] 188 | (u * (u * (u * 0.093073 + 0.309420) - 1.000000) + 0.597999); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/util.rs:188:71 [INFO] [stderr] | [INFO] [stderr] 188 | (u * (u * (u * 0.093073 + 0.309420) - 1.000000) + 0.597999); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.597_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/render/exr.rs:13:27 [INFO] [stderr] | [INFO] [stderr] 13 | const MAGIC_NUMBER: i32 = 20000630; [INFO] [stderr] | ^^^^^^^^ help: consider: `20_000_630` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geom/sphere.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | return (0.0, prim::SurfaceProperties::zero()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(0.0, prim::SurfaceProperties::zero())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/render/integrators.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | geom::Intersection::Hit {dist: _, surface_props: _, prim_index} => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/render/integrators.rs:26:47 [INFO] [stderr] | [INFO] [stderr] 26 | geom::Intersection::Hit {dist: _, surface_props: _, prim_index} => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Hit { prim_index, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/integrators.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | return camera_vertex.throughput.comp_mult(&camera_vertex.emission); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `camera_vertex.throughput.comp_mult(&camera_vertex.emission)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/integrators.rs:334:17 [INFO] [stderr] | [INFO] [stderr] 334 | return contrib; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `contrib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/integrators.rs:337:17 [INFO] [stderr] | [INFO] [stderr] 337 | return contrib; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `contrib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/integrators.rs:340:17 [INFO] [stderr] | [INFO] [stderr] 340 | return core::Vec::zero(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `core::Vec::zero()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/lobes.rs:27:35 [INFO] [stderr] | [INFO] [stderr] 27 | const LOBE_NONE = 0b00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/lobes.rs:29:35 [INFO] [stderr] | [INFO] [stderr] 29 | const LOBE_DIFFUSE = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/lobes.rs:33:35 [INFO] [stderr] | [INFO] [stderr] 33 | const LOBE_SPECULAR = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/lobes.rs:34:35 [INFO] [stderr] | [INFO] [stderr] 34 | const LOBE_GLOSSY = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/lobes.rs:36:35 [INFO] [stderr] | [INFO] [stderr] 36 | const LOBE_REFLECTION = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/lobes.rs:38:35 [INFO] [stderr] | [INFO] [stderr] 38 | const LOBE_TRANSMISSION = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material/lobes.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return &diffuse + &(&retro + &sheen); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&diffuse + &(&retro + &sheen)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material/lobes.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material/lobes.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | return self.microfacet.pdf(&i, &half) * dwh_dwi; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.microfacet.pdf(&i, &half) * dwh_dwi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/material/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | mod material; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material/material.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | return pdf / self.lobes.len() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pdf / self.lobes.len() as f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material/material.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | / return MaterialSample { [INFO] [stderr] 229 | | emission: emission, [INFO] [stderr] 230 | | radiance: radiance, [INFO] [stderr] 231 | | outgoing: outgoing_world, [INFO] [stderr] 232 | | pdf: pdf, [INFO] [stderr] 233 | | kind: lobe.kind(), [INFO] [stderr] 234 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 228 | MaterialSample { [INFO] [stderr] 229 | emission: emission, [INFO] [stderr] 230 | radiance: radiance, [INFO] [stderr] 231 | outgoing: outgoing_world, [INFO] [stderr] 232 | pdf: pdf, [INFO] [stderr] 233 | kind: lobe.kind(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material/material.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/util.rs:188:36 [INFO] [stderr] | [INFO] [stderr] 188 | (u * (u * (u * 0.093073 + 0.309420) - 1.000000) + 0.597999); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.093_073` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/util.rs:188:47 [INFO] [stderr] | [INFO] [stderr] 188 | (u * (u * (u * 0.093073 + 0.309420) - 1.000000) + 0.597999); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.309_420` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/util.rs:188:59 [INFO] [stderr] | [INFO] [stderr] 188 | (u * (u * (u * 0.093073 + 0.309420) - 1.000000) + 0.597999); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/material/util.rs:188:71 [INFO] [stderr] | [INFO] [stderr] 188 | (u * (u * (u * 0.093073 + 0.309420) - 1.000000) + 0.597999); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.597_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/render/exr.rs:13:27 [INFO] [stderr] | [INFO] [stderr] 13 | const MAGIC_NUMBER: i32 = 20000630; [INFO] [stderr] | ^^^^^^^^ help: consider: `20_000_630` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/render/integrators.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | geom::Intersection::Hit {dist: _, surface_props: _, prim_index} => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/render/integrators.rs:26:47 [INFO] [stderr] | [INFO] [stderr] 26 | geom::Intersection::Hit {dist: _, surface_props: _, prim_index} => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Hit { prim_index, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/integrators.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | return camera_vertex.throughput.comp_mult(&camera_vertex.emission); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `camera_vertex.throughput.comp_mult(&camera_vertex.emission)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/integrators.rs:334:17 [INFO] [stderr] | [INFO] [stderr] 334 | return contrib; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `contrib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/integrators.rs:337:17 [INFO] [stderr] | [INFO] [stderr] 337 | return contrib; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `contrib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/integrators.rs:340:17 [INFO] [stderr] | [INFO] [stderr] 340 | return core::Vec::zero(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `core::Vec::zero()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `self` [INFO] [stderr] --> src/core/matrix.rs:296:20 [INFO] [stderr] | [INFO] [stderr] 296 | for row in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 296 | for (row, ) in self.iter().enumerate().take(4) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/quat.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | self.real = self.real / lsq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.real /= lsq` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/quat.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | self.real = self.real * _rhs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.real *= _rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/quat.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | self.real = self.real / _rhs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.real /= _rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/core/vector.rs:268:41 [INFO] [stderr] | [INFO] [stderr] 268 | (math::clamp_unit(self.x) * 255.99999) as u8, [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `255.999_98` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/core/vector.rs:269:41 [INFO] [stderr] | [INFO] [stderr] 269 | (math::clamp_unit(self.y) * 255.99999) as u8, [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `255.999_98` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/core/vector.rs:270:41 [INFO] [stderr] | [INFO] [stderr] 270 | (math::clamp_unit(self.z) * 255.99999) as u8, [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `255.999_98` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/geom/bvh.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / pub fn new(arena: &mut BvhLinearNodeArena) -> usize { [INFO] [stderr] 98 | | arena.push(BvhLinearNode { [INFO] [stderr] 99 | | bbox: core::BBox::empty(), [INFO] [stderr] 100 | | offset: 0, [INFO] [stderr] ... | [INFO] [stderr] 104 | | arena.len() - 1 [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geom/bvh.rs:208:16 [INFO] [stderr] | [INFO] [stderr] 208 | if centroid_bbox.min[dim] == centroid_bbox.max[dim] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(centroid_bbox.min[dim] - centroid_bbox.max[dim]).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geom/bvh.rs:208:16 [INFO] [stderr] | [INFO] [stderr] 208 | if centroid_bbox.min[dim] == centroid_bbox.max[dim] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `cost` [INFO] [stderr] --> src/geom/bvh.rs:244:30 [INFO] [stderr] | [INFO] [stderr] 244 | for i in 0..(NUM_BUCKETS - 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 244 | for (i, ) in cost.iter_mut().enumerate().take((NUM_BUCKETS - 1)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `buckets`. [INFO] [stderr] --> src/geom/bvh.rs:248:34 [INFO] [stderr] | [INFO] [stderr] 248 | for j in 0..(i + 1) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 248 | for in buckets.iter().take((i + 1)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/geom/bvh.rs:248:34 [INFO] [stderr] | [INFO] [stderr] 248 | for j in 0..(i + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `buckets`. [INFO] [stderr] --> src/geom/bvh.rs:256:34 [INFO] [stderr] | [INFO] [stderr] 256 | for j in (i + 1)..NUM_BUCKETS { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 256 | for in buckets.iter().take(NUM_BUCKETS).skip((i + 1)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `cost` [INFO] [stderr] --> src/geom/bvh.rs:268:30 [INFO] [stderr] | [INFO] [stderr] 268 | for i in 1..(NUM_BUCKETS - 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 268 | for (i, ) in cost.iter().enumerate().take((NUM_BUCKETS - 1)).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `self` [INFO] [stderr] --> src/core/matrix.rs:296:20 [INFO] [stderr] | [INFO] [stderr] 296 | for row in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 296 | for (row, ) in self.iter().enumerate().take(4) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/geom/bvh.rs:311:16 [INFO] [stderr] | [INFO] [stderr] 311 | arena: &BvhBuildNodeArena, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `prim_index` is used to index `prims` [INFO] [stderr] --> src/geom/bvh.rs:342:27 [INFO] [stderr] | [INFO] [stderr] 342 | for prim_index in 0..prims.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 342 | for (prim_index, ) in prims.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `prims` [INFO] [stderr] --> src/geom/bvh.rs:366:18 [INFO] [stderr] | [INFO] [stderr] 366 | for i in 0..prims.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 366 | for (i, ) in prims.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/geom/bvh.rs:443:25 [INFO] [stderr] | [INFO] [stderr] 443 | current_node_index = current_node_index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_node_index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geom/bvh.rs:467:34 [INFO] [stderr] | [INFO] [stderr] 467 | let ray = core::Ray::new(start.clone(), (target - start).normalized()).nudge(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/quat.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | self.real = self.real / lsq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.real /= lsq` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/geom/bvh.rs:482:23 [INFO] [stderr] | [INFO] [stderr] 482 | debug_assert!(self.light_indices.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.light_indices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/quat.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | self.real = self.real * _rhs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.real *= _rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/quat.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | self.real = self.real / _rhs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.real /= _rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/geom/mesh.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new( [INFO] [stderr] 30 | | a: usize, b: usize, c: usize, [INFO] [stderr] 31 | | an: usize, bn: usize, cn: usize, [INFO] [stderr] 32 | | at: usize, bt: usize, ct: usize) -> Tri [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/geom/mesh.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | fn area(&self, vertices: &std::vec::Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[core::Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `tris`. [INFO] [stderr] --> src/geom/mesh.rs:164:18 [INFO] [stderr] | [INFO] [stderr] 164 | for i in 0..tris.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 164 | for in &tris { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `area_cdf`. [INFO] [stderr] --> src/geom/mesh.rs:168:18 [INFO] [stderr] | [INFO] [stderr] 168 | for i in 0..tris.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 168 | for in area_cdf.iter_mut().take(tris.len()) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/geom/mesh.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | area_cdf[i] = area_cdf[i] / total_area; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `area_cdf[i] /= total_area` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/geom/mesh.rs:289:17 [INFO] [stderr] | [INFO] [stderr] 289 | let u = &t.dot(&p) * inv_det; [INFO] [stderr] | ----------^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `t.dot(&p)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/core/vector.rs:268:41 [INFO] [stderr] | [INFO] [stderr] 268 | (math::clamp_unit(self.x) * 255.99999) as u8, [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `255.999_98` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/core/vector.rs:269:41 [INFO] [stderr] | [INFO] [stderr] 269 | (math::clamp_unit(self.y) * 255.99999) as u8, [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `255.999_98` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/core/vector.rs:270:41 [INFO] [stderr] | [INFO] [stderr] 270 | (math::clamp_unit(self.z) * 255.99999) as u8, [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `255.999_98` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/geom/bvh.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / pub fn new(arena: &mut BvhLinearNodeArena) -> usize { [INFO] [stderr] 98 | | arena.push(BvhLinearNode { [INFO] [stderr] 99 | | bbox: core::BBox::empty(), [INFO] [stderr] 100 | | offset: 0, [INFO] [stderr] ... | [INFO] [stderr] 104 | | arena.len() - 1 [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/geom/bvh.rs:208:16 [INFO] [stderr] | [INFO] [stderr] 208 | if centroid_bbox.min[dim] == centroid_bbox.max[dim] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(centroid_bbox.min[dim] - centroid_bbox.max[dim]).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/geom/bvh.rs:208:16 [INFO] [stderr] | [INFO] [stderr] 208 | if centroid_bbox.min[dim] == centroid_bbox.max[dim] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `cost` [INFO] [stderr] --> src/geom/bvh.rs:244:30 [INFO] [stderr] | [INFO] [stderr] 244 | for i in 0..(NUM_BUCKETS - 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 244 | for (i, ) in cost.iter_mut().enumerate().take((NUM_BUCKETS - 1)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `buckets`. [INFO] [stderr] --> src/geom/bvh.rs:248:34 [INFO] [stderr] | [INFO] [stderr] 248 | for j in 0..(i + 1) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 248 | for in buckets.iter().take((i + 1)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/geom/bvh.rs:248:34 [INFO] [stderr] | [INFO] [stderr] 248 | for j in 0..(i + 1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `buckets`. [INFO] [stderr] --> src/geom/bvh.rs:256:34 [INFO] [stderr] | [INFO] [stderr] 256 | for j in (i + 1)..NUM_BUCKETS { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 256 | for in buckets.iter().take(NUM_BUCKETS).skip((i + 1)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `cost` [INFO] [stderr] --> src/geom/bvh.rs:268:30 [INFO] [stderr] | [INFO] [stderr] 268 | for i in 1..(NUM_BUCKETS - 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 268 | for (i, ) in cost.iter().enumerate().take((NUM_BUCKETS - 1)).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/geom/bvh.rs:311:16 [INFO] [stderr] | [INFO] [stderr] 311 | arena: &BvhBuildNodeArena, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `prim_index` is used to index `prims` [INFO] [stderr] --> src/geom/bvh.rs:342:27 [INFO] [stderr] | [INFO] [stderr] 342 | for prim_index in 0..prims.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 342 | for (prim_index, ) in prims.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `prims` [INFO] [stderr] --> src/geom/bvh.rs:366:18 [INFO] [stderr] | [INFO] [stderr] 366 | for i in 0..prims.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 366 | for (i, ) in prims.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/material/lobes.rs:203:5 [INFO] [stderr] | [INFO] [stderr] 203 | / pub fn new( [INFO] [stderr] 204 | | color: core::Vec, roughness: f32, ior: f32, [INFO] [stderr] 205 | | specular_tint: f32, metallic: f32) [INFO] [stderr] 206 | | -> StandardMicrofacetRefl [INFO] [stderr] ... | [INFO] [stderr] 209 | | color, roughness, 0.0, ior, specular_tint, metallic) [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/material/lobes.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | / pub fn new(clearcoat: f32, clearcoat_gloss: f32) [INFO] [stderr] 233 | | -> StandardMicrofacetRefl [INFO] [stderr] 234 | | { [INFO] [stderr] 235 | | // Note: Disney BRDF: (ior = 1.5 -> F0 = 0.04). [INFO] [stderr] ... | [INFO] [stderr] 241 | | } [INFO] [stderr] 242 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/geom/bvh.rs:443:25 [INFO] [stderr] | [INFO] [stderr] 443 | current_node_index = current_node_index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_node_index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geom/bvh.rs:467:34 [INFO] [stderr] | [INFO] [stderr] 467 | let ray = core::Ray::new(start.clone(), (target - start).normalized()).nudge(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material/lobes.rs:309:41 [INFO] [stderr] | [INFO] [stderr] 309 | let sqrt_denom = i.dot(&half) + eta * &o.dot(&half); [INFO] [stderr] | ^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `o.dot(&half)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/geom/bvh.rs:482:23 [INFO] [stderr] | [INFO] [stderr] 482 | debug_assert!(self.light_indices.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.light_indices.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/geom/mesh.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new( [INFO] [stderr] 30 | | a: usize, b: usize, c: usize, [INFO] [stderr] 31 | | an: usize, bn: usize, cn: usize, [INFO] [stderr] 32 | | at: usize, bt: usize, ct: usize) -> Tri [INFO] [stderr] 33 | | { [INFO] [stderr] 34 | | Tri {a: a, b: b, c: c, an: an, bn: bn, cn: cn, at: at, bt: bt, ct: ct} [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/geom/mesh.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | fn area(&self, vertices: &std::vec::Vec) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[core::Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `material::lobes::PerfectDiffuse` [INFO] [stderr] --> src/material/lobes.rs:405:5 [INFO] [stderr] | [INFO] [stderr] 405 | / pub fn new() -> PerfectDiffuse { [INFO] [stderr] 406 | | PerfectDiffuse {} [INFO] [stderr] 407 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 401 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `material::lobes::PerfectMirror` [INFO] [stderr] --> src/material/lobes.rs:426:5 [INFO] [stderr] | [INFO] [stderr] 426 | / pub fn new() -> PerfectMirror { [INFO] [stderr] 427 | | PerfectMirror {} [INFO] [stderr] 428 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 422 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/material/material.rs:100:12 [INFO] [stderr] | [INFO] [stderr] 100 | if self.lobes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.lobes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `tris`. [INFO] [stderr] --> src/geom/mesh.rs:164:18 [INFO] [stderr] | [INFO] [stderr] 164 | for i in 0..tris.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 164 | for in &tris { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `area_cdf`. [INFO] [stderr] --> src/geom/mesh.rs:168:18 [INFO] [stderr] | [INFO] [stderr] 168 | for i in 0..tris.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 168 | for in area_cdf.iter_mut().take(tris.len()) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/geom/mesh.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | area_cdf[i] = area_cdf[i] / total_area; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `area_cdf[i] /= total_area` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/material/material.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | if self.lobes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.lobes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/geom/mesh.rs:289:17 [INFO] [stderr] | [INFO] [stderr] 289 | let u = &t.dot(&p) * inv_det; [INFO] [stderr] | ----------^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `t.dot(&p)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/material/material.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | / match self.light { [INFO] [stderr] 239 | | Some(_) => true, [INFO] [stderr] 240 | | None => false [INFO] [stderr] 241 | | } [INFO] [stderr] | |_________^ help: try this: `self.light.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `material::material::DisneyMaterialBuilder` [INFO] [stderr] --> src/material/material.rs:276:5 [INFO] [stderr] | [INFO] [stderr] 276 | / pub fn new() -> DisneyMaterialBuilder { [INFO] [stderr] 277 | | DisneyMaterialBuilder { [INFO] [stderr] 278 | | _base_color: core::Vec::one(), [INFO] [stderr] 279 | | _roughness: 0.5, [INFO] [stderr] ... | [INFO] [stderr] 289 | | } [INFO] [stderr] 290 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 275 | impl Default for material::material::DisneyMaterialBuilder { [INFO] [stderr] 276 | fn default() -> Self { [INFO] [stderr] 277 | Self::new() [INFO] [stderr] 278 | } [INFO] [stderr] 279 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/material/util.rs:188:59 [INFO] [stderr] | [INFO] [stderr] 188 | (u * (u * (u * 0.093073 + 0.309420) - 1.000000) + 0.597999); [INFO] [stderr] | ^^^^^^^^ help: consider changing the type or truncating it to: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/material/lobes.rs:203:5 [INFO] [stderr] | [INFO] [stderr] 203 | / pub fn new( [INFO] [stderr] 204 | | color: core::Vec, roughness: f32, ior: f32, [INFO] [stderr] 205 | | specular_tint: f32, metallic: f32) [INFO] [stderr] 206 | | -> StandardMicrofacetRefl [INFO] [stderr] ... | [INFO] [stderr] 209 | | color, roughness, 0.0, ior, specular_tint, metallic) [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/material/lobes.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | / pub fn new(clearcoat: f32, clearcoat_gloss: f32) [INFO] [stderr] 233 | | -> StandardMicrofacetRefl [INFO] [stderr] 234 | | { [INFO] [stderr] 235 | | // Note: Disney BRDF: (ior = 1.5 -> F0 = 0.04). [INFO] [stderr] ... | [INFO] [stderr] 241 | | } [INFO] [stderr] 242 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material/lobes.rs:309:41 [INFO] [stderr] | [INFO] [stderr] 309 | let sqrt_denom = i.dot(&half) + eta * &o.dot(&half); [INFO] [stderr] | ^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `o.dot(&half)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/render/exr.rs:158:30 [INFO] [stderr] | [INFO] [stderr] 158 | let z = 8 + (0 * film.width + i) * 4; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::erasing_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `film.width` [INFO] [stderr] --> src/render/exr.rs:159:30 [INFO] [stderr] | [INFO] [stderr] 159 | let y = 8 + (1 * film.width + i) * 4; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `material::lobes::PerfectDiffuse` [INFO] [stderr] --> src/material/lobes.rs:405:5 [INFO] [stderr] | [INFO] [stderr] 405 | / pub fn new() -> PerfectDiffuse { [INFO] [stderr] 406 | | PerfectDiffuse {} [INFO] [stderr] 407 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 401 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `material::lobes::PerfectMirror` [INFO] [stderr] --> src/material/lobes.rs:426:5 [INFO] [stderr] | [INFO] [stderr] 426 | / pub fn new() -> PerfectMirror { [INFO] [stderr] 427 | | PerfectMirror {} [INFO] [stderr] 428 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 422 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render/film.rs:78:47 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn report_samples(&mut self, samples: &std::vec::Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[FilmSample]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/material/material.rs:100:12 [INFO] [stderr] | [INFO] [stderr] 100 | if self.lobes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.lobes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render/film.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | for y in (min_row)..(max_row + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((min_row)..=max_row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render/film.rs:102:26 [INFO] [stderr] | [INFO] [stderr] 102 | for x in (min_col)..(max_col + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((min_col)..=max_col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/material/material.rs:166:12 [INFO] [stderr] | [INFO] [stderr] 166 | if self.lobes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.lobes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/material/material.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | / match self.light { [INFO] [stderr] 239 | | Some(_) => true, [INFO] [stderr] 240 | | None => false [INFO] [stderr] 241 | | } [INFO] [stderr] | |_________^ help: try this: `self.light.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `material::material::DisneyMaterialBuilder` [INFO] [stderr] --> src/material/material.rs:276:5 [INFO] [stderr] | [INFO] [stderr] 276 | / pub fn new() -> DisneyMaterialBuilder { [INFO] [stderr] 277 | | DisneyMaterialBuilder { [INFO] [stderr] 278 | | _base_color: core::Vec::one(), [INFO] [stderr] 279 | | _roughness: 0.5, [INFO] [stderr] ... | [INFO] [stderr] 289 | | } [INFO] [stderr] 290 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 275 | impl Default for material::material::DisneyMaterialBuilder { [INFO] [stderr] 276 | fn default() -> Self { [INFO] [stderr] 277 | Self::new() [INFO] [stderr] 278 | } [INFO] [stderr] 279 | } [INFO] [stderr] | [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/render/integrators.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | bvh[prim_index].material().display_color().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*bvh[prim_index].material().display_color()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/render/integrators.rs:142:30 [INFO] [stderr] | [INFO] [stderr] 142 | let mut throughput = initial_throughput.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*initial_throughput` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/render/integrators.rs:171:21 [INFO] [stderr] | [INFO] [stderr] 171 | / match storage.last_mut() { [INFO] [stderr] 172 | | Some(x) => { [INFO] [stderr] 173 | | let convert_density = BdptIntegrator::convert_density( [INFO] [stderr] 174 | | &x.point, &hit_point, &surface_props); [INFO] [stderr] ... | [INFO] [stderr] 177 | | None => {} [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 171 | if let Some(x) = storage.last_mut() { [INFO] [stderr] 172 | let convert_density = BdptIntegrator::convert_density( [INFO] [stderr] 173 | &x.point, &hit_point, &surface_props); [INFO] [stderr] 174 | x.pdf_reverse = pdf_reverse * convert_density; [INFO] [stderr] 175 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render/integrators.rs:272:25 [INFO] [stderr] | [INFO] [stderr] 272 | camera_storage: &BdptPath, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render/integrators.rs:273:24 [INFO] [stderr] | [INFO] [stderr] 273 | light_storage: &BdptPath, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/material/util.rs:188:59 [INFO] [stderr] | [INFO] [stderr] 188 | (u * (u * (u * 0.093073 + 0.309420) - 1.000000) + 0.597999); [INFO] [stderr] | ^^^^^^^^ help: consider changing the type or truncating it to: `1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/render/integrators.rs:336:79 [INFO] [stderr] | [INFO] [stderr] 336 | else if bvh.visibility(&camera_vertex.point, &light_vertex.point) { [INFO] [stderr] | _______________________________________________________________________________^ [INFO] [stderr] 337 | | return contrib; [INFO] [stderr] 338 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/render/integrators.rs:333:41 [INFO] [stderr] | [INFO] [stderr] 333 | if contrib.is_nearly_zero() { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 334 | | return contrib; [INFO] [stderr] 335 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render/integrators.rs:401:35 [INFO] [stderr] | [INFO] [stderr] 401 | for camera_len in 1..(camera_storage.len() + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=camera_storage.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render/integrators.rs:402:38 [INFO] [stderr] | [INFO] [stderr] 402 | for light_len in 0..(light_storage.len() + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=light_storage.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/render/exr.rs:158:30 [INFO] [stderr] | [INFO] [stderr] 158 | let z = 8 + (0 * film.width + i) * 4; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::erasing_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `film.width` [INFO] [stderr] --> src/render/exr.rs:159:30 [INFO] [stderr] | [INFO] [stderr] 159 | let y = 8 + (1 * film.width + i) * 4; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render/film.rs:78:47 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn report_samples(&mut self, samples: &std::vec::Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[FilmSample]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render/film.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | for y in (min_row)..(max_row + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((min_row)..=max_row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render/film.rs:102:26 [INFO] [stderr] | [INFO] [stderr] 102 | for x in (min_col)..(max_col + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((min_col)..=max_col)` [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/render/integrators.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | bvh[prim_index].material().display_color().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*bvh[prim_index].material().display_color()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/render/integrators.rs:142:30 [INFO] [stderr] | [INFO] [stderr] 142 | let mut throughput = initial_throughput.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*initial_throughput` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/render/integrators.rs:171:21 [INFO] [stderr] | [INFO] [stderr] 171 | / match storage.last_mut() { [INFO] [stderr] 172 | | Some(x) => { [INFO] [stderr] 173 | | let convert_density = BdptIntegrator::convert_density( [INFO] [stderr] 174 | | &x.point, &hit_point, &surface_props); [INFO] [stderr] ... | [INFO] [stderr] 177 | | None => {} [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 171 | if let Some(x) = storage.last_mut() { [INFO] [stderr] 172 | let convert_density = BdptIntegrator::convert_density( [INFO] [stderr] 173 | &x.point, &hit_point, &surface_props); [INFO] [stderr] 174 | x.pdf_reverse = pdf_reverse * convert_density; [INFO] [stderr] 175 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render/integrators.rs:272:25 [INFO] [stderr] | [INFO] [stderr] 272 | camera_storage: &BdptPath, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render/integrators.rs:273:24 [INFO] [stderr] | [INFO] [stderr] 273 | light_storage: &BdptPath, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: Could not compile `gammaray`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/render/integrators.rs:336:79 [INFO] [stderr] | [INFO] [stderr] 336 | else if bvh.visibility(&camera_vertex.point, &light_vertex.point) { [INFO] [stderr] | _______________________________________________________________________________^ [INFO] [stderr] 337 | | return contrib; [INFO] [stderr] 338 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/render/integrators.rs:333:41 [INFO] [stderr] | [INFO] [stderr] 333 | if contrib.is_nearly_zero() { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 334 | | return contrib; [INFO] [stderr] 335 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render/integrators.rs:401:35 [INFO] [stderr] | [INFO] [stderr] 401 | for camera_len in 1..(camera_storage.len() + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=camera_storage.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render/integrators.rs:402:38 [INFO] [stderr] | [INFO] [stderr] 402 | for light_len in 0..(light_storage.len() + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=light_storage.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gammaray`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8f1a18aaae99171b902bad360a7bae0f0cff6c366960446c9b3ab8d619787a49"` [INFO] running `"docker" "rm" "-f" "8f1a18aaae99171b902bad360a7bae0f0cff6c366960446c9b3ab8d619787a49"` [INFO] [stdout] 8f1a18aaae99171b902bad360a7bae0f0cff6c366960446c9b3ab8d619787a49