[INFO] updating cached repository sd-rust/cargo-demo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sd-rust/cargo-demo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sd-rust/cargo-demo" "work/ex/clippy-test-run/sources/stable/gh/sd-rust/cargo-demo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sd-rust/cargo-demo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sd-rust/cargo-demo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sd-rust/cargo-demo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sd-rust/cargo-demo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 541b56a739a3a273c3b36852a8a8ff00c6e4425d [INFO] sha for GitHub repo sd-rust/cargo-demo: 541b56a739a3a273c3b36852a8a8ff00c6e4425d [INFO] validating manifest of sd-rust/cargo-demo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sd-rust/cargo-demo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sd-rust/cargo-demo [INFO] finished frobbing sd-rust/cargo-demo [INFO] frobbed toml for sd-rust/cargo-demo written to work/ex/clippy-test-run/sources/stable/gh/sd-rust/cargo-demo/Cargo.toml [INFO] started frobbing sd-rust/cargo-demo [INFO] finished frobbing sd-rust/cargo-demo [INFO] frobbed toml for sd-rust/cargo-demo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sd-rust/cargo-demo/Cargo.toml [INFO] crate sd-rust/cargo-demo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sd-rust/cargo-demo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sd-rust/cargo-demo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ae7bbe12503ec5b6a923145ff0045f6b90807b0853471c804101bc3563018a60 [INFO] running `"docker" "start" "-a" "ae7bbe12503ec5b6a923145ff0045f6b90807b0853471c804101bc3563018a60"` [INFO] [stderr] Checking os_type v2.0.0 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking human-panic v1.0.0 [INFO] [stderr] Checking cargo-demo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:34:76 [INFO] [stderr] | [INFO] [stderr] 34 | let target_names = targets.as_array().ok_or(JsonCastError("targets"))?.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:36:46 [INFO] [stderr] | [INFO] [stderr] 36 | if t["kind"].as_array().unwrap().into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:34:76 [INFO] [stderr] | [INFO] [stderr] 34 | let target_names = targets.as_array().ok_or(JsonCastError("targets"))?.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:36:46 [INFO] [stderr] | [INFO] [stderr] 36 | if t["kind"].as_array().unwrap().into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.95s [INFO] running `"docker" "inspect" "ae7bbe12503ec5b6a923145ff0045f6b90807b0853471c804101bc3563018a60"` [INFO] running `"docker" "rm" "-f" "ae7bbe12503ec5b6a923145ff0045f6b90807b0853471c804101bc3563018a60"` [INFO] [stdout] ae7bbe12503ec5b6a923145ff0045f6b90807b0853471c804101bc3563018a60