[INFO] updating cached repository sctincman/shader_playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sctincman/shader_playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sctincman/shader_playground" "work/ex/clippy-test-run/sources/stable/gh/sctincman/shader_playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sctincman/shader_playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sctincman/shader_playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sctincman/shader_playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sctincman/shader_playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bd9e700551e0a5f70e04e734687809b48ae3e9a3 [INFO] sha for GitHub repo sctincman/shader_playground: bd9e700551e0a5f70e04e734687809b48ae3e9a3 [INFO] validating manifest of sctincman/shader_playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sctincman/shader_playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sctincman/shader_playground [INFO] finished frobbing sctincman/shader_playground [INFO] frobbed toml for sctincman/shader_playground written to work/ex/clippy-test-run/sources/stable/gh/sctincman/shader_playground/Cargo.toml [INFO] started frobbing sctincman/shader_playground [INFO] finished frobbing sctincman/shader_playground [INFO] frobbed toml for sctincman/shader_playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sctincman/shader_playground/Cargo.toml [INFO] crate sctincman/shader_playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sctincman/shader_playground against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sctincman/shader_playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 73e458df0a6f6726f819acd9c1f50847f00833373fc42e4c6635e6ac2c82cc87 [INFO] running `"docker" "start" "-a" "73e458df0a6f6726f819acd9c1f50847f00833373fc42e4c6635e6ac2c82cc87"` [INFO] [stderr] Checking num-complex v0.2.1 [INFO] [stderr] Checking approx v0.3.0 [INFO] [stderr] Compiling glutin v0.18.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking smithay-client-toolkit v0.3.0 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Checking nalgebra v0.16.8 [INFO] [stderr] Checking shader_playground v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `time_step` [INFO] [stderr] --> src/main.rs:136:24 [INFO] [stderr] | [INFO] [stderr] 136 | fn step(&mut self, time_step: time::Duration) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_time_step` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:245:26 [INFO] [stderr] | [INFO] [stderr] 245 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:249:22 [INFO] [stderr] | [INFO] [stderr] 249 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:262:17 [INFO] [stderr] | [INFO] [stderr] 262 | / str::from_utf8(&buf) [INFO] [stderr] 263 | | .ok() [INFO] [stderr] 264 | | .expect("ShaderInfoLog not valid utf8") [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: unused variable: `time_step` [INFO] [stderr] --> src/main.rs:136:24 [INFO] [stderr] | [INFO] [stderr] 136 | fn step(&mut self, time_step: time::Duration) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_time_step` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:278:26 [INFO] [stderr] | [INFO] [stderr] 278 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:282:22 [INFO] [stderr] | [INFO] [stderr] 282 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:295:17 [INFO] [stderr] | [INFO] [stderr] 295 | / str::from_utf8(&buf) [INFO] [stderr] 296 | | .ok() [INFO] [stderr] 297 | | .expect("ProgramInfoLog not valid utf8") [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:337:34 [INFO] [stderr] | [INFO] [stderr] 337 | 3.14 / 4.0, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/main.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | mem::transmute(&VERTEX_DATA[0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&VERTEX_DATA[0] as *const f32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:357:46 [INFO] [stderr] | [INFO] [stderr] 357 | gl::BindFragDataLocation(program, 0, CString::new("out_color").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:357:46 [INFO] [stderr] | [INFO] [stderr] 357 | gl::BindFragDataLocation(program, 0, CString::new("out_color").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:360:51 [INFO] [stderr] | [INFO] [stderr] 360 | pos_attr = gl::GetAttribLocation(program, CString::new("position").unwrap().as_ptr()) as GLuint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:360:51 [INFO] [stderr] | [INFO] [stderr] 360 | pos_attr = gl::GetAttribLocation(program, CString::new("position").unwrap().as_ptr()) as GLuint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/main.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | mem::transmute(&INDICES[0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&INDICES[0] as *const u32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:381:58 [INFO] [stderr] | [INFO] [stderr] 381 | world_location = gl::GetUniformLocation(program, CString::new("world").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:381:58 [INFO] [stderr] | [INFO] [stderr] 381 | world_location = gl::GetUniformLocation(program, CString::new("world").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:245:26 [INFO] [stderr] | [INFO] [stderr] 245 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:249:22 [INFO] [stderr] | [INFO] [stderr] 249 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:262:17 [INFO] [stderr] | [INFO] [stderr] 262 | / str::from_utf8(&buf) [INFO] [stderr] 263 | | .ok() [INFO] [stderr] 264 | | .expect("ShaderInfoLog not valid utf8") [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:278:26 [INFO] [stderr] | [INFO] [stderr] 278 | let mut status = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:282:22 [INFO] [stderr] | [INFO] [stderr] 282 | if status != (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:295:17 [INFO] [stderr] | [INFO] [stderr] 295 | / str::from_utf8(&buf) [INFO] [stderr] 296 | | .ok() [INFO] [stderr] 297 | | .expect("ProgramInfoLog not valid utf8") [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/main.rs:337:34 [INFO] [stderr] | [INFO] [stderr] 337 | 3.14 / 4.0, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/main.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | mem::transmute(&VERTEX_DATA[0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&VERTEX_DATA[0] as *const f32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:357:46 [INFO] [stderr] | [INFO] [stderr] 357 | gl::BindFragDataLocation(program, 0, CString::new("out_color").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:357:46 [INFO] [stderr] | [INFO] [stderr] 357 | gl::BindFragDataLocation(program, 0, CString::new("out_color").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:360:51 [INFO] [stderr] | [INFO] [stderr] 360 | pos_attr = gl::GetAttribLocation(program, CString::new("position").unwrap().as_ptr()) as GLuint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:360:51 [INFO] [stderr] | [INFO] [stderr] 360 | pos_attr = gl::GetAttribLocation(program, CString::new("position").unwrap().as_ptr()) as GLuint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/main.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | mem::transmute(&INDICES[0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&INDICES[0] as *const u32 as *const std::ffi::c_void` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/main.rs:381:58 [INFO] [stderr] | [INFO] [stderr] 381 | world_location = gl::GetUniformLocation(program, CString::new("world").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/main.rs:381:58 [INFO] [stderr] | [INFO] [stderr] 381 | world_location = gl::GetUniformLocation(program, CString::new("world").unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: Could not compile `shader_playground`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `shader_playground`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "73e458df0a6f6726f819acd9c1f50847f00833373fc42e4c6635e6ac2c82cc87"` [INFO] running `"docker" "rm" "-f" "73e458df0a6f6726f819acd9c1f50847f00833373fc42e4c6635e6ac2c82cc87"` [INFO] [stdout] 73e458df0a6f6726f819acd9c1f50847f00833373fc42e4c6635e6ac2c82cc87