[INFO] updating cached repository scsmithr/parsr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/scsmithr/parsr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/scsmithr/parsr" "work/ex/clippy-test-run/sources/stable/gh/scsmithr/parsr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/scsmithr/parsr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/scsmithr/parsr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scsmithr/parsr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scsmithr/parsr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c39d0ec572be31fe5377d5927d2e33eb24ea9cb3 [INFO] sha for GitHub repo scsmithr/parsr: c39d0ec572be31fe5377d5927d2e33eb24ea9cb3 [INFO] validating manifest of scsmithr/parsr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scsmithr/parsr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scsmithr/parsr [INFO] finished frobbing scsmithr/parsr [INFO] frobbed toml for scsmithr/parsr written to work/ex/clippy-test-run/sources/stable/gh/scsmithr/parsr/Cargo.toml [INFO] started frobbing scsmithr/parsr [INFO] finished frobbing scsmithr/parsr [INFO] frobbed toml for scsmithr/parsr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scsmithr/parsr/Cargo.toml [INFO] crate scsmithr/parsr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scsmithr/parsr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/scsmithr/parsr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 68d662e44a9309e8595b64ad64269081370ea048bf904321dd259299f4bbe2b4 [INFO] running `"docker" "start" "-a" "68d662e44a9309e8595b64ad64269081370ea048bf904321dd259299f4bbe2b4"` [INFO] [stderr] Checking parsr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | const REPLACE_STR: &'static str = "{}"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | const REPLACE_STR: &'static str = "{}"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parse.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / match re.captures(&input_buf) { [INFO] [stderr] 11 | | Some(caps) => { [INFO] [stderr] 12 | | for sub_cap in caps.iter().skip(1) { [INFO] [stderr] 13 | | match sub_cap { [INFO] [stderr] ... | [INFO] [stderr] 19 | | None => (), [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | if let Some(caps) = re.captures(&input_buf) { [INFO] [stderr] 11 | for sub_cap in caps.iter().skip(1) { [INFO] [stderr] 12 | match sub_cap { [INFO] [stderr] 13 | Some(c) => vec.push(c.as_str().to_string()), [INFO] [stderr] 14 | None => (), [INFO] [stderr] 15 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parse.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | / match sub_cap { [INFO] [stderr] 14 | | Some(c) => vec.push(c.as_str().to_string()), [INFO] [stderr] 15 | | None => (), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(c) = sub_cap { vec.push(c.as_str().to_string()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parse.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / match re.captures(&input_buf) { [INFO] [stderr] 11 | | Some(caps) => { [INFO] [stderr] 12 | | for sub_cap in caps.iter().skip(1) { [INFO] [stderr] 13 | | match sub_cap { [INFO] [stderr] ... | [INFO] [stderr] 19 | | None => (), [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | if let Some(caps) = re.captures(&input_buf) { [INFO] [stderr] 11 | for sub_cap in caps.iter().skip(1) { [INFO] [stderr] 12 | match sub_cap { [INFO] [stderr] 13 | Some(c) => vec.push(c.as_str().to_string()), [INFO] [stderr] 14 | None => (), [INFO] [stderr] 15 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parse.rs:13:17 [INFO] [stderr] | [INFO] [stderr] 13 | / match sub_cap { [INFO] [stderr] 14 | | Some(c) => vec.push(c.as_str().to_string()), [INFO] [stderr] 15 | | None => (), [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(c) = sub_cap { vec.push(c.as_str().to_string()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / match results.len() { [INFO] [stderr] 48 | | 0 => std::process::exit(1), [INFO] [stderr] 49 | | _ => (), [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ help: try this: `if let 0 = results.len() { std::process::exit(1) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | fn print_results(results: &Vec, trailing_newline: bool, delimeter: &str) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match trailing_newline { [INFO] [stderr] 62 | | true => println!("{}", last), [INFO] [stderr] 63 | | false => print!("{}", last), [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if trailing_newline { println!("{}", last) } else { print!("{}", last) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / match results.len() { [INFO] [stderr] 48 | | 0 => std::process::exit(1), [INFO] [stderr] 49 | | _ => (), [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ help: try this: `if let 0 = results.len() { std::process::exit(1) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | fn print_results(results: &Vec, trailing_newline: bool, delimeter: &str) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match trailing_newline { [INFO] [stderr] 62 | | true => println!("{}", last), [INFO] [stderr] 63 | | false => print!("{}", last), [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if trailing_newline { println!("{}", last) } else { print!("{}", last) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.35s [INFO] running `"docker" "inspect" "68d662e44a9309e8595b64ad64269081370ea048bf904321dd259299f4bbe2b4"` [INFO] running `"docker" "rm" "-f" "68d662e44a9309e8595b64ad64269081370ea048bf904321dd259299f4bbe2b4"` [INFO] [stdout] 68d662e44a9309e8595b64ad64269081370ea048bf904321dd259299f4bbe2b4