[INFO] updating cached repository scsmithr/oxide_db
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/scsmithr/oxide_db
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/scsmithr/oxide_db" "work/ex/clippy-test-run/sources/stable/gh/scsmithr/oxide_db"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/scsmithr/oxide_db'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/scsmithr/oxide_db" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scsmithr/oxide_db"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scsmithr/oxide_db'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 480f0317d1396542a60fc3fea6981f47b96dd333
[INFO] sha for GitHub repo scsmithr/oxide_db: 480f0317d1396542a60fc3fea6981f47b96dd333
[INFO] validating manifest of scsmithr/oxide_db on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of scsmithr/oxide_db on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing scsmithr/oxide_db
[INFO] finished frobbing scsmithr/oxide_db
[INFO] frobbed toml for scsmithr/oxide_db written to work/ex/clippy-test-run/sources/stable/gh/scsmithr/oxide_db/Cargo.toml
[INFO] started frobbing scsmithr/oxide_db
[INFO] finished frobbing scsmithr/oxide_db
[INFO] frobbed toml for scsmithr/oxide_db written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scsmithr/oxide_db/Cargo.toml
[INFO] crate scsmithr/oxide_db has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting scsmithr/oxide_db against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/scsmithr/oxide_db:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a505dd9b4f8d27e89630528829d25145b0735960e45a380202fb14223a5a4890
[INFO] running `"docker" "start" "-a" "a505dd9b4f8d27e89630528829d25145b0735960e45a380202fb14223a5a4890"`
[INFO] [stderr]     Checking oxide_db v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/entity/property.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 |             key: key,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/entity/property.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             val: val,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `val`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/marshallable/string_marshaller.rs:11:13
[INFO] [stderr]    |
[INFO] [stderr] 11 |             val: val,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `val`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/entity/property.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 |             key: key,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/entity/property.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             val: val,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `val`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/marshallable/string_marshaller.rs:11:13
[INFO] [stderr]    |
[INFO] [stderr] 11 |             val: val,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `val`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `e`
[INFO] [stderr]   --> src/marshallable/string_marshaller.rs:28:17
[INFO] [stderr]    |
[INFO] [stderr] 28 |             Err(e) => Err(UnmarshalError),
[INFO] [stderr]    |                 ^ help: consider using `_e` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `Node`
[INFO] [stderr]   --> src/entity/node.rs:23:1
[INFO] [stderr]    |
[INFO] [stderr] 23 | pub struct Node {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/entity/node.rs:28:5
[INFO] [stderr]    |
[INFO] [stderr] 28 |     fn new() -> Node {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `StringMarshaller`
[INFO] [stderr]  --> src/marshallable/string_marshaller.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub struct StringMarshaller {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]  --> src/marshallable/string_marshaller.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 |     pub fn new(val: String) -> StringMarshaller {
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `empty`
[INFO] [stderr]   --> src/marshallable/string_marshaller.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     pub fn empty() -> StringMarshaller {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/entity/node.rs:10:33
[INFO] [stderr]    |
[INFO] [stderr] 10 |     fn has_property(&self, key: &String) -> bool;
[INFO] [stderr]    |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/entity/node.rs:13:37
[INFO] [stderr]    |
[INFO] [stderr] 13 |     fn get_property_val(&self, key: &String) -> Option<&Vec<u8>>;
[INFO] [stderr]    |                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/entity/node.rs:16:41
[INFO] [stderr]    |
[INFO] [stderr] 16 |     fn set_property_val(&mut self, key: &String, val: Box<Marshallable>);
[INFO] [stderr]    |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/entity/node.rs:19:55
[INFO] [stderr]    |
[INFO] [stderr] 19 |     fn set_property_val_if_not_exists(&mut self, key: &String, val: Box<Marshallable>);
[INFO] [stderr]    |                                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `e`
[INFO] [stderr]   --> src/marshallable/string_marshaller.rs:28:17
[INFO] [stderr]    |
[INFO] [stderr] 28 |             Err(e) => Err(UnmarshalError),
[INFO] [stderr]    |                 ^ help: consider using `_e` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/entity/node.rs:10:33
[INFO] [stderr]    |
[INFO] [stderr] 10 |     fn has_property(&self, key: &String) -> bool;
[INFO] [stderr]    |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/entity/node.rs:13:37
[INFO] [stderr]    |
[INFO] [stderr] 13 |     fn get_property_val(&self, key: &String) -> Option<&Vec<u8>>;
[INFO] [stderr]    |                                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/entity/node.rs:16:41
[INFO] [stderr]    |
[INFO] [stderr] 16 |     fn set_property_val(&mut self, key: &String, val: Box<Marshallable>);
[INFO] [stderr]    |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/entity/node.rs:19:55
[INFO] [stderr]    |
[INFO] [stderr] 19 |     fn set_property_val_if_not_exists(&mut self, key: &String, val: Box<Marshallable>);
[INFO] [stderr]    |                                                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.60s
[INFO] running `"docker" "inspect" "a505dd9b4f8d27e89630528829d25145b0735960e45a380202fb14223a5a4890"`
[INFO] running `"docker" "rm" "-f" "a505dd9b4f8d27e89630528829d25145b0735960e45a380202fb14223a5a4890"`
[INFO] [stdout] a505dd9b4f8d27e89630528829d25145b0735960e45a380202fb14223a5a4890