[INFO] updating cached repository scripts-richard/rusty_hue [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/scripts-richard/rusty_hue [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/scripts-richard/rusty_hue" "work/ex/clippy-test-run/sources/stable/gh/scripts-richard/rusty_hue"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/scripts-richard/rusty_hue'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/scripts-richard/rusty_hue" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scripts-richard/rusty_hue"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scripts-richard/rusty_hue'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 772e65d6a138a605699925b4a942883e78d0e122 [INFO] sha for GitHub repo scripts-richard/rusty_hue: 772e65d6a138a605699925b4a942883e78d0e122 [INFO] validating manifest of scripts-richard/rusty_hue on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scripts-richard/rusty_hue on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scripts-richard/rusty_hue [INFO] finished frobbing scripts-richard/rusty_hue [INFO] frobbed toml for scripts-richard/rusty_hue written to work/ex/clippy-test-run/sources/stable/gh/scripts-richard/rusty_hue/Cargo.toml [INFO] started frobbing scripts-richard/rusty_hue [INFO] finished frobbing scripts-richard/rusty_hue [INFO] frobbed toml for scripts-richard/rusty_hue written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scripts-richard/rusty_hue/Cargo.toml [INFO] crate scripts-richard/rusty_hue has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scripts-richard/rusty_hue against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/scripts-richard/rusty_hue:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 981651af5206d91555cbd543c6c8c5b915568c2fe73477e71fc09844bd097d39 [INFO] running `"docker" "start" "-a" "981651af5206d91555cbd543c6c8c5b915568c2fe73477e71fc09844bd097d39"` [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Compiling proc-macro2 v0.4.3 [INFO] [stderr] Checking bytes v0.4.8 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking encoding_rs v0.8.10 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking url v1.7.0 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Checking libflate v0.1.18 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking http v0.1.13 [INFO] [stderr] Compiling quote v0.6.2 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Compiling syn v0.14.0 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Compiling serde_derive v1.0.59 [INFO] [stderr] Checking hyper v0.12.11 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.2 [INFO] [stderr] Checking rusty_hue v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/colors.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | let g = -x * 0.707196 + brightness * 1.655397 + y * 0.036152; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/colors.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let b = x * 0.051713 - brightness * 0.121364 + y * 1.011530; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/colors.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let y = r * 0.283881 + g * 0.668433 + b * 0.047685; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/colors.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | let z = r * 0.000088 + g * 0.072310 + b * 0.986039; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/colors.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | brightness: brightness, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `brightness` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hue.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | ip: ip, [INFO] [stderr] | ^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hue.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hue.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | base_address: base_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `base_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hue.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | lights: lights, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/colors.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | let g = -x * 0.707196 + brightness * 1.655397 + y * 0.036152; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/colors.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let b = x * 0.051713 - brightness * 0.121364 + y * 1.011530; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/colors.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | let y = r * 0.283881 + g * 0.668433 + b * 0.047685; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/colors.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | let z = r * 0.000088 + g * 0.072310 + b * 0.986039; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/colors.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | brightness: brightness, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `brightness` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hue.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | ip: ip, [INFO] [stderr] | ^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hue.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hue.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | base_address: base_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `base_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hue.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | lights: lights, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:40:21 [INFO] [stderr] | [INFO] [stderr] 40 | let r = x * 1.656492 - brightness * 0.354851 - y * 0.255038; [INFO] [stderr] | ^^^^^^^^ help: consider: `1.656_492` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:40:45 [INFO] [stderr] | [INFO] [stderr] 40 | let r = x * 1.656492 - brightness * 0.354851 - y * 0.255038; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.354_851` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:40:60 [INFO] [stderr] | [INFO] [stderr] 40 | let r = x * 1.656492 - brightness * 0.354851 - y * 0.255038; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.255_038` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | let g = -x * 0.707196 + brightness * 1.655397 + y * 0.036152; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.707_196` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:41:46 [INFO] [stderr] | [INFO] [stderr] 41 | let g = -x * 0.707196 + brightness * 1.655397 + y * 0.036152; [INFO] [stderr] | ^^^^^^^^ help: consider: `1.655_397` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:41:61 [INFO] [stderr] | [INFO] [stderr] 41 | let g = -x * 0.707196 + brightness * 1.655397 + y * 0.036152; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.036_152` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | let b = x * 0.051713 - brightness * 0.121364 + y * 1.011530; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.051_713` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:42:45 [INFO] [stderr] | [INFO] [stderr] 42 | let b = x * 0.051713 - brightness * 0.121364 + y * 1.011530; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.121_364` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:42:60 [INFO] [stderr] | [INFO] [stderr] 42 | let b = x * 0.051713 - brightness * 0.121364 + y * 1.011530; [INFO] [stderr] | ^^^^^^^^ help: consider: `1.011_530` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | if rgb[i] <= 0.0031308 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.003_130_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:105:21 [INFO] [stderr] | [INFO] [stderr] 105 | let x = r * 0.664511 + g * 0.154324 + b * 0.162028; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.664_511` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:105:36 [INFO] [stderr] | [INFO] [stderr] 105 | let x = r * 0.664511 + g * 0.154324 + b * 0.162028; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.154_324` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:105:51 [INFO] [stderr] | [INFO] [stderr] 105 | let x = r * 0.664511 + g * 0.154324 + b * 0.162028; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.162_028` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | let y = r * 0.283881 + g * 0.668433 + b * 0.047685; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.283_881` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:106:36 [INFO] [stderr] | [INFO] [stderr] 106 | let y = r * 0.283881 + g * 0.668433 + b * 0.047685; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.668_433` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:106:51 [INFO] [stderr] | [INFO] [stderr] 106 | let y = r * 0.283881 + g * 0.668433 + b * 0.047685; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.047_685` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | let z = r * 0.000088 + g * 0.072310 + b * 0.986039; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_088` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:107:36 [INFO] [stderr] | [INFO] [stderr] 107 | let z = r * 0.000088 + g * 0.072310 + b * 0.986039; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.072_310` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:107:51 [INFO] [stderr] | [INFO] [stderr] 107 | let z = r * 0.000088 + g * 0.072310 + b * 0.986039; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.986_039` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/colors.rs:132:20 [INFO] [stderr] | [INFO] [stderr] 132 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/colors.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | return Ok(colors); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(colors)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:280:26 [INFO] [stderr] | [INFO] [stderr] 280 | assert_eq!(xy.x, 0.32272673); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.322_726_73` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:281:26 [INFO] [stderr] | [INFO] [stderr] 281 | assert_eq!(xy.y, 0.32902290); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.329_022_90` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:291:26 [INFO] [stderr] | [INFO] [stderr] 291 | assert_eq!(xy.x, 0.38354447); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.383_544_47` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:292:26 [INFO] [stderr] | [INFO] [stderr] 292 | assert_eq!(xy.y, 0.15998589); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.159_985_89` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:299:16 [INFO] [stderr] | [INFO] [stderr] 299 | x: 0.32272673, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.322_726_73` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:300:16 [INFO] [stderr] | [INFO] [stderr] 300 | y: 0.32902290, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.329_022_90` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hue.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | return Ok(token); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(token)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/colors.rs:250:11 [INFO] [stderr] | [INFO] [stderr] 250 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/hue.rs:307:11 [INFO] [stderr] | [INFO] [stderr] 307 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:40:21 [INFO] [stderr] | [INFO] [stderr] 40 | let r = x * 1.656492 - brightness * 0.354851 - y * 0.255038; [INFO] [stderr] | ^^^^^^^^ help: consider: `1.656_492` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:40:45 [INFO] [stderr] | [INFO] [stderr] 40 | let r = x * 1.656492 - brightness * 0.354851 - y * 0.255038; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.354_851` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:40:60 [INFO] [stderr] | [INFO] [stderr] 40 | let r = x * 1.656492 - brightness * 0.354851 - y * 0.255038; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.255_038` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | let g = -x * 0.707196 + brightness * 1.655397 + y * 0.036152; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.707_196` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:41:46 [INFO] [stderr] | [INFO] [stderr] 41 | let g = -x * 0.707196 + brightness * 1.655397 + y * 0.036152; [INFO] [stderr] | ^^^^^^^^ help: consider: `1.655_397` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:41:61 [INFO] [stderr] | [INFO] [stderr] 41 | let g = -x * 0.707196 + brightness * 1.655397 + y * 0.036152; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.036_152` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | let b = x * 0.051713 - brightness * 0.121364 + y * 1.011530; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.051_713` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:42:45 [INFO] [stderr] | [INFO] [stderr] 42 | let b = x * 0.051713 - brightness * 0.121364 + y * 1.011530; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.121_364` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:42:60 [INFO] [stderr] | [INFO] [stderr] 42 | let b = x * 0.051713 - brightness * 0.121364 + y * 1.011530; [INFO] [stderr] | ^^^^^^^^ help: consider: `1.011_530` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | if rgb[i] <= 0.0031308 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.003_130_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:105:21 [INFO] [stderr] | [INFO] [stderr] 105 | let x = r * 0.664511 + g * 0.154324 + b * 0.162028; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.664_511` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:105:36 [INFO] [stderr] | [INFO] [stderr] 105 | let x = r * 0.664511 + g * 0.154324 + b * 0.162028; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.154_324` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:105:51 [INFO] [stderr] | [INFO] [stderr] 105 | let x = r * 0.664511 + g * 0.154324 + b * 0.162028; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.162_028` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | let y = r * 0.283881 + g * 0.668433 + b * 0.047685; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.283_881` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:106:36 [INFO] [stderr] | [INFO] [stderr] 106 | let y = r * 0.283881 + g * 0.668433 + b * 0.047685; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.668_433` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:106:51 [INFO] [stderr] | [INFO] [stderr] 106 | let y = r * 0.283881 + g * 0.668433 + b * 0.047685; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.047_685` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | let z = r * 0.000088 + g * 0.072310 + b * 0.986039; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_088` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:107:36 [INFO] [stderr] | [INFO] [stderr] 107 | let z = r * 0.000088 + g * 0.072310 + b * 0.986039; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.072_310` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/colors.rs:107:51 [INFO] [stderr] | [INFO] [stderr] 107 | let z = r * 0.000088 + g * 0.072310 + b * 0.986039; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.986_039` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/colors.rs:132:20 [INFO] [stderr] | [INFO] [stderr] 132 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/colors.rs:261:13 [INFO] [stderr] | [INFO] [stderr] 261 | return Ok(colors); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(colors)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hue.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | return Ok(token); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(token)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/colors.rs:250:11 [INFO] [stderr] | [INFO] [stderr] 250 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/hue.rs:307:11 [INFO] [stderr] | [INFO] [stderr] 307 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/colors.rs:35:26 [INFO] [stderr] | [INFO] [stderr] 35 | let brightness = xy.brightness as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(xy.brightness)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/colors.rs:42:60 [INFO] [stderr] | [INFO] [stderr] 42 | let b = x * 0.051713 - brightness * 0.121364 + y * 1.011530; [INFO] [stderr] | ^^^^^^^^ help: consider changing the type or truncating it to: `1.011_53` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `rgb`. [INFO] [stderr] --> src/colors.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 47 | for in &mut rgb { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/colors.rs:87:24 [INFO] [stderr] | [INFO] [stderr] 87 | let mut rgb = [rgb.r as f32, rgb.g as f32, rgb.b as f32]; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(rgb.r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/colors.rs:87:38 [INFO] [stderr] | [INFO] [stderr] 87 | let mut rgb = [rgb.r as f32, rgb.g as f32, rgb.b as f32]; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(rgb.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/colors.rs:87:52 [INFO] [stderr] | [INFO] [stderr] 87 | let mut rgb = [rgb.r as f32, rgb.g as f32, rgb.b as f32]; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(rgb.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `rgb`. [INFO] [stderr] --> src/colors.rs:90:18 [INFO] [stderr] | [INFO] [stderr] 90 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 90 | for in &mut rgb { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/colors.rs:35:26 [INFO] [stderr] | [INFO] [stderr] 35 | let brightness = xy.brightness as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(xy.brightness)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/colors.rs:42:60 [INFO] [stderr] | [INFO] [stderr] 42 | let b = x * 0.051713 - brightness * 0.121364 + y * 1.011530; [INFO] [stderr] | ^^^^^^^^ help: consider changing the type or truncating it to: `1.011_53` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `rgb`. [INFO] [stderr] --> src/colors.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 47 | for in &mut rgb { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/colors.rs:87:24 [INFO] [stderr] | [INFO] [stderr] 87 | let mut rgb = [rgb.r as f32, rgb.g as f32, rgb.b as f32]; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(rgb.r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/colors.rs:87:38 [INFO] [stderr] | [INFO] [stderr] 87 | let mut rgb = [rgb.r as f32, rgb.g as f32, rgb.b as f32]; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(rgb.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/colors.rs:87:52 [INFO] [stderr] | [INFO] [stderr] 87 | let mut rgb = [rgb.r as f32, rgb.g as f32, rgb.b as f32]; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(rgb.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `rgb`. [INFO] [stderr] --> src/colors.rs:90:18 [INFO] [stderr] | [INFO] [stderr] 90 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 90 | for in &mut rgb { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/hue.rs:170:27 [INFO] [stderr] | [INFO] [stderr] 170 | for (_, light) in &self.lights { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 170 | for light in self.lights.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/hue.rs:179:16 [INFO] [stderr] | [INFO] [stderr] 179 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 180 | | self.power_all(all_off) [INFO] [stderr] 181 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/hue.rs:177:20 [INFO] [stderr] | [INFO] [stderr] 177 | if all_off { [INFO] [stderr] | ____________________^ [INFO] [stderr] 178 | | self.power_all(all_off) [INFO] [stderr] 179 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/colors.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | assert_eq!(xy.x, 0.32272673); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/colors.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | assert_eq!(xy.x, 0.32272673); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/colors.rs:281:26 [INFO] [stderr] | [INFO] [stderr] 281 | assert_eq!(xy.y, 0.32902290); [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `0.329_022_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/colors.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | assert_eq!(xy.y, 0.32902290); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/colors.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | assert_eq!(xy.y, 0.32902290); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/colors.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | assert_eq!(xy.x, 0.38354447); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/colors.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | assert_eq!(xy.x, 0.38354447); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/colors.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | assert_eq!(xy.y, 0.15998589); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/colors.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | assert_eq!(xy.y, 0.15998589); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/colors.rs:300:16 [INFO] [stderr] | [INFO] [stderr] 300 | y: 0.32902290, [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `0.329_022_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/colors.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | assert_eq!(new_point.x, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/colors.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | assert_eq!(new_point.x, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/colors.rs:341:9 [INFO] [stderr] | [INFO] [stderr] 341 | assert_eq!(new_point.y, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/colors.rs:341:9 [INFO] [stderr] | [INFO] [stderr] 341 | assert_eq!(new_point.y, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/colors.rs:349:9 [INFO] [stderr] | [INFO] [stderr] 349 | assert_eq!(p1.distance_to(&p2), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/colors.rs:349:9 [INFO] [stderr] | [INFO] [stderr] 349 | assert_eq!(p1.distance_to(&p2), 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/colors.rs:363:9 [INFO] [stderr] | [INFO] [stderr] 363 | assert_eq!(new_point.x, 2.0); //use serde_json::Value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/colors.rs:363:9 [INFO] [stderr] | [INFO] [stderr] 363 | assert_eq!(new_point.x, 2.0); //use serde_json::Value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/colors.rs:364:9 [INFO] [stderr] | [INFO] [stderr] 364 | assert_eq!(new_point.y, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/colors.rs:364:9 [INFO] [stderr] | [INFO] [stderr] 364 | assert_eq!(new_point.y, 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty_hue`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/hue.rs:170:27 [INFO] [stderr] | [INFO] [stderr] 170 | for (_, light) in &self.lights { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 170 | for light in self.lights.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/hue.rs:179:16 [INFO] [stderr] | [INFO] [stderr] 179 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 180 | | self.power_all(all_off) [INFO] [stderr] 181 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/hue.rs:177:20 [INFO] [stderr] | [INFO] [stderr] 177 | if all_off { [INFO] [stderr] | ____________________^ [INFO] [stderr] 178 | | self.power_all(all_off) [INFO] [stderr] 179 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty_hue`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "981651af5206d91555cbd543c6c8c5b915568c2fe73477e71fc09844bd097d39"` [INFO] running `"docker" "rm" "-f" "981651af5206d91555cbd543c6c8c5b915568c2fe73477e71fc09844bd097d39"` [INFO] [stdout] 981651af5206d91555cbd543c6c8c5b915568c2fe73477e71fc09844bd097d39