[INFO] updating cached repository scottschroeder/zarc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/scottschroeder/zarc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/scottschroeder/zarc" "work/ex/clippy-test-run/sources/stable/gh/scottschroeder/zarc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/scottschroeder/zarc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/scottschroeder/zarc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scottschroeder/zarc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scottschroeder/zarc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2a91c47aaa22b2bab33307f547dfbdef8c3853ed [INFO] sha for GitHub repo scottschroeder/zarc: 2a91c47aaa22b2bab33307f547dfbdef8c3853ed [INFO] validating manifest of scottschroeder/zarc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scottschroeder/zarc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scottschroeder/zarc [INFO] finished frobbing scottschroeder/zarc [INFO] frobbed toml for scottschroeder/zarc written to work/ex/clippy-test-run/sources/stable/gh/scottschroeder/zarc/Cargo.toml [INFO] started frobbing scottschroeder/zarc [INFO] finished frobbing scottschroeder/zarc [INFO] frobbed toml for scottschroeder/zarc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scottschroeder/zarc/Cargo.toml [INFO] crate scottschroeder/zarc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scottschroeder/zarc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/scottschroeder/zarc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b2d94967d59dcbefa007432d29bb86822fa6fdbc08c62fcfd1601c214887a7e3 [INFO] running `"docker" "start" "-a" "b2d94967d59dcbefa007432d29bb86822fa6fdbc08c62fcfd1601c214887a7e3"` [INFO] [stderr] Compiling gcc v0.3.49 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking errno v0.1.8 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking clap v2.24.2 [INFO] [stderr] Checking exec v0.2.0 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Compiling backtrace-sys v0.1.11 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking zarc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | archive_type: archive_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `archive_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/archive.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | archive_type: archive_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `archive_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/archive.rs:11:28 [INFO] [stderr] | [INFO] [stderr] 11 | const ZIP_DEFAULT_FOLDER: &'static str = "zarc_zip_extracted"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/archive.rs:11:28 [INFO] [stderr] | [INFO] [stderr] 11 | const ZIP_DEFAULT_FOLDER: &'static str = "zarc_zip_extracted"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.35s [INFO] running `"docker" "inspect" "b2d94967d59dcbefa007432d29bb86822fa6fdbc08c62fcfd1601c214887a7e3"` [INFO] running `"docker" "rm" "-f" "b2d94967d59dcbefa007432d29bb86822fa6fdbc08c62fcfd1601c214887a7e3"` [INFO] [stdout] b2d94967d59dcbefa007432d29bb86822fa6fdbc08c62fcfd1601c214887a7e3