[INFO] updating cached repository scottschroeder/tetris-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/scottschroeder/tetris-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/scottschroeder/tetris-rs" "work/ex/clippy-test-run/sources/stable/gh/scottschroeder/tetris-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/scottschroeder/tetris-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/scottschroeder/tetris-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scottschroeder/tetris-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scottschroeder/tetris-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1861d168c708e2292ec79f3265df0229143bc6f2 [INFO] sha for GitHub repo scottschroeder/tetris-rs: 1861d168c708e2292ec79f3265df0229143bc6f2 [INFO] validating manifest of scottschroeder/tetris-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scottschroeder/tetris-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scottschroeder/tetris-rs [INFO] finished frobbing scottschroeder/tetris-rs [INFO] frobbed toml for scottschroeder/tetris-rs written to work/ex/clippy-test-run/sources/stable/gh/scottschroeder/tetris-rs/Cargo.toml [INFO] started frobbing scottschroeder/tetris-rs [INFO] finished frobbing scottschroeder/tetris-rs [INFO] frobbed toml for scottschroeder/tetris-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scottschroeder/tetris-rs/Cargo.toml [INFO] crate scottschroeder/tetris-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scottschroeder/tetris-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/scottschroeder/tetris-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ac6e9c6cfdd179368437a5858647aa310add3fa9fd4e6855d565a1a72d4a2228 [INFO] running `"docker" "start" "-a" "ac6e9c6cfdd179368437a5858647aa310add3fa9fd4e6855d565a1a72d4a2228"` [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Compiling x11-dl v2.18.3 [INFO] [stderr] Compiling log v0.4.3 [INFO] [stderr] Checking stb_truetype v0.2.2 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking pretty_env_logger v0.2.4 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking tetris v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Colorize` [INFO] [stderr] --> src/tile.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use Colorize; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tile.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / if idx >= 0 && idx < self.width as i32 { [INFO] [stderr] 26 | | if idy >= 0 && idy < self.height as i32 { [INFO] [stderr] 27 | | return Some(self.get(idx as usize, idy as usize)) [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 25 | if idx >= 0 && idx < self.width as i32 && idy >= 0 && idy < self.height as i32 { [INFO] [stderr] 26 | return Some(self.get(idx as usize, idy as usize)) [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `Colorize` [INFO] [stderr] --> src/game/mod.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use Colorize; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/game/mod.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | / if self.lock_trigger.is_ready() || self.lock_input_trigger.is_ready() { [INFO] [stderr] 231 | | if self.tetromino == self.ghost(&self.tetromino) { [INFO] [stderr] 232 | | self.lock(); [INFO] [stderr] 233 | | } [INFO] [stderr] 234 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 230 | if (self.lock_trigger.is_ready() || self.lock_input_trigger.is_ready()) && self.tetromino == self.ghost(&self.tetromino) { [INFO] [stderr] 231 | self.lock(); [INFO] [stderr] 232 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/game/mod.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | / if self.check_piece(&test_piece) { [INFO] [stderr] 250 | | if self.tetromino != test_piece { [INFO] [stderr] 251 | | if self.lock_trigger.is_armed() { [INFO] [stderr] 252 | | if self.altitude(&self.tetromino) < self.altitude(&test_piece) { [INFO] [stderr] ... | [INFO] [stderr] 260 | | } [INFO] [stderr] 261 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 249 | if self.check_piece(&test_piece) && self.tetromino != test_piece { [INFO] [stderr] 250 | if self.lock_trigger.is_armed() { [INFO] [stderr] 251 | if self.altitude(&self.tetromino) < self.altitude(&test_piece) { [INFO] [stderr] 252 | self.lock_trigger.reset(); [INFO] [stderr] 253 | self.lock_input_trigger.reset(); [INFO] [stderr] 254 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/mod.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | return disp; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `disp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `tile` [INFO] [stderr] --> src/render/tetromino.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use tile; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Point` [INFO] [stderr] --> src/render/tetromino.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | use game::{Tetromino, Point}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Colorize` [INFO] [stderr] --> src/render/text.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | use color::{RawColor, Colorize}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `tile` [INFO] [stderr] --> src/render/text.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use tile; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Colorize` [INFO] [stderr] --> src/render/score.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | use color::{RawColor, Colorize}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `tile` [INFO] [stderr] --> src/render/score.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use tile; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `RawColor` [INFO] [stderr] --> src/main.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | use color::{RawColor, Colorize}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Colorize` [INFO] [stderr] --> src/tile.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use Colorize; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tile.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / if idx >= 0 && idx < self.width as i32 { [INFO] [stderr] 26 | | if idy >= 0 && idy < self.height as i32 { [INFO] [stderr] 27 | | return Some(self.get(idx as usize, idy as usize)) [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 25 | if idx >= 0 && idx < self.width as i32 && idy >= 0 && idy < self.height as i32 { [INFO] [stderr] 26 | return Some(self.get(idx as usize, idy as usize)) [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `Colorize` [INFO] [stderr] --> src/game/mod.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use Colorize; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/game/mod.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | / if self.lock_trigger.is_ready() || self.lock_input_trigger.is_ready() { [INFO] [stderr] 231 | | if self.tetromino == self.ghost(&self.tetromino) { [INFO] [stderr] 232 | | self.lock(); [INFO] [stderr] 233 | | } [INFO] [stderr] 234 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 230 | if (self.lock_trigger.is_ready() || self.lock_input_trigger.is_ready()) && self.tetromino == self.ghost(&self.tetromino) { [INFO] [stderr] 231 | self.lock(); [INFO] [stderr] 232 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/game/mod.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | / if self.check_piece(&test_piece) { [INFO] [stderr] 250 | | if self.tetromino != test_piece { [INFO] [stderr] 251 | | if self.lock_trigger.is_armed() { [INFO] [stderr] 252 | | if self.altitude(&self.tetromino) < self.altitude(&test_piece) { [INFO] [stderr] ... | [INFO] [stderr] 260 | | } [INFO] [stderr] 261 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 249 | if self.check_piece(&test_piece) && self.tetromino != test_piece { [INFO] [stderr] 250 | if self.lock_trigger.is_armed() { [INFO] [stderr] 251 | if self.altitude(&self.tetromino) < self.altitude(&test_piece) { [INFO] [stderr] 252 | self.lock_trigger.reset(); [INFO] [stderr] 253 | self.lock_input_trigger.reset(); [INFO] [stderr] 254 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game/mod.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | return disp; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `disp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/limit.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `tile` [INFO] [stderr] --> src/render/tetromino.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use tile; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Point` [INFO] [stderr] --> src/render/tetromino.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | use game::{Tetromino, Point}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Colorize` [INFO] [stderr] --> src/render/text.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | use color::{RawColor, Colorize}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `tile` [INFO] [stderr] --> src/render/text.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use tile; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Colorize` [INFO] [stderr] --> src/render/score.rs:1:23 [INFO] [stderr] | [INFO] [stderr] 1 | use color::{RawColor, Colorize}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `tile` [INFO] [stderr] --> src/render/score.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use tile; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `RawColor` [INFO] [stderr] --> src/main.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | use color::{RawColor, Colorize}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `previous_tetromino` [INFO] [stderr] --> src/game/mod.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | let previous_tetromino = [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using `_previous_tetromino` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/main.rs:58:40 [INFO] [stderr] | [INFO] [stderr] 58 | self.gl.draw(args.viewport(), |ctx, gl| { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `previous_tetromino` [INFO] [stderr] --> src/game/mod.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | let previous_tetromino = [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using `_previous_tetromino` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/main.rs:58:40 [INFO] [stderr] | [INFO] [stderr] 58 | self.gl.draw(args.viewport(), |ctx, gl| { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_event` [INFO] [stderr] --> src/limit.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn get_event(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Fired` [INFO] [stderr] --> src/limit.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | Fired, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_event` [INFO] [stderr] --> src/limit.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn get_event(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_dimm` [INFO] [stderr] --> src/render/text.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn get_dimm(glyphs: &mut GlyphCache, font: u32, data: &str) -> (f64, f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `pause` [INFO] [stderr] --> src/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | pause: bool, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] warning: method is never used: `get_event` [INFO] [stderr] --> src/limit.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn get_event(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Fired` [INFO] [stderr] --> src/limit.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | Fired, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_event` [INFO] [stderr] --> src/limit.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn get_event(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_dimm` [INFO] [stderr] --> src/render/text.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn get_dimm(glyphs: &mut GlyphCache, font: u32, data: &str) -> (f64, f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `pause` [INFO] [stderr] --> src/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | pause: bool, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/transform.rs:33:27 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn rotate_transform(t:&Point, o: &Orientation) -> Point { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/transform.rs:33:38 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn rotate_transform(t:&Point, o: &Orientation) -> Point { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Orientation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/transform.rs:62:23 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn rotate(orient: &Orientation, rotation: &RotationDirection) -> Orientation { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Orientation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/transform.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn rotate(orient: &Orientation, rotation: &RotationDirection) -> Orientation { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `RotationDirection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/tetromino.rs:66:41 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn translate(&mut self, offset: &Point) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/tetromino.rs:71:40 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn rotate(&mut self, rotation: &RotationDirection) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `RotationDirection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/tetromino.rs:75:48 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn wall_kick_options(&self, direction: &RotationDirection) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `RotationDirection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/transform.rs:33:27 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn rotate_transform(t:&Point, o: &Orientation) -> Point { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/transform.rs:33:38 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn rotate_transform(t:&Point, o: &Orientation) -> Point { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Orientation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/transform.rs:62:23 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn rotate(orient: &Orientation, rotation: &RotationDirection) -> Orientation { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Orientation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/transform.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn rotate(orient: &Orientation, rotation: &RotationDirection) -> Orientation { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `RotationDirection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/tetromino.rs:66:41 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn translate(&mut self, offset: &Point) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/tetromino.rs:71:40 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn rotate(&mut self, rotation: &RotationDirection) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `RotationDirection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/tetromino.rs:75:48 [INFO] [stderr] | [INFO] [stderr] 75 | pub fn wall_kick_options(&self, direction: &RotationDirection) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `RotationDirection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/tetromino.rs:191:22 [INFO] [stderr] | [INFO] [stderr] 191 | fn wall_kicks(shape: &Shape, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/tetromino.rs:192:28 [INFO] [stderr] | [INFO] [stderr] 192 | orientation: &Orientation, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Orientation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/tetromino.rs:193:26 [INFO] [stderr] | [INFO] [stderr] 193 | direction: &RotationDirection) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `RotationDirection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/tetromino.rs:191:22 [INFO] [stderr] | [INFO] [stderr] 191 | fn wall_kicks(shape: &Shape, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/tetromino.rs:192:28 [INFO] [stderr] | [INFO] [stderr] 192 | orientation: &Orientation, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Orientation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game/tetromino.rs:193:26 [INFO] [stderr] | [INFO] [stderr] 193 | direction: &RotationDirection) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `RotationDirection` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a VecDeque. Using `[]` is more clear and more concise [INFO] [stderr] --> src/game/generator.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | self.queue.get(i).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.queue[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a VecDeque. Using `[]` is more clear and more concise [INFO] [stderr] --> src/game/generator.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | self.queue.get(i).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.queue[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/game/mod.rs:140:15 [INFO] [stderr] | [INFO] [stderr] 140 | }) [INFO] [stderr] | _______________^ [INFO] [stderr] 141 | | .fold(true, |a, b| a && b) [INFO] [stderr] | |______________________________________^ help: try: `.all(|b| b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let previous_tetromino =` [INFO] [stderr] --> src/game/mod.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | / let previous_tetromino = [INFO] [stderr] 153 | | mem::swap(&mut swp, &mut self.tetromino); [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game/mod.rs:173:28 [INFO] [stderr] | [INFO] [stderr] 173 | let tile = self.board.get(idx, row_reader).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.board.get(idx, row_reader)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/game/mod.rs:140:15 [INFO] [stderr] | [INFO] [stderr] 140 | }) [INFO] [stderr] | _______________^ [INFO] [stderr] 141 | | .fold(true, |a, b| a && b) [INFO] [stderr] | |______________________________________^ help: try: `.all(|b| b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let previous_tetromino =` [INFO] [stderr] --> src/game/mod.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | / let previous_tetromino = [INFO] [stderr] 153 | | mem::swap(&mut swp, &mut self.tetromino); [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game/mod.rs:173:28 [INFO] [stderr] | [INFO] [stderr] 173 | let tile = self.board.get(idx, row_reader).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.board.get(idx, row_reader)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/limit.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | / match self.is_ready() { [INFO] [stderr] 165 | | true => { [INFO] [stderr] 166 | | self.do_event(); [INFO] [stderr] 167 | | Some(()) [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | false => None, [INFO] [stderr] 170 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 164 | if self.is_ready() { [INFO] [stderr] 165 | self.do_event(); [INFO] [stderr] 166 | Some(()) [INFO] [stderr] 167 | } else { None } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/limit.rs:188:25 [INFO] [stderr] | [INFO] [stderr] 188 | / if self.time > delay { [INFO] [stderr] 189 | | true [INFO] [stderr] 190 | | } else { [INFO] [stderr] 191 | | false [INFO] [stderr] 192 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `self.time > delay` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/limit.rs:195:25 [INFO] [stderr] | [INFO] [stderr] 195 | / if self.time > self.repeat_rate { [INFO] [stderr] 196 | | true [INFO] [stderr] 197 | | } else { [INFO] [stderr] 198 | | false [INFO] [stderr] 199 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `self.time > self.repeat_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/limit.rs:204:17 [INFO] [stderr] | [INFO] [stderr] 204 | / if self.time > self.repeat_rate { [INFO] [stderr] 205 | | true [INFO] [stderr] 206 | | } else { [INFO] [stderr] 207 | | false [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `self.time > self.repeat_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/limit.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | / match self.is_ready() { [INFO] [stderr] 165 | | true => { [INFO] [stderr] 166 | | self.do_event(); [INFO] [stderr] 167 | | Some(()) [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | false => None, [INFO] [stderr] 170 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 164 | if self.is_ready() { [INFO] [stderr] 165 | self.do_event(); [INFO] [stderr] 166 | Some(()) [INFO] [stderr] 167 | } else { None } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/limit.rs:188:25 [INFO] [stderr] | [INFO] [stderr] 188 | / if self.time > delay { [INFO] [stderr] 189 | | true [INFO] [stderr] 190 | | } else { [INFO] [stderr] 191 | | false [INFO] [stderr] 192 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `self.time > delay` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/limit.rs:195:25 [INFO] [stderr] | [INFO] [stderr] 195 | / if self.time > self.repeat_rate { [INFO] [stderr] 196 | | true [INFO] [stderr] 197 | | } else { [INFO] [stderr] 198 | | false [INFO] [stderr] 199 | | } [INFO] [stderr] | |_________________________^ help: you can reduce it to: `self.time > self.repeat_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/limit.rs:204:17 [INFO] [stderr] | [INFO] [stderr] 204 | / if self.time > self.repeat_rate { [INFO] [stderr] 205 | | true [INFO] [stderr] 206 | | } else { [INFO] [stderr] 207 | | false [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `self.time > self.repeat_rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn get(&self, key: &Key) -> Option<&Command> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/input.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / match key { [INFO] [stderr] 117 | | Command::DownFast => self.drop = DropSpeed::Slow, [INFO] [stderr] 118 | | _ => {} [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ help: try this: `if let Command::DownFast = key { self.drop = DropSpeed::Slow }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/tetromino.rs:47:56 [INFO] [stderr] | [INFO] [stderr] 47 | x + width / 2.0 + tile_size * (point.x as f64 - mid_x) / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(point.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/tetromino.rs:48:58 [INFO] [stderr] | [INFO] [stderr] 48 | y + height / 2.0 + tile_size * -(point.y as f64 - mid_y) / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(point.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/tetromino.rs:70:6 [INFO] [stderr] | [INFO] [stderr] 70 | ((x_min + x_max) as f64 / 2.0, (y_min + y_max) as f64 / 2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(x_min + x_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/tetromino.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | ((x_min + x_max) as f64 / 2.0, (y_min + y_max) as f64 / 2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(y_min + y_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/render/text.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn render(&self, vp: graphics::Viewport, gl: &mut GlGraphics, glyphs: &mut GlyphCache, x: f64, y: f64, font: u32, stext: &str) { [INFO] [stderr] 20 | | use graphics::*; [INFO] [stderr] 21 | | [INFO] [stderr] 22 | | [INFO] [stderr] ... | [INFO] [stderr] 33 | | }) [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn get(&self, key: &Key) -> Option<&Command> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/text.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | let vertical_offset = (line_no as u32 * font) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(line_no as u32 * font)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/render/score.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn render(&self, vp: graphics::Viewport, gl: &mut GlGraphics, glyphs: &mut GlyphCache, x: f64, y: f64, width: f64, score: &Score) { [INFO] [stderr] 28 | | use graphics::*; [INFO] [stderr] 29 | | let height = 1.0 / self.ratio * (SCORE_TEXT_HEIGHT * self.font) as f64; [INFO] [stderr] 30 | | let background = rectangle::rectangle_by_corners(x, y, x + width, y + height); [INFO] [stderr] ... | [INFO] [stderr] 38 | | self.text_render.render(vp, gl, glyphs, text_x, text_y, self.font, &score_text(score)) [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/score.rs:29:41 [INFO] [stderr] | [INFO] [stderr] 29 | let height = 1.0 / self.ratio * (SCORE_TEXT_HEIGHT * self.font) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(SCORE_TEXT_HEIGHT * self.font)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/score.rs:33:26 [INFO] [stderr] | [INFO] [stderr] 33 | let text_y = y + ((self.font / 2) as f64) + height * (1.0 - self.ratio); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.font / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/input.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / match key { [INFO] [stderr] 117 | | Command::DownFast => self.drop = DropSpeed::Slow, [INFO] [stderr] 118 | | _ => {} [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ help: try this: `if let Command::DownFast = key { self.drop = DropSpeed::Slow }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/tetromino.rs:47:56 [INFO] [stderr] | [INFO] [stderr] 47 | x + width / 2.0 + tile_size * (point.x as f64 - mid_x) / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(point.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/tetromino.rs:48:58 [INFO] [stderr] | [INFO] [stderr] 48 | y + height / 2.0 + tile_size * -(point.y as f64 - mid_y) / 2.0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(point.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/tetromino.rs:70:6 [INFO] [stderr] | [INFO] [stderr] 70 | ((x_min + x_max) as f64 / 2.0, (y_min + y_max) as f64 / 2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(x_min + x_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/tetromino.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | ((x_min + x_max) as f64 / 2.0, (y_min + y_max) as f64 / 2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(y_min + y_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/render/text.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn render(&self, vp: graphics::Viewport, gl: &mut GlGraphics, glyphs: &mut GlyphCache, x: f64, y: f64, font: u32, stext: &str) { [INFO] [stderr] 20 | | use graphics::*; [INFO] [stderr] 21 | | [INFO] [stderr] 22 | | [INFO] [stderr] ... | [INFO] [stderr] 33 | | }) [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:79:32 [INFO] [stderr] | [INFO] [stderr] 79 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/text.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | let vertical_offset = (line_no as u32 * font) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(line_no as u32 * font)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/render/score.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn render(&self, vp: graphics::Viewport, gl: &mut GlGraphics, glyphs: &mut GlyphCache, x: f64, y: f64, width: f64, score: &Score) { [INFO] [stderr] 28 | | use graphics::*; [INFO] [stderr] 29 | | let height = 1.0 / self.ratio * (SCORE_TEXT_HEIGHT * self.font) as f64; [INFO] [stderr] 30 | | let background = rectangle::rectangle_by_corners(x, y, x + width, y + height); [INFO] [stderr] ... | [INFO] [stderr] 38 | | self.text_render.render(vp, gl, glyphs, text_x, text_y, self.font, &score_text(score)) [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/score.rs:29:41 [INFO] [stderr] | [INFO] [stderr] 29 | let height = 1.0 / self.ratio * (SCORE_TEXT_HEIGHT * self.font) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(SCORE_TEXT_HEIGHT * self.font)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render/score.rs:33:26 [INFO] [stderr] | [INFO] [stderr] 33 | let text_y = y + ((self.font / 2) as f64) + height * (1.0 - self.ratio); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.font / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:79:32 [INFO] [stderr] | [INFO] [stderr] 79 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 40.39s [INFO] running `"docker" "inspect" "ac6e9c6cfdd179368437a5858647aa310add3fa9fd4e6855d565a1a72d4a2228"` [INFO] running `"docker" "rm" "-f" "ac6e9c6cfdd179368437a5858647aa310add3fa9fd4e6855d565a1a72d4a2228"` [INFO] [stdout] ac6e9c6cfdd179368437a5858647aa310add3fa9fd4e6855d565a1a72d4a2228