[INFO] updating cached repository scottrobertwhittaker/rs-moji [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/scottrobertwhittaker/rs-moji [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/scottrobertwhittaker/rs-moji" "work/ex/clippy-test-run/sources/stable/gh/scottrobertwhittaker/rs-moji"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/scottrobertwhittaker/rs-moji'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/scottrobertwhittaker/rs-moji" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scottrobertwhittaker/rs-moji"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scottrobertwhittaker/rs-moji'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2595abc567aa6ddf0502e8e2d2e6902754a21068 [INFO] sha for GitHub repo scottrobertwhittaker/rs-moji: 2595abc567aa6ddf0502e8e2d2e6902754a21068 [INFO] validating manifest of scottrobertwhittaker/rs-moji on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scottrobertwhittaker/rs-moji on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scottrobertwhittaker/rs-moji [INFO] finished frobbing scottrobertwhittaker/rs-moji [INFO] frobbed toml for scottrobertwhittaker/rs-moji written to work/ex/clippy-test-run/sources/stable/gh/scottrobertwhittaker/rs-moji/Cargo.toml [INFO] started frobbing scottrobertwhittaker/rs-moji [INFO] finished frobbing scottrobertwhittaker/rs-moji [INFO] frobbed toml for scottrobertwhittaker/rs-moji written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scottrobertwhittaker/rs-moji/Cargo.toml [INFO] crate scottrobertwhittaker/rs-moji has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scottrobertwhittaker/rs-moji against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/scottrobertwhittaker/rs-moji:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b83647e21f256c8e63977eee6f022dd8da34ea62cc263c119994d36fca71f2bd [INFO] running `"docker" "start" "-a" "b83647e21f256c8e63977eee6f022dd8da34ea62cc263c119994d36fca71f2bd"` [INFO] [stderr] Checking rs-moji v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter.rs:15:19 [INFO] [stderr] | [INFO] [stderr] 15 | Interpreter { runtime: runtime, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `runtime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter.rs:15:19 [INFO] [stderr] | [INFO] [stderr] 15 | Interpreter { runtime: runtime, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `runtime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/interpreter.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | io::stdin().read_line(&mut input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/interpreter.rs:62:35 [INFO] [stderr] | [INFO] [stderr] 62 | let end = self.loop_map.get(begin).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.loop_map[begin]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused variable: `interpreter` [INFO] [stderr] --> src/interpreter.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | let mut interpreter = new(runtime); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_interpreter` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/interpreter.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | let mut interpreter = new(runtime); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/interpreter.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | io::stdin().read_line(&mut input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/interpreter.rs:62:35 [INFO] [stderr] | [INFO] [stderr] 62 | let end = self.loop_map.get(begin).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.loop_map[begin]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.18s [INFO] running `"docker" "inspect" "b83647e21f256c8e63977eee6f022dd8da34ea62cc263c119994d36fca71f2bd"` [INFO] running `"docker" "rm" "-f" "b83647e21f256c8e63977eee6f022dd8da34ea62cc263c119994d36fca71f2bd"` [INFO] [stdout] b83647e21f256c8e63977eee6f022dd8da34ea62cc263c119994d36fca71f2bd