[INFO] updating cached repository scottlamb/mylog [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/scottlamb/mylog [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/scottlamb/mylog" "work/ex/clippy-test-run/sources/stable/gh/scottlamb/mylog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/scottlamb/mylog'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/scottlamb/mylog" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scottlamb/mylog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scottlamb/mylog'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 448368771548f8843b626be5f046cdb4dd965902 [INFO] sha for GitHub repo scottlamb/mylog: 448368771548f8843b626be5f046cdb4dd965902 [INFO] validating manifest of scottlamb/mylog on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scottlamb/mylog on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scottlamb/mylog [INFO] finished frobbing scottlamb/mylog [INFO] frobbed toml for scottlamb/mylog written to work/ex/clippy-test-run/sources/stable/gh/scottlamb/mylog/Cargo.toml [INFO] started frobbing scottlamb/mylog [INFO] finished frobbing scottlamb/mylog [INFO] frobbed toml for scottlamb/mylog written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scottlamb/mylog/Cargo.toml [INFO] crate scottlamb/mylog has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scottlamb/mylog against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/scottlamb/mylog:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e89c0a0839c28e6217b31fda1589b953393b003bb42ba5cb8483fd93bfe08f68 [INFO] running `"docker" "start" "-a" "e89c0a0839c28e6217b31fda1589b953393b003bb42ba5cb8483fd93bfe08f68"` [INFO] [stderr] Checking smallvec v0.6.0 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking parking_lot_core v0.2.10 [INFO] [stderr] Checking parking_lot v0.5.3 [INFO] [stderr] Checking mylog v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spec.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:82:29 [INFO] [stderr] | [INFO] [stderr] 82 | const TIME_FORMAT: &'static str = "%m%d %H%M%S%.3f"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:82:29 [INFO] [stderr] | [INFO] [stderr] 82 | const TIME_FORMAT: &'static str = "%m%d %H%M%S%.3f"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Builder` [INFO] [stderr] --> src/lib.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | / pub fn new() -> Self { [INFO] [stderr] 125 | | Builder{ [INFO] [stderr] 126 | | spec: None, [INFO] [stderr] 127 | | fmt: Format::Google, [INFO] [stderr] 128 | | dest: Destination::Stderr, [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | impl Default for Builder { [INFO] [stderr] 124 | fn default() -> Self { [INFO] [stderr] 125 | Self::new() [INFO] [stderr] 126 | } [INFO] [stderr] 127 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:176:26 [INFO] [stderr] | [INFO] [stderr] 176 | let l = unsafe { ::std::mem::transmute::<&log::Log, &'static log::Log>(&*logger) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&*logger as *const Logger as *const (dyn log::Log + 'static))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | / pub fn async<'a>(&'a mut self) -> AsyncHandle<'a> { [INFO] [stderr] 188 | | let was_async = { [INFO] [stderr] 189 | | let mut l = self.0.inner.lock(); [INFO] [stderr] 190 | | mem::replace(&mut l.use_async, true) [INFO] [stderr] ... | [INFO] [stderr] 199 | | } [INFO] [stderr] 200 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:284:24 [INFO] [stderr] | [INFO] [stderr] 284 | let msg = &buf[0 .. len+1]; [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Builder` [INFO] [stderr] --> src/lib.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | / pub fn new() -> Self { [INFO] [stderr] 125 | | Builder{ [INFO] [stderr] 126 | | spec: None, [INFO] [stderr] 127 | | fmt: Format::Google, [INFO] [stderr] 128 | | dest: Destination::Stderr, [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | impl Default for Builder { [INFO] [stderr] 124 | fn default() -> Self { [INFO] [stderr] 125 | Self::new() [INFO] [stderr] 126 | } [INFO] [stderr] 127 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:176:26 [INFO] [stderr] | [INFO] [stderr] 176 | let l = unsafe { ::std::mem::transmute::<&log::Log, &'static log::Log>(&*logger) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&*logger as *const Logger as *const (dyn log::Log + 'static))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | / pub fn async<'a>(&'a mut self) -> AsyncHandle<'a> { [INFO] [stderr] 188 | | let was_async = { [INFO] [stderr] 189 | | let mut l = self.0.inner.lock(); [INFO] [stderr] 190 | | mem::replace(&mut l.use_async, true) [INFO] [stderr] ... | [INFO] [stderr] 199 | | } [INFO] [stderr] 200 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:284:24 [INFO] [stderr] | [INFO] [stderr] 284 | let msg = &buf[0 .. len+1]; [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.81s [INFO] running `"docker" "inspect" "e89c0a0839c28e6217b31fda1589b953393b003bb42ba5cb8483fd93bfe08f68"` [INFO] running `"docker" "rm" "-f" "e89c0a0839c28e6217b31fda1589b953393b003bb42ba5cb8483fd93bfe08f68"` [INFO] [stdout] e89c0a0839c28e6217b31fda1589b953393b003bb42ba5cb8483fd93bfe08f68