[INFO] updating cached repository scooter-dangle/rfc-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/scooter-dangle/rfc-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/scooter-dangle/rfc-rs" "work/ex/clippy-test-run/sources/stable/gh/scooter-dangle/rfc-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/scooter-dangle/rfc-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/scooter-dangle/rfc-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scooter-dangle/rfc-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scooter-dangle/rfc-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2285d82b1314dad31586cec69c089ac3f1d95299 [INFO] sha for GitHub repo scooter-dangle/rfc-rs: 2285d82b1314dad31586cec69c089ac3f1d95299 [INFO] validating manifest of scooter-dangle/rfc-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scooter-dangle/rfc-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scooter-dangle/rfc-rs [INFO] finished frobbing scooter-dangle/rfc-rs [INFO] frobbed toml for scooter-dangle/rfc-rs written to work/ex/clippy-test-run/sources/stable/gh/scooter-dangle/rfc-rs/Cargo.toml [INFO] started frobbing scooter-dangle/rfc-rs [INFO] finished frobbing scooter-dangle/rfc-rs [INFO] frobbed toml for scooter-dangle/rfc-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scooter-dangle/rfc-rs/Cargo.toml [INFO] crate scooter-dangle/rfc-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scooter-dangle/rfc-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/scooter-dangle/rfc-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6711b3e2c02e0b1871ba1c3cb3d669f4aa48db38f647b2a816ec0b3f0ccbf591 [INFO] running `"docker" "start" "-a" "6711b3e2c02e0b1871ba1c3cb3d669f4aa48db38f647b2a816ec0b3f0ccbf591"` [INFO] [stderr] Checking lazy_static v0.1.16 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking docopt v0.6.86 [INFO] [stderr] Checking rfc v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/markdown.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | let header_text = header_regex(header) [INFO] [stderr] | _______________________^ [INFO] [stderr] 52 | | .captures(markdown).unwrap() [INFO] [stderr] 53 | | .at(0).unwrap() [INFO] [stderr] 54 | | .clone(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 51 | let header_text = &(*header_regex(header) [INFO] [stderr] 52 | .captures(markdown).unwrap() [INFO] [stderr] 53 | .at(0).unwrap()).clone(); [INFO] [stderr] | [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 51 | let header_text = &str::clone(header_regex(header) [INFO] [stderr] 52 | .captures(markdown).unwrap() [INFO] [stderr] 53 | .at(0).unwrap()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | if active.len() == 0 { println!("No active rfcs.")} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `active.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | if pending.len() == 0 { println!("No pending rfcs.") } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pending.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:211:37 [INFO] [stderr] | [INFO] [stderr] 211 | let mut out_file = File::create(filename.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 211 | let mut out_file = File::create(&(*filename).clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 211 | let mut out_file = File::create(&str::clone(filename)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:281:20 [INFO] [stderr] | [INFO] [stderr] 281 | file.write_all(&mut buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:293:17 [INFO] [stderr] | [INFO] [stderr] 293 | let p = format!("{}", [INFO] [stderr] | _________________^ [INFO] [stderr] 294 | | path.unwrap().path().file_name().unwrap() [INFO] [stderr] 295 | | .to_string_lossy() [INFO] [stderr] 296 | | .rsplitn(2, '.').nth(1).unwrap()); [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( path.unwrap().path().file_name().unwrap() [INFO] [stderr] 3 | .to_string_lossy() [INFO] [stderr] 4 | .rsplitn(2, '.').nth(1).unwrap().to_string() ) ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:307:21 [INFO] [stderr] | [INFO] [stderr] 307 | .map(|path| format!("{}", [INFO] [stderr] | _____________________^ [INFO] [stderr] 308 | | path.unwrap() [INFO] [stderr] 309 | | .path().file_name().unwrap() [INFO] [stderr] 310 | | .to_string_lossy() [INFO] [stderr] 311 | | .rsplitn(2, '.').nth(1).unwrap()) [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( path.unwrap() [INFO] [stderr] 3 | .path().file_name().unwrap() [INFO] [stderr] 4 | .to_string_lossy() [INFO] [stderr] 5 | .rsplitn(2, '.').nth(1).unwrap().to_string() ) ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:326:10 [INFO] [stderr] | [INFO] [stderr] 326 | .expect(&format!("Unable to open {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to open {}", filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:345:29 [INFO] [stderr] | [INFO] [stderr] 345 | fn markdown_link_list(rfcs: &Vec<(String, String)>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rfc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/markdown.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | let header_text = header_regex(header) [INFO] [stderr] | _______________________^ [INFO] [stderr] 52 | | .captures(markdown).unwrap() [INFO] [stderr] 53 | | .at(0).unwrap() [INFO] [stderr] 54 | | .clone(); [INFO] [stderr] | |________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 51 | let header_text = &(*header_regex(header) [INFO] [stderr] 52 | .captures(markdown).unwrap() [INFO] [stderr] 53 | .at(0).unwrap()).clone(); [INFO] [stderr] | [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 51 | let header_text = &str::clone(header_regex(header) [INFO] [stderr] 52 | .captures(markdown).unwrap() [INFO] [stderr] 53 | .at(0).unwrap()); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | if active.len() == 0 { println!("No active rfcs.")} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `active.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | if pending.len() == 0 { println!("No pending rfcs.") } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pending.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:211:37 [INFO] [stderr] | [INFO] [stderr] 211 | let mut out_file = File::create(filename.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 211 | let mut out_file = File::create(&(*filename).clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 211 | let mut out_file = File::create(&str::clone(filename)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:281:20 [INFO] [stderr] | [INFO] [stderr] 281 | file.write_all(&mut buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:293:17 [INFO] [stderr] | [INFO] [stderr] 293 | let p = format!("{}", [INFO] [stderr] | _________________^ [INFO] [stderr] 294 | | path.unwrap().path().file_name().unwrap() [INFO] [stderr] 295 | | .to_string_lossy() [INFO] [stderr] 296 | | .rsplitn(2, '.').nth(1).unwrap()); [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( path.unwrap().path().file_name().unwrap() [INFO] [stderr] 3 | .to_string_lossy() [INFO] [stderr] 4 | .rsplitn(2, '.').nth(1).unwrap().to_string() ) ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:307:21 [INFO] [stderr] | [INFO] [stderr] 307 | .map(|path| format!("{}", [INFO] [stderr] | _____________________^ [INFO] [stderr] 308 | | path.unwrap() [INFO] [stderr] 309 | | .path().file_name().unwrap() [INFO] [stderr] 310 | | .to_string_lossy() [INFO] [stderr] 311 | | .rsplitn(2, '.').nth(1).unwrap()) [INFO] [stderr] | |_____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( path.unwrap() [INFO] [stderr] 3 | .path().file_name().unwrap() [INFO] [stderr] 4 | .to_string_lossy() [INFO] [stderr] 5 | .rsplitn(2, '.').nth(1).unwrap().to_string() ) ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:326:10 [INFO] [stderr] | [INFO] [stderr] 326 | .expect(&format!("Unable to open {}", filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to open {}", filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:345:29 [INFO] [stderr] | [INFO] [stderr] 345 | fn markdown_link_list(rfcs: &Vec<(String, String)>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rfc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6711b3e2c02e0b1871ba1c3cb3d669f4aa48db38f647b2a816ec0b3f0ccbf591"` [INFO] running `"docker" "rm" "-f" "6711b3e2c02e0b1871ba1c3cb3d669f4aa48db38f647b2a816ec0b3f0ccbf591"` [INFO] [stdout] 6711b3e2c02e0b1871ba1c3cb3d669f4aa48db38f647b2a816ec0b3f0ccbf591