[INFO] updating cached repository scoiatael/colorls-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/scoiatael/colorls-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/scoiatael/colorls-rs" "work/ex/clippy-test-run/sources/stable/gh/scoiatael/colorls-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/scoiatael/colorls-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/scoiatael/colorls-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scoiatael/colorls-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scoiatael/colorls-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d583246999fa29c0b554b7e86e1c2eb34b2aa184 [INFO] sha for GitHub repo scoiatael/colorls-rs: d583246999fa29c0b554b7e86e1c2eb34b2aa184 [INFO] validating manifest of scoiatael/colorls-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scoiatael/colorls-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scoiatael/colorls-rs [INFO] finished frobbing scoiatael/colorls-rs [INFO] frobbed toml for scoiatael/colorls-rs written to work/ex/clippy-test-run/sources/stable/gh/scoiatael/colorls-rs/Cargo.toml [INFO] started frobbing scoiatael/colorls-rs [INFO] finished frobbing scoiatael/colorls-rs [INFO] frobbed toml for scoiatael/colorls-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scoiatael/colorls-rs/Cargo.toml [INFO] crate scoiatael/colorls-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scoiatael/colorls-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/scoiatael/colorls-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5a17106580b951dce32f7362e5ff7f42c49286e3432ccca2732515f3ad72b77c [INFO] running `"docker" "start" "-a" "5a17106580b951dce32f7362e5ff7f42c49286e3432ccca2732515f3ad72b77c"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking textwrap v0.8.0 [INFO] [stderr] Checking serde_yaml v0.6.2 [INFO] [stderr] Checking clap v2.26.1 [INFO] [stderr] Checking colorls v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formatter.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return get_folder_attr_alias(config, file_name) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_folder_attr_alias(config, file_name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formatter.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return get_file_attr_alias(config, extension) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_file_attr_alias(config, extension)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tabulator.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | return width < max_width [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `width < max_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formatter.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return get_folder_attr_alias(config, file_name) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_folder_attr_alias(config, file_name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/formatter.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return get_file_attr_alias(config, extension) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_file_attr_alias(config, extension)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tabulator.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | return width < max_width [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `width < max_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/formatter.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | None => Attr { icon: conf.files.get("file").unwrap().clone(), color: ColorType::UnrecognizedFile } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&conf.files["file"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/formatter.rs:48:30 [INFO] [stderr] | [INFO] [stderr] 48 | None => Attr { icon: conf.folders.get("folder").unwrap().clone(), color: ColorType::Dir } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&conf.folders["folder"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/formatter.rs:77:45 [INFO] [stderr] | [INFO] [stderr] 77 | fn color_for(config : &EntryConfig, color : &ColorType) -> ColorWrapper { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ColorType` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/formatter.rs:78:37 [INFO] [stderr] | [INFO] [stderr] 78 | let boxed : Box = match config.colors.get(color).unwrap_or(&RealColor::Grey) { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 79 | | &RealColor::Yellow => Box::new(color::Yellow), [INFO] [stderr] 80 | | &RealColor::Green => Box::new(color::Green), [INFO] [stderr] 81 | | &RealColor::Blue => Box::new(color::Blue), [INFO] [stderr] ... | [INFO] [stderr] 87 | | &RealColor::Black => Box::new(color::AnsiValue::rgb(5,5,5)), [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 78 | let boxed : Box = match *config.colors.get(color).unwrap_or(&RealColor::Grey) { [INFO] [stderr] 79 | RealColor::Yellow => Box::new(color::Yellow), [INFO] [stderr] 80 | RealColor::Green => Box::new(color::Green), [INFO] [stderr] 81 | RealColor::Blue => Box::new(color::Blue), [INFO] [stderr] 82 | RealColor::Red => Box::new(color::Red), [INFO] [stderr] 83 | RealColor::Cyan => Box::new(color::Cyan), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/formatter.rs:167:15 [INFO] [stderr] | [INFO] [stderr] 167 | fn strlen(s : &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tabulator.rs:24:60 [INFO] [stderr] | [INFO] [stderr] 24 | fn break_lines_with(order : EntryOrder, names : &Vec, n_cols : usize) -> Rows { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tabulator.rs:72:19 [INFO] [stderr] | [INFO] [stderr] 72 | fn is_valid(out : &ColumnSetup, max_width : usize) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tabulator.rs:111:50 [INFO] [stderr] | [INFO] [stderr] 111 | fn predict_column_setup(config: &Config, names : &Vec, n_cols : usize) -> ColumnSetup { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tabulator.rs:115:46 [INFO] [stderr] | [INFO] [stderr] 115 | fn is_valid_as_rows(config: &Config, names : &Vec, n_cols : usize) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tabulator.rs:122:45 [INFO] [stderr] | [INFO] [stderr] 122 | fn format_as_rows(config : &Config, names : &Vec, col_widths : ColumnSetup) -> Output { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tabulator.rs:135:40 [INFO] [stderr] | [INFO] [stderr] 135 | fn max_width(config : &Config, names : &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tabulator.rs:164:28 [INFO] [stderr] | [INFO] [stderr] 164 | fn binsearch(range : &Vec, pred : F) -> Option [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tabulator.rs:180:28 [INFO] [stderr] | [INFO] [stderr] 180 | slice = &slice[0..mid+1] [INFO] [stderr] | ^^^^^^^^ help: use: `0..=mid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/formatter.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | None => Attr { icon: conf.files.get("file").unwrap().clone(), color: ColorType::UnrecognizedFile } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&conf.files["file"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/formatter.rs:48:30 [INFO] [stderr] | [INFO] [stderr] 48 | None => Attr { icon: conf.folders.get("folder").unwrap().clone(), color: ColorType::Dir } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&conf.folders["folder"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/formatter.rs:77:45 [INFO] [stderr] | [INFO] [stderr] 77 | fn color_for(config : &EntryConfig, color : &ColorType) -> ColorWrapper { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `ColorType` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/formatter.rs:78:37 [INFO] [stderr] | [INFO] [stderr] 78 | let boxed : Box = match config.colors.get(color).unwrap_or(&RealColor::Grey) { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 79 | | &RealColor::Yellow => Box::new(color::Yellow), [INFO] [stderr] 80 | | &RealColor::Green => Box::new(color::Green), [INFO] [stderr] 81 | | &RealColor::Blue => Box::new(color::Blue), [INFO] [stderr] ... | [INFO] [stderr] 87 | | &RealColor::Black => Box::new(color::AnsiValue::rgb(5,5,5)), [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 78 | let boxed : Box = match *config.colors.get(color).unwrap_or(&RealColor::Grey) { [INFO] [stderr] 79 | RealColor::Yellow => Box::new(color::Yellow), [INFO] [stderr] 80 | RealColor::Green => Box::new(color::Green), [INFO] [stderr] 81 | RealColor::Blue => Box::new(color::Blue), [INFO] [stderr] 82 | RealColor::Red => Box::new(color::Red), [INFO] [stderr] 83 | RealColor::Cyan => Box::new(color::Cyan), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/formatter.rs:167:15 [INFO] [stderr] | [INFO] [stderr] 167 | fn strlen(s : &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tabulator.rs:24:60 [INFO] [stderr] | [INFO] [stderr] 24 | fn break_lines_with(order : EntryOrder, names : &Vec, n_cols : usize) -> Rows { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tabulator.rs:72:19 [INFO] [stderr] | [INFO] [stderr] 72 | fn is_valid(out : &ColumnSetup, max_width : usize) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tabulator.rs:111:50 [INFO] [stderr] | [INFO] [stderr] 111 | fn predict_column_setup(config: &Config, names : &Vec, n_cols : usize) -> ColumnSetup { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tabulator.rs:115:46 [INFO] [stderr] | [INFO] [stderr] 115 | fn is_valid_as_rows(config: &Config, names : &Vec, n_cols : usize) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tabulator.rs:122:45 [INFO] [stderr] | [INFO] [stderr] 122 | fn format_as_rows(config : &Config, names : &Vec, col_widths : ColumnSetup) -> Output { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tabulator.rs:135:40 [INFO] [stderr] | [INFO] [stderr] 135 | fn max_width(config : &Config, names : &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tabulator.rs:164:28 [INFO] [stderr] | [INFO] [stderr] 164 | fn binsearch(range : &Vec, pred : F) -> Option [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tabulator.rs:180:28 [INFO] [stderr] | [INFO] [stderr] 180 | slice = &slice[0..mid+1] [INFO] [stderr] | ^^^^^^^^ help: use: `0..=mid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.39s [INFO] running `"docker" "inspect" "5a17106580b951dce32f7362e5ff7f42c49286e3432ccca2732515f3ad72b77c"` [INFO] running `"docker" "rm" "-f" "5a17106580b951dce32f7362e5ff7f42c49286e3432ccca2732515f3ad72b77c"` [INFO] [stdout] 5a17106580b951dce32f7362e5ff7f42c49286e3432ccca2732515f3ad72b77c