[INFO] updating cached repository scode/hubcap [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/scode/hubcap [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/scode/hubcap" "work/ex/clippy-test-run/sources/stable/gh/scode/hubcap"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/scode/hubcap'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/scode/hubcap" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scode/hubcap"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scode/hubcap'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4ff7f6cb82923ad9a0516df851847745723c015b [INFO] sha for GitHub repo scode/hubcap: 4ff7f6cb82923ad9a0516df851847745723c015b [INFO] validating manifest of scode/hubcap on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scode/hubcap on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scode/hubcap [INFO] finished frobbing scode/hubcap [INFO] frobbed toml for scode/hubcap written to work/ex/clippy-test-run/sources/stable/gh/scode/hubcap/Cargo.toml [INFO] started frobbing scode/hubcap [INFO] finished frobbing scode/hubcap [INFO] frobbed toml for scode/hubcap written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scode/hubcap/Cargo.toml [INFO] crate scode/hubcap has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scode/hubcap against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/scode/hubcap:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4acfa9a175b11f5206124e43b33005e3438f8ac229e862aad91f6678d4d34cb1 [INFO] running `"docker" "start" "-a" "4acfa9a175b11f5206124e43b33005e3438f8ac229e862aad91f6678d4d34cb1"` [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking relay v0.1.1 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking tokio-io v0.1.9 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking webpki v0.17.0 [INFO] [stderr] Checking sct v0.2.0 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking ct-logs v0.2.0 [INFO] [stderr] Checking rustls v0.11.0 [INFO] [stderr] Checking webpki-roots v0.13.0 [INFO] [stderr] Checking tokio-rustls v0.4.0 [INFO] [stderr] Checking hyper-rustls v0.11.0 [INFO] [stderr] Checking github-rs v0.6.1 [INFO] [stderr] Checking hubcap v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `git::SystemGit` [INFO] [stderr] --> src/git.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> SystemGit { [INFO] [stderr] 43 | | SystemGit { [INFO] [stderr] 44 | | git_path: PathBuf::from("git"), [INFO] [stderr] 45 | | repo_path: PathBuf::from("."), [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `git::SystemGit` [INFO] [stderr] --> src/git.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> SystemGit { [INFO] [stderr] 43 | | SystemGit { [INFO] [stderr] 44 | | git_path: PathBuf::from("git"), [INFO] [stderr] 45 | | repo_path: PathBuf::from("."), [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/git.rs:108:28 [INFO] [stderr] | [INFO] [stderr] 108 | let bytes: &[u8] = &vec![255u8]; [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[255u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.58s [INFO] running `"docker" "inspect" "4acfa9a175b11f5206124e43b33005e3438f8ac229e862aad91f6678d4d34cb1"` [INFO] running `"docker" "rm" "-f" "4acfa9a175b11f5206124e43b33005e3438f8ac229e862aad91f6678d4d34cb1"` [INFO] [stdout] 4acfa9a175b11f5206124e43b33005e3438f8ac229e862aad91f6678d4d34cb1