[INFO] updating cached repository schultyy/log-analyzer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/schultyy/log-analyzer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/schultyy/log-analyzer" "work/ex/clippy-test-run/sources/stable/gh/schultyy/log-analyzer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/schultyy/log-analyzer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/schultyy/log-analyzer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/schultyy/log-analyzer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/schultyy/log-analyzer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b5a18fcd588613194e0194551863e1fed7d42847 [INFO] sha for GitHub repo schultyy/log-analyzer: b5a18fcd588613194e0194551863e1fed7d42847 [INFO] validating manifest of schultyy/log-analyzer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of schultyy/log-analyzer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing schultyy/log-analyzer [INFO] finished frobbing schultyy/log-analyzer [INFO] frobbed toml for schultyy/log-analyzer written to work/ex/clippy-test-run/sources/stable/gh/schultyy/log-analyzer/Cargo.toml [INFO] started frobbing schultyy/log-analyzer [INFO] finished frobbing schultyy/log-analyzer [INFO] frobbed toml for schultyy/log-analyzer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/schultyy/log-analyzer/Cargo.toml [INFO] crate schultyy/log-analyzer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting schultyy/log-analyzer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/schultyy/log-analyzer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1681f2410754243e4987cdc8e9670ab0e4780c4c13f42bf76917973354e450d2 [INFO] running `"docker" "start" "-a" "1681f2410754243e4987cdc8e9670ab0e4780c4c13f42bf76917973354e450d2"` [INFO] [stderr] Checking aho-corasick v0.6.7 [INFO] [stderr] Checking regex v1.0.4 [INFO] [stderr] Checking log-analyzer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aggregator.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | events_by_context_id: events_by_context_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `events_by_context_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validator.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | context_identifier: context_identifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `context_identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validator.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | validation_results: validation_results [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `validation_results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validator.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | log_filename: log_filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `log_filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validator.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | validation_results: validation_results [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `validation_results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/aggregator.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | events_by_context_id: events_by_context_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `events_by_context_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validator.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | context_identifier: context_identifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `context_identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validator.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | validation_results: validation_results [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `validation_results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validator.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | log_filename: log_filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `log_filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/validator.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | validation_results: validation_results [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `validation_results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:95:10 [INFO] [stderr] | [INFO] [stderr] 95 | else { [INFO] [stderr] | __________^ [INFO] [stderr] 96 | | if let Some(filter_argument) = matches.value_of("filter") { [INFO] [stderr] 97 | | if let Some(log_events) = aggregated.events_by_context_id.get(filter_argument) { [INFO] [stderr] 98 | | if matches.is_present("validate-workflow") { [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | else if let Some(filter_argument) = matches.value_of("filter") { [INFO] [stderr] 96 | if let Some(log_events) = aggregated.events_by_context_id.get(filter_argument) { [INFO] [stderr] 97 | if matches.is_present("validate-workflow") { [INFO] [stderr] 98 | let validation_results = validator::validate_workflow_for_single_context_id(aggregated.log_filename, log_events, &config_file); [INFO] [stderr] 99 | report::print_json(validation_results); [INFO] [stderr] 100 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:105:16 [INFO] [stderr] | [INFO] [stderr] 105 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 106 | | if matches.is_present("validate-workflow") { [INFO] [stderr] 107 | | let validation_results = validator::validate_workflow_for_file(aggregated, &config_file); [INFO] [stderr] 108 | | report::print_json(validation_results); [INFO] [stderr] ... | [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 105 | } else if matches.is_present("validate-workflow") { [INFO] [stderr] 106 | let validation_results = validator::validate_workflow_for_file(aggregated, &config_file); [INFO] [stderr] 107 | report::print_json(validation_results); [INFO] [stderr] 108 | println!("\n"); [INFO] [stderr] 109 | } else { [INFO] [stderr] 110 | report::print_json(aggregated); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:95:10 [INFO] [stderr] | [INFO] [stderr] 95 | else { [INFO] [stderr] | __________^ [INFO] [stderr] 96 | | if let Some(filter_argument) = matches.value_of("filter") { [INFO] [stderr] 97 | | if let Some(log_events) = aggregated.events_by_context_id.get(filter_argument) { [INFO] [stderr] 98 | | if matches.is_present("validate-workflow") { [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | else if let Some(filter_argument) = matches.value_of("filter") { [INFO] [stderr] 96 | if let Some(log_events) = aggregated.events_by_context_id.get(filter_argument) { [INFO] [stderr] 97 | if matches.is_present("validate-workflow") { [INFO] [stderr] 98 | let validation_results = validator::validate_workflow_for_single_context_id(aggregated.log_filename, log_events, &config_file); [INFO] [stderr] 99 | report::print_json(validation_results); [INFO] [stderr] 100 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:105:16 [INFO] [stderr] | [INFO] [stderr] 105 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 106 | | if matches.is_present("validate-workflow") { [INFO] [stderr] 107 | | let validation_results = validator::validate_workflow_for_file(aggregated, &config_file); [INFO] [stderr] 108 | | report::print_json(validation_results); [INFO] [stderr] ... | [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 105 | } else if matches.is_present("validate-workflow") { [INFO] [stderr] 106 | let validation_results = validator::validate_workflow_for_file(aggregated, &config_file); [INFO] [stderr] 107 | report::print_json(validation_results); [INFO] [stderr] 108 | println!("\n"); [INFO] [stderr] 109 | } else { [INFO] [stderr] 110 | report::print_json(aggregated); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/log_reader.rs:23:75 [INFO] [stderr] | [INFO] [stderr] 23 | fn matches_context_argument(log_line: &str, compiled_context_expressions: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Regex]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/log_reader.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / for cap in compiled_context_expression.captures_iter(log_line) { [INFO] [stderr] 27 | | return Some(cap[1].to_string()) [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/log_reader.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / for capture in date_identifier.captures_iter(log_line) { [INFO] [stderr] 48 | | return capture[1].to_string() [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/log_reader.rs:79:41 [INFO] [stderr] | [INFO] [stderr] 79 | let log_file_lines = log_file.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/aggregator.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / if events_by_context_id.contains_key(&context_identifier) { [INFO] [stderr] 16 | | let list = events_by_context_id.get_mut(&context_identifier).unwrap(); [INFO] [stderr] 17 | | list.push(log_event); [INFO] [stderr] 18 | | } else { [INFO] [stderr] 19 | | let log_events_by_key = vec!(log_event); [INFO] [stderr] 20 | | events_by_context_id.insert(context_identifier, log_events_by_key); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ help: consider using: `events_by_context_id.entry(context_identifier)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/validator.rs:36:82 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn validate_workflow_for_single_context_id(log_filename: String, log_events: &Vec, config_file: &config::ConfigFile) -> ValidationResults { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[log_reader::LogEvent]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/validator.rs:39:8 [INFO] [stderr] | [INFO] [stderr] 39 | if log_events.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!log_events.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/validator.rs:52:32 [INFO] [stderr] | [INFO] [stderr] 52 | fn validate_single(log_events: &Vec, config: &ConfigFile) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[LogEvent]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/validator.rs:56:53 [INFO] [stderr] | [INFO] [stderr] 56 | check_list.insert(config_step.name.clone(), log_events.iter().find(|event| event.name == config_step.name).is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|event| event.name == config_step.name).is_some()` with `any(|event| event.name == config_step.name)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/log_reader.rs:23:75 [INFO] [stderr] | [INFO] [stderr] 23 | fn matches_context_argument(log_line: &str, compiled_context_expressions: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Regex]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/log_reader.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / for cap in compiled_context_expression.captures_iter(log_line) { [INFO] [stderr] 27 | | return Some(cap[1].to_string()) [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/log_reader.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / for capture in date_identifier.captures_iter(log_line) { [INFO] [stderr] 48 | | return capture[1].to_string() [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/log_reader.rs:79:41 [INFO] [stderr] | [INFO] [stderr] 79 | let log_file_lines = log_file.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/aggregator.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / if events_by_context_id.contains_key(&context_identifier) { [INFO] [stderr] 16 | | let list = events_by_context_id.get_mut(&context_identifier).unwrap(); [INFO] [stderr] 17 | | list.push(log_event); [INFO] [stderr] 18 | | } else { [INFO] [stderr] 19 | | let log_events_by_key = vec!(log_event); [INFO] [stderr] 20 | | events_by_context_id.insert(context_identifier, log_events_by_key); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ help: consider using: `events_by_context_id.entry(context_identifier)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] error: Could not compile `log-analyzer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/validator.rs:36:82 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn validate_workflow_for_single_context_id(log_filename: String, log_events: &Vec, config_file: &config::ConfigFile) -> ValidationResults { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[log_reader::LogEvent]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/validator.rs:39:8 [INFO] [stderr] | [INFO] [stderr] 39 | if log_events.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!log_events.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/validator.rs:52:32 [INFO] [stderr] | [INFO] [stderr] 52 | fn validate_single(log_events: &Vec, config: &ConfigFile) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[LogEvent]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/validator.rs:56:53 [INFO] [stderr] | [INFO] [stderr] 56 | check_list.insert(config_step.name.clone(), log_events.iter().find(|event| event.name == config_step.name).is_some()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|event| event.name == config_step.name).is_some()` with `any(|event| event.name == config_step.name)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `log-analyzer`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1681f2410754243e4987cdc8e9670ab0e4780c4c13f42bf76917973354e450d2"` [INFO] running `"docker" "rm" "-f" "1681f2410754243e4987cdc8e9670ab0e4780c4c13f42bf76917973354e450d2"` [INFO] [stdout] 1681f2410754243e4987cdc8e9670ab0e4780c4c13f42bf76917973354e450d2