[INFO] updating cached repository schnommus/rust-fir [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/schnommus/rust-fir [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/schnommus/rust-fir" "work/ex/clippy-test-run/sources/stable/gh/schnommus/rust-fir"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/schnommus/rust-fir'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/schnommus/rust-fir" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/schnommus/rust-fir"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/schnommus/rust-fir'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 82c71f2ec7814d186b5166e41999e0d2f228f2c5 [INFO] sha for GitHub repo schnommus/rust-fir: 82c71f2ec7814d186b5166e41999e0d2f228f2c5 [INFO] validating manifest of schnommus/rust-fir on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of schnommus/rust-fir on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing schnommus/rust-fir [INFO] finished frobbing schnommus/rust-fir [INFO] frobbed toml for schnommus/rust-fir written to work/ex/clippy-test-run/sources/stable/gh/schnommus/rust-fir/Cargo.toml [INFO] started frobbing schnommus/rust-fir [INFO] finished frobbing schnommus/rust-fir [INFO] frobbed toml for schnommus/rust-fir written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/schnommus/rust-fir/Cargo.toml [INFO] crate schnommus/rust-fir has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting schnommus/rust-fir against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/schnommus/rust-fir:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2ac03dbb396e22c68f8d8aa733971c810a9695672952600a50faac1a03950196 [INFO] running `"docker" "start" "-a" "2ac03dbb396e22c68f8d8aa733971c810a9695672952600a50faac1a03950196"` [INFO] [stderr] Checking byteorder v0.5.3 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Checking raster v0.2.0 [INFO] [stderr] Checking fir v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `intensity_filtered` [INFO] [stderr] --> src/main.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | let intensity_filtered = [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using `_intensity_filtered` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `intensity_filtered` [INFO] [stderr] --> src/main.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | let intensity_filtered = [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using `_intensity_filtered` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Rectangular` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Rectangular, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BlackmanHarris` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | BlackmanHarris [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `HighPass` [INFO] [stderr] --> src/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | HighPass(f64), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BandPass` [INFO] [stderr] --> src/main.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | BandPass(f64, f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BandStop` [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | BandStop(f64, f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `dft` [INFO] [stderr] --> src/main.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | fn dft(x: &[f64], n_samples: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `white_noise` [INFO] [stderr] --> src/main.rs:120:1 [INFO] [stderr] | [INFO] [stderr] 120 | fn white_noise(n_samples: usize, amplitude: f64) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:23:43 [INFO] [stderr] | [INFO] [stderr] 23 | let samples = (1..window_len).map(|e| e as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let m = window_len as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(window_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:53:43 [INFO] [stderr] | [INFO] [stderr] 53 | let samples = (1..filter_len).map(|e| e as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let m = filter_len as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(filter_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is used to index `x` [INFO] [stderr] --> src/main.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | for n in 0..(m-1) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 86 | for (n, ) in x.iter().enumerate().take((m-1)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Rectangular` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Rectangular, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BlackmanHarris` [INFO] [stderr] warning: constant `Fs` should have an upper case name such as `FS` [INFO] [stderr] --> src/main.rs:131:1 [INFO] [stderr] | [INFO] [stderr] 131 | const Fs: f64 = 20e6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant `nyquist` should have an upper case name such as `NYQUIST` [INFO] [stderr] --> src/main.rs:132:1 [INFO] [stderr] | [INFO] [stderr] 132 | const nyquist: f64 = Fs/2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `n_lines` should have an upper case name such as `N_LINES` [INFO] [stderr] --> src/main.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | const n_lines: i32 = 625; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `n_columns` should have an upper case name such as `N_COLUMNS` [INFO] [stderr] --> src/main.rs:134:1 [INFO] [stderr] | [INFO] [stderr] 134 | const n_columns: i32 = 700; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `line_freq_hz` should have an upper case name such as `LINE_FREQ_HZ` [INFO] [stderr] --> src/main.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135 | const line_freq_hz: f64 = 15.625e3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `frame_freq_hz` should have an upper case name such as `FRAME_FREQ_HZ` [INFO] [stderr] --> src/main.rs:136:1 [INFO] [stderr] | [INFO] [stderr] 136 | const frame_freq_hz: f64 = 50.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | BlackmanHarris [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `HighPass` [INFO] [stderr] --> src/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | HighPass(f64), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BandPass` [INFO] [stderr] --> src/main.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | BandPass(f64, f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BandStop` [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | BandStop(f64, f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `dft` [INFO] [stderr] --> src/main.rs:78:1 [INFO] [stderr] | [INFO] [stderr] 78 | fn dft(x: &[f64], n_samples: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `white_noise` [INFO] [stderr] --> src/main.rs:120:1 [INFO] [stderr] | [INFO] [stderr] 120 | fn white_noise(n_samples: usize, amplitude: f64) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:23:43 [INFO] [stderr] | [INFO] [stderr] 23 | let samples = (1..window_len).map(|e| e as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let m = window_len as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(window_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `whole_block`. [INFO] [stderr] --> src/main.rs:200:18 [INFO] [stderr] | [INFO] [stderr] 200 | for i in block_size..(block_size*2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 200 | for in whole_block.iter().take((block_size*2)).skip(block_size) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:202:36 [INFO] [stderr] | [INFO] [stderr] 202 | self.hsync_sawtooth += (n_columns as f64) * line_freq_hz/Fs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(n_columns)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:203:36 [INFO] [stderr] | [INFO] [stderr] 203 | self.vsync_sawtooth += (n_lines as f64) * frame_freq_hz/Fs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(n_lines)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:207:38 [INFO] [stderr] | [INFO] [stderr] 207 | if self.hsync_sawtooth < n_columns as f64 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(n_columns)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:208:38 [INFO] [stderr] | [INFO] [stderr] 208 | self.vsync_sawtooth < n_lines as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(n_lines)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:53:43 [INFO] [stderr] | [INFO] [stderr] 53 | let samples = (1..filter_len).map(|e| e as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let m = filter_len as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(filter_len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | raster::save(&self.canvas, "test_render.png"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:242:21 [INFO] [stderr] | [INFO] [stderr] 242 | buffer.push(value as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `n` is used to index `x` [INFO] [stderr] --> src/main.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | for n in 0..(m-1) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 86 | for (n, ) in x.iter().enumerate().take((m-1)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `Fs` should have an upper case name such as `FS` [INFO] [stderr] --> src/main.rs:131:1 [INFO] [stderr] | [INFO] [stderr] 131 | const Fs: f64 = 20e6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant `nyquist` should have an upper case name such as `NYQUIST` [INFO] [stderr] --> src/main.rs:132:1 [INFO] [stderr] | [INFO] [stderr] 132 | const nyquist: f64 = Fs/2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `n_lines` should have an upper case name such as `N_LINES` [INFO] [stderr] --> src/main.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | const n_lines: i32 = 625; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `n_columns` should have an upper case name such as `N_COLUMNS` [INFO] [stderr] --> src/main.rs:134:1 [INFO] [stderr] | [INFO] [stderr] 134 | const n_columns: i32 = 700; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `line_freq_hz` should have an upper case name such as `LINE_FREQ_HZ` [INFO] [stderr] --> src/main.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135 | const line_freq_hz: f64 = 15.625e3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `frame_freq_hz` should have an upper case name such as `FRAME_FREQ_HZ` [INFO] [stderr] --> src/main.rs:136:1 [INFO] [stderr] | [INFO] [stderr] 136 | const frame_freq_hz: f64 = 50.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `whole_block`. [INFO] [stderr] --> src/main.rs:200:18 [INFO] [stderr] | [INFO] [stderr] 200 | for i in block_size..(block_size*2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 200 | for in whole_block.iter().take((block_size*2)).skip(block_size) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:202:36 [INFO] [stderr] | [INFO] [stderr] 202 | self.hsync_sawtooth += (n_columns as f64) * line_freq_hz/Fs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(n_columns)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:203:36 [INFO] [stderr] | [INFO] [stderr] 203 | self.vsync_sawtooth += (n_lines as f64) * frame_freq_hz/Fs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(n_lines)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:207:38 [INFO] [stderr] | [INFO] [stderr] 207 | if self.hsync_sawtooth < n_columns as f64 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(n_columns)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:208:38 [INFO] [stderr] | [INFO] [stderr] 208 | self.vsync_sawtooth < n_lines as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(n_lines)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | raster::save(&self.canvas, "test_render.png"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:242:21 [INFO] [stderr] | [INFO] [stderr] 242 | buffer.push(value as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.93s [INFO] running `"docker" "inspect" "2ac03dbb396e22c68f8d8aa733971c810a9695672952600a50faac1a03950196"` [INFO] running `"docker" "rm" "-f" "2ac03dbb396e22c68f8d8aa733971c810a9695672952600a50faac1a03950196"` [INFO] [stdout] 2ac03dbb396e22c68f8d8aa733971c810a9695672952600a50faac1a03950196