[INFO] updating cached repository schickling/beanstalkd-cli [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/schickling/beanstalkd-cli [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/schickling/beanstalkd-cli" "work/ex/clippy-test-run/sources/stable/gh/schickling/beanstalkd-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/schickling/beanstalkd-cli'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/schickling/beanstalkd-cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/schickling/beanstalkd-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/schickling/beanstalkd-cli'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 01ba42310e1d6441f4bdc19b45197f0e417d9a3b [INFO] sha for GitHub repo schickling/beanstalkd-cli: 01ba42310e1d6441f4bdc19b45197f0e417d9a3b [INFO] validating manifest of schickling/beanstalkd-cli on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of schickling/beanstalkd-cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing schickling/beanstalkd-cli [INFO] finished frobbing schickling/beanstalkd-cli [INFO] frobbed toml for schickling/beanstalkd-cli written to work/ex/clippy-test-run/sources/stable/gh/schickling/beanstalkd-cli/Cargo.toml [INFO] started frobbing schickling/beanstalkd-cli [INFO] finished frobbing schickling/beanstalkd-cli [INFO] frobbed toml for schickling/beanstalkd-cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/schickling/beanstalkd-cli/Cargo.toml [INFO] crate schickling/beanstalkd-cli has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting schickling/beanstalkd-cli against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/schickling/beanstalkd-cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a557a0e48ba0651e99be02474b186eb9e22541ec156927ee9aa36f71ce9a13d6 [INFO] running `"docker" "start" "-a" "a557a0e48ba0651e99be02474b186eb9e22541ec156927ee9aa36f71ce9a13d6"` [INFO] [stderr] Checking serde v1.0.50 [INFO] [stderr] Checking beanstalkd v0.4.1 [INFO] [stderr] Compiling syn v0.13.7 [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Compiling serde_derive v1.0.50 [INFO] [stderr] Checking docopt v1.0.0 [INFO] [stderr] Checking beanstalkd-cli v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/commands/monitor.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | stats.get(&key.to_string()).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&stats[&key.to_string()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/commands/stats.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | let value = stats.get(&key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&stats[&key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:57:26 [INFO] [stderr] | [INFO] [stderr] 57 | let mut beanstalkd = Beanstalkd::connect(&args.flag_host, args.flag_port) [INFO] [stderr] | __________________________^ [INFO] [stderr] 58 | | .ok() [INFO] [stderr] 59 | | .expect("Server not running"); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/commands/monitor.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | stats.get(&key.to_string()).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&stats[&key.to_string()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/commands/stats.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | let value = stats.get(&key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&stats[&key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:57:26 [INFO] [stderr] | [INFO] [stderr] 57 | let mut beanstalkd = Beanstalkd::connect(&args.flag_host, args.flag_port) [INFO] [stderr] | __________________________^ [INFO] [stderr] 58 | | .ok() [INFO] [stderr] 59 | | .expect("Server not running"); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.64s [INFO] running `"docker" "inspect" "a557a0e48ba0651e99be02474b186eb9e22541ec156927ee9aa36f71ce9a13d6"` [INFO] running `"docker" "rm" "-f" "a557a0e48ba0651e99be02474b186eb9e22541ec156927ee9aa36f71ce9a13d6"` [INFO] [stdout] a557a0e48ba0651e99be02474b186eb9e22541ec156927ee9aa36f71ce9a13d6