[INFO] updating cached repository schani-rs/schani_auth [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/schani-rs/schani_auth [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/schani-rs/schani_auth" "work/ex/clippy-test-run/sources/stable/gh/schani-rs/schani_auth"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/schani-rs/schani_auth'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/schani-rs/schani_auth" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/schani-rs/schani_auth"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/schani-rs/schani_auth'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bd76154c6dc97b710e4e7c71f3741f5603e1c4af [INFO] sha for GitHub repo schani-rs/schani_auth: bd76154c6dc97b710e4e7c71f3741f5603e1c4af [INFO] validating manifest of schani-rs/schani_auth on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of schani-rs/schani_auth on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing schani-rs/schani_auth [INFO] finished frobbing schani-rs/schani_auth [INFO] frobbed toml for schani-rs/schani_auth written to work/ex/clippy-test-run/sources/stable/gh/schani-rs/schani_auth/Cargo.toml [INFO] started frobbing schani-rs/schani_auth [INFO] finished frobbing schani-rs/schani_auth [INFO] frobbed toml for schani-rs/schani_auth written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/schani-rs/schani_auth/Cargo.toml [INFO] crate schani-rs/schani_auth has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting schani-rs/schani_auth against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/schani-rs/schani_auth:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 82e8e971be01982791b7661b1d5304f07182e7f39ee60b1ddc807e0d68ff4e9e [INFO] running `"docker" "start" "-a" "82e8e971be01982791b7661b1d5304f07182e7f39ee60b1ddc807e0d68ff4e9e"` [INFO] [stderr] Compiling either v1.4.0 [INFO] [stderr] Compiling scopeguard v0.3.3 [INFO] [stderr] Compiling libc v0.2.35 [INFO] [stderr] Compiling getopts v0.2.15 [INFO] [stderr] Compiling bitflags v0.5.0 [INFO] [stderr] Checking futures v0.1.20 [INFO] [stderr] Compiling matches v0.1.6 [INFO] [stderr] Compiling unicode-normalization v0.1.5 [INFO] [stderr] Checking serde v1.0.43 [INFO] [stderr] Checking rand v0.3.19 [INFO] [stderr] Checking base64 v0.4.2 [INFO] [stderr] Checking rmp v0.8.7 [INFO] [stderr] Compiling unicode-bidi v0.3.4 [INFO] [stderr] Checking fern v0.5.5 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Compiling quote v0.5.2 [INFO] [stderr] Compiling coco v0.1.1 [INFO] [stderr] Compiling pulldown-cmark v0.0.8 [INFO] [stderr] Compiling num_cpus v1.8.0 [INFO] [stderr] Checking mio v0.6.11 [INFO] [stderr] Compiling syn v0.13.1 [INFO] [stderr] Checking num v0.1.41 [INFO] [stderr] Compiling idna v0.1.4 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking tokio-io v0.1.4 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking relay v0.1.0 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling rayon-core v1.3.0 [INFO] [stderr] Compiling tempdir v0.3.5 [INFO] [stderr] Checking tokio-core v0.1.11 [INFO] [stderr] Compiling url v1.6.0 [INFO] [stderr] Compiling skeptic v0.9.0 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Compiling gotham_derive v0.1.0 [INFO] [stderr] Compiling borrow-bag v0.3.2 [INFO] [stderr] Compiling serde_derive_internals v0.23.1 [INFO] [stderr] Checking hyper v0.11.25 [INFO] [stderr] Checking serde_json v1.0.9 [INFO] [stderr] Checking rmp-serde v0.13.7 [INFO] [stderr] Compiling serde_derive v1.0.43 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking gotham v0.1.2 [INFO] [stderr] Checking jsonwebtoken v4.0.1 [INFO] [stderr] Checking schani_auth v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service/auth.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service/auth.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | password: password, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/web/middleware.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | ThreadPoolMiddleware { pool: pool } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/web/middleware.rs:51:36 [INFO] [stderr] | [INFO] [stderr] 51 | ThreadPoolMiddlewareData { pool: pool } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service/auth.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/service/auth.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | password: password, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/web/middleware.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | ThreadPoolMiddleware { pool: pool } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/web/middleware.rs:51:36 [INFO] [stderr] | [INFO] [stderr] 51 | ThreadPoolMiddlewareData { pool: pool } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `web::webservice::AuthService` [INFO] [stderr] --> src/web/webservice.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Self { [INFO] [stderr] 17 | | AuthService { [INFO] [stderr] 18 | | pool: CpuPool::new_num_cpus(), [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for web::webservice::AuthService { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `web::webservice::AuthService` [INFO] [stderr] --> src/web/webservice.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Self { [INFO] [stderr] 17 | | AuthService { [INFO] [stderr] 18 | | pool: CpuPool::new_num_cpus(), [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for web::webservice::AuthService { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 55.44s [INFO] running `"docker" "inspect" "82e8e971be01982791b7661b1d5304f07182e7f39ee60b1ddc807e0d68ff4e9e"` [INFO] running `"docker" "rm" "-f" "82e8e971be01982791b7661b1d5304f07182e7f39ee60b1ddc807e0d68ff4e9e"` [INFO] [stdout] 82e8e971be01982791b7661b1d5304f07182e7f39ee60b1ddc807e0d68ff4e9e