[INFO] updating cached repository schafer14/nn [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/schafer14/nn [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/schafer14/nn" "work/ex/clippy-test-run/sources/stable/gh/schafer14/nn"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/schafer14/nn'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/schafer14/nn" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/schafer14/nn"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/schafer14/nn'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f48062a6158b7a7a747028fb27d1965a02c62912 [INFO] sha for GitHub repo schafer14/nn: f48062a6158b7a7a747028fb27d1965a02c62912 [INFO] validating manifest of schafer14/nn on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of schafer14/nn on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing schafer14/nn [INFO] finished frobbing schafer14/nn [INFO] frobbed toml for schafer14/nn written to work/ex/clippy-test-run/sources/stable/gh/schafer14/nn/Cargo.toml [INFO] started frobbing schafer14/nn [INFO] finished frobbing schafer14/nn [INFO] frobbed toml for schafer14/nn written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/schafer14/nn/Cargo.toml [INFO] crate schafer14/nn has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting schafer14/nn against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/schafer14/nn:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a6821d0e080b30d7d0a4d2a7d4e3c60463a1833183b97351d6741e1197fec339 [INFO] running `"docker" "start" "-a" "a6821d0e080b30d7d0a4d2a7d4e3c60463a1833183b97351d6741e1197fec339"` [INFO] [stderr] Checking rand v0.3.14 [INFO] [stderr] Checking nn v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | Network { layers: layers } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:125:11 [INFO] [stderr] | [INFO] [stderr] 125 | Layer { neurons: neurons } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `neurons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:149:12 [INFO] [stderr] | [INFO] [stderr] 149 | Neuron { weights: weights, output: None, inputs: Vec::new() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | Network { layers: layers } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:125:11 [INFO] [stderr] | [INFO] [stderr] 125 | Layer { neurons: neurons } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `neurons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:149:12 [INFO] [stderr] | [INFO] [stderr] 149 | Neuron { weights: weights, output: None, inputs: Vec::new() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `weights` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:34:37 [INFO] [stderr] | [INFO] [stderr] 34 | fn feed_forward(&mut self, inputs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:41:8 [INFO] [stderr] | [INFO] [stderr] 41 | let ref mut layer: Layer = self.layers[i]; [INFO] [stderr] | ----^^^^^^^^^^^^^------------------------- help: try: `let layer: &mut Layer = &mut self.layers[i];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:50:36 [INFO] [stderr] | [INFO] [stderr] 50 | fn total_error(&mut self, inputs: &Vec, actual: &Vec) -> f64{ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:50:55 [INFO] [stderr] | [INFO] [stderr] 50 | fn total_error(&mut self, inputs: &Vec, actual: &Vec) -> f64{ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:58:48 [INFO] [stderr] | [INFO] [stderr] 58 | fn online_back_propogation(&mut self, inputs: &Vec, actual: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:58:67 [INFO] [stderr] | [INFO] [stderr] 58 | fn online_back_propogation(&mut self, inputs: &Vec, actual: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `actual` [INFO] [stderr] --> src/main.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | for i in 0..self.layers[index_of_last_layer].neurons.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 66 | for (i, ) in actual.iter().enumerate().take(self.layers[index_of_last_layer].neurons.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:67:8 [INFO] [stderr] | [INFO] [stderr] 67 | let ref neuron: Neuron = self.layers[index_of_last_layer].neurons[i]; [INFO] [stderr] | ----^^^^^^^^^^------------------------------------------------------- help: try: `let neuron: &Neuron = &self.layers[index_of_last_layer].neurons[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:68:8 [INFO] [stderr] | [INFO] [stderr] 68 | let ref output: f64 = neuron.output.expect("Neuron has no outputted value"); [INFO] [stderr] | ----^^^^^^^^^^-------------------------------------------------------------- help: try: `let output: &f64 = &neuron.output.expect("Neuron has no outputted value");` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | let ref d_error_wrt_input_prev = d_errors_wrt_input[0]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------- help: try: `let d_error_wrt_input_prev = &d_errors_wrt_input[0];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | let ref neuron: Neuron = self.layers[index_of_layer].neurons[i]; [INFO] [stderr] | ----^^^^^^^^^^-------------------------------------------------- help: try: `let neuron: &Neuron = &self.layers[index_of_layer].neurons[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | let ref output: f64 = neuron.output.expect("Neuron has no outputted value"); [INFO] [stderr] | ----^^^^^^^^^^-------------------------------------------------------------- help: try: `let output: &f64 = &neuron.output.expect("Neuron has no outputted value");` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `d_error_wrt_input_prev` [INFO] [stderr] --> src/main.rs:88:14 [INFO] [stderr] | [INFO] [stderr] 88 | for j in 0..self.layers[index_of_layer + 1].neurons.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 88 | for (j, ) in d_error_wrt_input_prev.iter().enumerate().take(self.layers[index_of_layer + 1].neurons.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:89:10 [INFO] [stderr] | [INFO] [stderr] 89 | let ref weight: f64 = self.layers[index_of_layer + 1].neurons[j].weights[i]; [INFO] [stderr] | ----^^^^^^^^^^-------------------------------------------------------------- help: try: `let weight: &f64 = &self.layers[index_of_layer + 1].neurons[j].weights[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:90:6 [INFO] [stderr] | [INFO] [stderr] 90 | d_error_wrt_output = d_error_wrt_output + d_error_wrt_input_prev[j] * weight; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `d_error_wrt_output += d_error_wrt_input_prev[j] * weight` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l` is used to index `d_errors_wrt_input` [INFO] [stderr] --> src/main.rs:101:12 [INFO] [stderr] | [INFO] [stderr] 101 | for l in 0..self.layers.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 101 | for (l, ) in d_errors_wrt_input.iter().enumerate().take(self.layers.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | let ref mut neuron: Neuron = self.layers[l].neurons[i]; [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------------------- help: try: `let neuron: &mut Neuron = &mut self.layers[l].neurons[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:108:6 [INFO] [stderr] | [INFO] [stderr] 108 | neuron.weights[j] = neuron.weights[j] - LEARNING_RATE * d_error_wrt_weight; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `neuron.weights[j] -= LEARNING_RATE * d_error_wrt_weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:128:29 [INFO] [stderr] | [INFO] [stderr] 128 | fn calc(&mut self, inputs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:132:8 [INFO] [stderr] | [INFO] [stderr] 132 | let ref mut neuron: Neuron = self.neurons[i]; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------------------- help: try: `let neuron: &mut Neuron = &mut self.neurons[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:152:29 [INFO] [stderr] | [INFO] [stderr] 152 | fn calc(&mut self, inputs: &Vec) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:34:37 [INFO] [stderr] | [INFO] [stderr] 34 | fn feed_forward(&mut self, inputs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:41:8 [INFO] [stderr] | [INFO] [stderr] 41 | let ref mut layer: Layer = self.layers[i]; [INFO] [stderr] | ----^^^^^^^^^^^^^------------------------- help: try: `let layer: &mut Layer = &mut self.layers[i];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:50:36 [INFO] [stderr] | [INFO] [stderr] 50 | fn total_error(&mut self, inputs: &Vec, actual: &Vec) -> f64{ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:50:55 [INFO] [stderr] | [INFO] [stderr] 50 | fn total_error(&mut self, inputs: &Vec, actual: &Vec) -> f64{ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:58:48 [INFO] [stderr] | [INFO] [stderr] 58 | fn online_back_propogation(&mut self, inputs: &Vec, actual: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:58:67 [INFO] [stderr] | [INFO] [stderr] 58 | fn online_back_propogation(&mut self, inputs: &Vec, actual: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `actual` [INFO] [stderr] --> src/main.rs:66:12 [INFO] [stderr] | [INFO] [stderr] 66 | for i in 0..self.layers[index_of_last_layer].neurons.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 66 | for (i, ) in actual.iter().enumerate().take(self.layers[index_of_last_layer].neurons.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:67:8 [INFO] [stderr] | [INFO] [stderr] 67 | let ref neuron: Neuron = self.layers[index_of_last_layer].neurons[i]; [INFO] [stderr] | ----^^^^^^^^^^------------------------------------------------------- help: try: `let neuron: &Neuron = &self.layers[index_of_last_layer].neurons[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:68:8 [INFO] [stderr] | [INFO] [stderr] 68 | let ref output: f64 = neuron.output.expect("Neuron has no outputted value"); [INFO] [stderr] | ----^^^^^^^^^^-------------------------------------------------------------- help: try: `let output: &f64 = &neuron.output.expect("Neuron has no outputted value");` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | let ref d_error_wrt_input_prev = d_errors_wrt_input[0]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------- help: try: `let d_error_wrt_input_prev = &d_errors_wrt_input[0];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | let ref neuron: Neuron = self.layers[index_of_layer].neurons[i]; [INFO] [stderr] | ----^^^^^^^^^^-------------------------------------------------- help: try: `let neuron: &Neuron = &self.layers[index_of_layer].neurons[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | let ref output: f64 = neuron.output.expect("Neuron has no outputted value"); [INFO] [stderr] | ----^^^^^^^^^^-------------------------------------------------------------- help: try: `let output: &f64 = &neuron.output.expect("Neuron has no outputted value");` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `d_error_wrt_input_prev` [INFO] [stderr] --> src/main.rs:88:14 [INFO] [stderr] | [INFO] [stderr] 88 | for j in 0..self.layers[index_of_layer + 1].neurons.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 88 | for (j, ) in d_error_wrt_input_prev.iter().enumerate().take(self.layers[index_of_layer + 1].neurons.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:89:10 [INFO] [stderr] | [INFO] [stderr] 89 | let ref weight: f64 = self.layers[index_of_layer + 1].neurons[j].weights[i]; [INFO] [stderr] | ----^^^^^^^^^^-------------------------------------------------------------- help: try: `let weight: &f64 = &self.layers[index_of_layer + 1].neurons[j].weights[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:90:6 [INFO] [stderr] | [INFO] [stderr] 90 | d_error_wrt_output = d_error_wrt_output + d_error_wrt_input_prev[j] * weight; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `d_error_wrt_output += d_error_wrt_input_prev[j] * weight` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l` is used to index `d_errors_wrt_input` [INFO] [stderr] --> src/main.rs:101:12 [INFO] [stderr] | [INFO] [stderr] 101 | for l in 0..self.layers.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 101 | for (l, ) in d_errors_wrt_input.iter().enumerate().take(self.layers.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | let ref mut neuron: Neuron = self.layers[l].neurons[i]; [INFO] [stderr] | ----^^^^^^^^^^^^^^------------------------------------- help: try: `let neuron: &mut Neuron = &mut self.layers[l].neurons[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:108:6 [INFO] [stderr] | [INFO] [stderr] 108 | neuron.weights[j] = neuron.weights[j] - LEARNING_RATE * d_error_wrt_weight; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `neuron.weights[j] -= LEARNING_RATE * d_error_wrt_weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:128:29 [INFO] [stderr] | [INFO] [stderr] 128 | fn calc(&mut self, inputs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:132:8 [INFO] [stderr] | [INFO] [stderr] 132 | let ref mut neuron: Neuron = self.neurons[i]; [INFO] [stderr] | ----^^^^^^^^^^^^^^--------------------------- help: try: `let neuron: &mut Neuron = &mut self.neurons[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:152:29 [INFO] [stderr] | [INFO] [stderr] 152 | fn calc(&mut self, inputs: &Vec) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.61s [INFO] running `"docker" "inspect" "a6821d0e080b30d7d0a4d2a7d4e3c60463a1833183b97351d6741e1197fec339"` [INFO] running `"docker" "rm" "-f" "a6821d0e080b30d7d0a4d2a7d4e3c60463a1833183b97351d6741e1197fec339"` [INFO] [stdout] a6821d0e080b30d7d0a4d2a7d4e3c60463a1833183b97351d6741e1197fec339