[INFO] updating cached repository scan/prometheus-redis-exporter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/scan/prometheus-redis-exporter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/scan/prometheus-redis-exporter" "work/ex/clippy-test-run/sources/stable/gh/scan/prometheus-redis-exporter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/scan/prometheus-redis-exporter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/scan/prometheus-redis-exporter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scan/prometheus-redis-exporter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scan/prometheus-redis-exporter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 53556190366dda3ae9d393e8e4b6029cdd1b539a [INFO] sha for GitHub repo scan/prometheus-redis-exporter: 53556190366dda3ae9d393e8e4b6029cdd1b539a [INFO] validating manifest of scan/prometheus-redis-exporter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scan/prometheus-redis-exporter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scan/prometheus-redis-exporter [INFO] finished frobbing scan/prometheus-redis-exporter [INFO] frobbed toml for scan/prometheus-redis-exporter written to work/ex/clippy-test-run/sources/stable/gh/scan/prometheus-redis-exporter/Cargo.toml [INFO] started frobbing scan/prometheus-redis-exporter [INFO] finished frobbing scan/prometheus-redis-exporter [INFO] frobbed toml for scan/prometheus-redis-exporter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scan/prometheus-redis-exporter/Cargo.toml [INFO] crate scan/prometheus-redis-exporter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scan/prometheus-redis-exporter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/scan/prometheus-redis-exporter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5a1e032738a190ac5520e8b1ac39d5f7315ef5772540ef163b97604c179e203a [INFO] running `"docker" "start" "-a" "5a1e032738a190ac5520e8b1ac39d5f7315ef5772540ef163b97604c179e203a"` [INFO] [stderr] Checking quick-error v0.2.2 [INFO] [stderr] Checking protobuf v1.2.2 [INFO] [stderr] Checking error v0.1.9 [INFO] [stderr] Checking redis v0.8.0 [INFO] [stderr] Checking hyper v0.10.12 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking prometheus v0.2.8 [INFO] [stderr] Checking prometheus-redis-exporter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prom.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / return match encoder.encode(&metric_familys, &mut buffer).err() { [INFO] [stderr] 11 | | Some(e) => e.description().to_owned(), [INFO] [stderr] 12 | | _ => String::from_utf8(buffer).unwrap_or("".to_owned()), [INFO] [stderr] 13 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 10 | match encoder.encode(&metric_familys, &mut buffer).err() { [INFO] [stderr] 11 | Some(e) => e.description().to_owned(), [INFO] [stderr] 12 | _ => String::from_utf8(buffer).unwrap_or("".to_owned()), [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prom.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / return match encoder.encode(&metric_familys, &mut buffer).err() { [INFO] [stderr] 11 | | Some(e) => e.description().to_owned(), [INFO] [stderr] 12 | | _ => String::from_utf8(buffer).unwrap_or("".to_owned()), [INFO] [stderr] 13 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 10 | match encoder.encode(&metric_familys, &mut buffer).err() { [INFO] [stderr] 11 | Some(e) => e.description().to_owned(), [INFO] [stderr] 12 | _ => String::from_utf8(buffer).unwrap_or("".to_owned()), [INFO] [stderr] 13 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/redis_client.rs:5:53 [INFO] [stderr] | [INFO] [stderr] 5 | let redis_host: String = env::var("REDIS_HOST").unwrap_or(String::from("localhost")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("localhost"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/redis_client.rs:6:53 [INFO] [stderr] | [INFO] [stderr] 6 | let redis_port: String = env::var("REDIS_PORT").unwrap_or(String::from("6379")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("6379"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/redis_client.rs:7:34 [INFO] [stderr] | [INFO] [stderr] 7 | let redis_password: String = env::var("REDIS_PASSWORD").unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var("REDIS_PASSWORD").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/prom.rs:12:47 [INFO] [stderr] | [INFO] [stderr] 12 | _ => String::from_utf8(buffer).unwrap_or("".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/prom.rs:17:35 [INFO] [stderr] | [INFO] [stderr] 17 | env::var("PROMETHEUS_PREFIX").unwrap_or(String::from("redis")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("redis"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/metrics.rs:42:27 [INFO] [stderr] | [INFO] [stderr] 42 | let val: String = info.get(redis_name).unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `info.get(redis_name).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:16:49 [INFO] [stderr] | [INFO] [stderr] 16 | let app_port: String = env::var("APP_PORT").unwrap_or("9121".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "9121".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/redis_client.rs:5:53 [INFO] [stderr] | [INFO] [stderr] 5 | let redis_host: String = env::var("REDIS_HOST").unwrap_or(String::from("localhost")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("localhost"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/redis_client.rs:6:53 [INFO] [stderr] | [INFO] [stderr] 6 | let redis_port: String = env::var("REDIS_PORT").unwrap_or(String::from("6379")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("6379"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/redis_client.rs:7:34 [INFO] [stderr] | [INFO] [stderr] 7 | let redis_password: String = env::var("REDIS_PASSWORD").unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var("REDIS_PASSWORD").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/prom.rs:12:47 [INFO] [stderr] | [INFO] [stderr] 12 | _ => String::from_utf8(buffer).unwrap_or("".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/prom.rs:17:35 [INFO] [stderr] | [INFO] [stderr] 17 | env::var("PROMETHEUS_PREFIX").unwrap_or(String::from("redis")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("redis"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/metrics.rs:42:27 [INFO] [stderr] | [INFO] [stderr] 42 | let val: String = info.get(redis_name).unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `info.get(redis_name).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:16:49 [INFO] [stderr] | [INFO] [stderr] 16 | let app_port: String = env::var("APP_PORT").unwrap_or("9121".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "9121".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.78s [INFO] running `"docker" "inspect" "5a1e032738a190ac5520e8b1ac39d5f7315ef5772540ef163b97604c179e203a"` [INFO] running `"docker" "rm" "-f" "5a1e032738a190ac5520e8b1ac39d5f7315ef5772540ef163b97604c179e203a"` [INFO] [stdout] 5a1e032738a190ac5520e8b1ac39d5f7315ef5772540ef163b97604c179e203a