[INFO] updating cached repository sbwtw/dpg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sbwtw/dpg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sbwtw/dpg" "work/ex/clippy-test-run/sources/stable/gh/sbwtw/dpg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sbwtw/dpg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sbwtw/dpg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sbwtw/dpg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sbwtw/dpg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c9dc5a84f549fd4f69842693be6e3391c375f3fd [INFO] sha for GitHub repo sbwtw/dpg: c9dc5a84f549fd4f69842693be6e3391c375f3fd [INFO] validating manifest of sbwtw/dpg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sbwtw/dpg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sbwtw/dpg [INFO] finished frobbing sbwtw/dpg [INFO] frobbed toml for sbwtw/dpg written to work/ex/clippy-test-run/sources/stable/gh/sbwtw/dpg/Cargo.toml [INFO] started frobbing sbwtw/dpg [INFO] finished frobbing sbwtw/dpg [INFO] frobbed toml for sbwtw/dpg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sbwtw/dpg/Cargo.toml [INFO] crate sbwtw/dpg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sbwtw/dpg against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sbwtw/dpg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1db6a8b05d7dd97c900cba5b6a36a34c38bd348d4ed8e6729ee0598fb3cc113a [INFO] running `"docker" "start" "-a" "1db6a8b05d7dd97c900cba5b6a36a34c38bd348d4ed8e6729ee0598fb3cc113a"` [INFO] [stderr] Checking dpg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | profile [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | let profile = Profile { [INFO] [stderr] | _______________________^ [INFO] [stderr] 19 | | public_dns_list: Vec::new(), [INFO] [stderr] 20 | | spec_dns_list: Vec::new(), [INFO] [stderr] 21 | | spec_hosts: Vec::new(), [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:143:20 [INFO] [stderr] | [INFO] [stderr] 143 | let home_dir = std::env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | profile [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | let profile = Profile { [INFO] [stderr] | _______________________^ [INFO] [stderr] 19 | | public_dns_list: Vec::new(), [INFO] [stderr] 20 | | spec_dns_list: Vec::new(), [INFO] [stderr] 21 | | spec_hosts: Vec::new(), [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:143:20 [INFO] [stderr] | [INFO] [stderr] 143 | let home_dir = std::env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.29s [INFO] running `"docker" "inspect" "1db6a8b05d7dd97c900cba5b6a36a34c38bd348d4ed8e6729ee0598fb3cc113a"` [INFO] running `"docker" "rm" "-f" "1db6a8b05d7dd97c900cba5b6a36a34c38bd348d4ed8e6729ee0598fb3cc113a"` [INFO] [stdout] 1db6a8b05d7dd97c900cba5b6a36a34c38bd348d4ed8e6729ee0598fb3cc113a