[INFO] updating cached repository sbwtw/cr_robot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sbwtw/cr_robot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sbwtw/cr_robot" "work/ex/clippy-test-run/sources/stable/gh/sbwtw/cr_robot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sbwtw/cr_robot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sbwtw/cr_robot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sbwtw/cr_robot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sbwtw/cr_robot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ae1365ceb92356399fce3ca9cd657fa79105bcde [INFO] sha for GitHub repo sbwtw/cr_robot: ae1365ceb92356399fce3ca9cd657fa79105bcde [INFO] validating manifest of sbwtw/cr_robot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sbwtw/cr_robot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sbwtw/cr_robot [INFO] finished frobbing sbwtw/cr_robot [INFO] frobbed toml for sbwtw/cr_robot written to work/ex/clippy-test-run/sources/stable/gh/sbwtw/cr_robot/Cargo.toml [INFO] started frobbing sbwtw/cr_robot [INFO] finished frobbing sbwtw/cr_robot [INFO] frobbed toml for sbwtw/cr_robot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sbwtw/cr_robot/Cargo.toml [INFO] crate sbwtw/cr_robot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sbwtw/cr_robot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sbwtw/cr_robot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6254cc769dbc18a55c5b1f17603901f0b5f202174ff6bcf74d5c0ff9798c2eb3 [INFO] running `"docker" "start" "-a" "6254cc769dbc18a55c5b1f17603901f0b5f202174ff6bcf74d5c0ff9798c2eb3"` [INFO] [stderr] Checking libc v0.2.27 [INFO] [stderr] Compiling openssl v0.9.15 [INFO] [stderr] Checking serde v1.0.10 [INFO] [stderr] Compiling openssl-sys v0.9.15 [INFO] [stderr] Checking libflate v0.1.10 [INFO] [stderr] Checking mime v0.3.2 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking net2 v0.2.30 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking bytes v0.4.4 [INFO] [stderr] Checking futures-cpupool v0.1.5 [INFO] [stderr] Checking textwrap v0.6.0 [INFO] [stderr] Checking mio v0.6.9 [INFO] [stderr] Checking clap v2.25.1 [INFO] [stderr] Checking tokio-io v0.1.2 [INFO] [stderr] Checking tokio-core v0.1.8 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking hyper v0.11.1 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking reqwest v0.7.1 [INFO] [stderr] Checking cr_robot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_item/data_item.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | created: created, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `created` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/data_item/data_item.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | created: created, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `created` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/data_item/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod data_item; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/data_item/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | mod data_item; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / let sub_days; [INFO] [stderr] 41 | | if current_time.tm_wday == 0 { [INFO] [stderr] 42 | | sub_days = 6; [INFO] [stderr] 43 | | } else { [INFO] [stderr] 44 | | sub_days = current_time.tm_wday - 1; [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let sub_days = if current_time.tm_wday == 0 { 6 } else { current_time.tm_wday - 1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:47:41 [INFO] [stderr] | [INFO] [stderr] 47 | let duration = time::Duration::days(sub_days as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(sub_days)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner` [INFO] [stderr] --> src/main.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / 'inner: for item in array { [INFO] [stderr] 149 | | let di: DataItem = DataItem::new(item); [INFO] [stderr] 150 | | [INFO] [stderr] 151 | | if di.created >= begin_date { [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / let sub_days; [INFO] [stderr] 41 | | if current_time.tm_wday == 0 { [INFO] [stderr] 42 | | sub_days = 6; [INFO] [stderr] 43 | | } else { [INFO] [stderr] 44 | | sub_days = current_time.tm_wday - 1; [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let sub_days = if current_time.tm_wday == 0 { 6 } else { current_time.tm_wday - 1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:47:41 [INFO] [stderr] | [INFO] [stderr] 47 | let duration = time::Duration::days(sub_days as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(sub_days)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner` [INFO] [stderr] --> src/main.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / 'inner: for item in array { [INFO] [stderr] 149 | | let di: DataItem = DataItem::new(item); [INFO] [stderr] 150 | | [INFO] [stderr] 151 | | if di.created >= begin_date { [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.87s [INFO] running `"docker" "inspect" "6254cc769dbc18a55c5b1f17603901f0b5f202174ff6bcf74d5c0ff9798c2eb3"` [INFO] running `"docker" "rm" "-f" "6254cc769dbc18a55c5b1f17603901f0b5f202174ff6bcf74d5c0ff9798c2eb3"` [INFO] [stdout] 6254cc769dbc18a55c5b1f17603901f0b5f202174ff6bcf74d5c0ff9798c2eb3