[INFO] updating cached repository sashaweiss/itree
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/sashaweiss/itree
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/sashaweiss/itree" "work/ex/clippy-test-run/sources/stable/gh/sashaweiss/itree"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sashaweiss/itree'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/sashaweiss/itree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sashaweiss/itree"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sashaweiss/itree'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 4bea57f0cf4d6fceb5d5939dda1d17be0ca68391
[INFO] sha for GitHub repo sashaweiss/itree: 4bea57f0cf4d6fceb5d5939dda1d17be0ca68391
[INFO] validating manifest of sashaweiss/itree on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sashaweiss/itree on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sashaweiss/itree
[INFO] finished frobbing sashaweiss/itree
[INFO] frobbed toml for sashaweiss/itree written to work/ex/clippy-test-run/sources/stable/gh/sashaweiss/itree/Cargo.toml
[INFO] started frobbing sashaweiss/itree
[INFO] finished frobbing sashaweiss/itree
[INFO] frobbed toml for sashaweiss/itree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sashaweiss/itree/Cargo.toml
[INFO] crate sashaweiss/itree has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sashaweiss/itree against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sashaweiss/itree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 04719268df4c56e6b5b897d42f4ebb8d6ba1f5fbd03237a6867e5c5e04bc5354
[INFO] running `"docker" "start" "-a" "04719268df4c56e6b5b897d42f4ebb8d6ba1f5fbd03237a6867e5c5e04bc5354"`
[INFO] [stderr]     Checking same-file v1.0.2
[INFO] [stderr]     Checking indextree v1.1.1
[INFO] [stderr]     Checking clap v2.31.2
[INFO] [stderr]     Checking globset v0.4.0
[INFO] [stderr]     Checking walkdir v2.1.4
[INFO] [stderr]     Checking ignore v0.4.2
[INFO] [stderr]     Checking itree v0.3.1 (/opt/crater/workdir)
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/fs.rs:99:28
[INFO] [stderr]    |
[INFO] [stderr] 99 |             if d.ends_with("/") {
[INFO] [stderr]    |                            ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]    --> src/fs.rs:235:13
[INFO] [stderr]     |
[INFO] [stderr] 235 |             Err(_) => {
[INFO] [stderr]     |             ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]     = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `options::RenderOptions`
[INFO] [stderr]   --> src/options.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     pub fn new() -> Self {
[INFO] [stderr] 20 | |         Self {
[INFO] [stderr] 21 | |             fg_color: Box::new(color::White),
[INFO] [stderr] 22 | |             bg_color: Box::new(color::Blue),
[INFO] [stderr] 23 | |         }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 18 | impl Default for options::RenderOptions {
[INFO] [stderr] 19 |     fn default() -> Self {
[INFO] [stderr] 20 |         Self::new()
[INFO] [stderr] 21 |     }
[INFO] [stderr] 22 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/render.rs:74:37
[INFO] [stderr]    |
[INFO] [stderr] 74 |     fn prefix_string(&self, prefix: &Vec<PrefixPiece>) -> String {
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^ help: change this to: `&[PrefixPiece]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/render.rs:181:20
[INFO] [stderr]     |
[INFO] [stderr] 181 |               if let Some(_) = self.tree.lines.lines.get(next) {
[INFO] [stderr]     |  _____________-      ^^^^^^^
[INFO] [stderr] 182 | |                 i += self.visual_lines_for_line(end, width);
[INFO] [stderr] 183 | |                 end = next;
[INFO] [stderr] 184 | |             } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 187 | |                 break;
[INFO] [stderr] 188 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if self.tree.lines.lines.get(next).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `tree::Tree`
[INFO] [stderr]   --> src/tree.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 | /     pub fn new() -> Self {
[INFO] [stderr] 73 | |         Tree::new_with_options(FsOptions::new("."))
[INFO] [stderr] 74 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 70 | impl Default for tree::Tree {
[INFO] [stderr] 71 |     fn default() -> Self {
[INFO] [stderr] 72 |         Self::new()
[INFO] [stderr] 73 |     }
[INFO] [stderr] 74 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/fs.rs:99:28
[INFO] [stderr]    |
[INFO] [stderr] 99 |             if d.ends_with("/") {
[INFO] [stderr]    |                            ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]    --> src/fs.rs:235:13
[INFO] [stderr]     |
[INFO] [stderr] 235 |             Err(_) => {
[INFO] [stderr]     |             ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]     = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/fs.rs:322:24
[INFO] [stderr]     |
[INFO] [stderr] 322 |           let dir_node = root.children(&tree)
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 323 | |             .filter(|nid| tree[*nid].data.name.as_str() == "mydir")
[INFO] [stderr] 324 | |             .next()
[INFO] [stderr]     | |___________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(|nid| tree[*nid].data.name.as_str() == "mydir").next()` with `find(|nid| tree[*nid].data.name.as_str() == "mydir")`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `options::RenderOptions`
[INFO] [stderr]   --> src/options.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 | /     pub fn new() -> Self {
[INFO] [stderr] 20 | |         Self {
[INFO] [stderr] 21 | |             fg_color: Box::new(color::White),
[INFO] [stderr] 22 | |             bg_color: Box::new(color::Blue),
[INFO] [stderr] 23 | |         }
[INFO] [stderr] 24 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 18 | impl Default for options::RenderOptions {
[INFO] [stderr] 19 |     fn default() -> Self {
[INFO] [stderr] 20 |         Self::new()
[INFO] [stderr] 21 |     }
[INFO] [stderr] 22 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/render.rs:74:37
[INFO] [stderr]    |
[INFO] [stderr] 74 |     fn prefix_string(&self, prefix: &Vec<PrefixPiece>) -> String {
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^ help: change this to: `&[PrefixPiece]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/render.rs:181:20
[INFO] [stderr]     |
[INFO] [stderr] 181 |               if let Some(_) = self.tree.lines.lines.get(next) {
[INFO] [stderr]     |  _____________-      ^^^^^^^
[INFO] [stderr] 182 | |                 i += self.visual_lines_for_line(end, width);
[INFO] [stderr] 183 | |                 end = next;
[INFO] [stderr] 184 | |             } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 187 | |                 break;
[INFO] [stderr] 188 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if self.tree.lines.lines.get(next).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `tree::Tree`
[INFO] [stderr]   --> src/tree.rs:72:5
[INFO] [stderr]    |
[INFO] [stderr] 72 | /     pub fn new() -> Self {
[INFO] [stderr] 73 | |         Tree::new_with_options(FsOptions::new("."))
[INFO] [stderr] 74 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 70 | impl Default for tree::Tree {
[INFO] [stderr] 71 |     fn default() -> Self {
[INFO] [stderr] 72 |         Self::new()
[INFO] [stderr] 73 |     }
[INFO] [stderr] 74 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/tree.rs:103:5
[INFO] [stderr]     |
[INFO] [stderr] 103 | /     pub fn focused<'a>(&'a self) -> &'a FsEntry {
[INFO] [stderr] 104 | |         &self.tree[self.focused].data
[INFO] [stderr] 105 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/main.rs:39:16
[INFO] [stderr]    |
[INFO] [stderr] 39 |           if let Err(_) = rx.recv_timeout(Duration::from_millis(300)) {
[INFO] [stderr]    |  _________-      ^^^^^^
[INFO] [stderr] 40 | |             let mut stderr = io::stderr();
[INFO] [stderr] 41 | |
[INFO] [stderr] 42 | |             write!(stderr, "Building tree").unwrap();
[INFO] [stderr] ...  |
[INFO] [stderr] 52 | |             writeln!(stderr, "done!").unwrap();
[INFO] [stderr] 53 | |         }
[INFO] [stderr]    | |_________- help: try this: `if rx.recv_timeout(Duration::from_millis(300)).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> src/main.rs:46:24
[INFO] [stderr]    |
[INFO] [stderr] 46 |                   if let Ok(_) = rx.recv_timeout(Duration::from_millis(1000)) {
[INFO] [stderr]    |  _________________-      ^^^^^
[INFO] [stderr] 47 | |                     break;
[INFO] [stderr] 48 | |                 }
[INFO] [stderr]    | |_________________- help: try this: `if rx.recv_timeout(Duration::from_millis(1000)).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/main.rs:39:16
[INFO] [stderr]    |
[INFO] [stderr] 39 |           if let Err(_) = rx.recv_timeout(Duration::from_millis(300)) {
[INFO] [stderr]    |  _________-      ^^^^^^
[INFO] [stderr] 40 | |             let mut stderr = io::stderr();
[INFO] [stderr] 41 | |
[INFO] [stderr] 42 | |             write!(stderr, "Building tree").unwrap();
[INFO] [stderr] ...  |
[INFO] [stderr] 52 | |             writeln!(stderr, "done!").unwrap();
[INFO] [stderr] 53 | |         }
[INFO] [stderr]    | |_________- help: try this: `if rx.recv_timeout(Duration::from_millis(300)).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> src/main.rs:46:24
[INFO] [stderr]    |
[INFO] [stderr] 46 |                   if let Ok(_) = rx.recv_timeout(Duration::from_millis(1000)) {
[INFO] [stderr]    |  _________________-      ^^^^^
[INFO] [stderr] 47 | |                     break;
[INFO] [stderr] 48 | |                 }
[INFO] [stderr]    | |_________________- help: try this: `if rx.recv_timeout(Duration::from_millis(1000)).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.73s
[INFO] running `"docker" "inspect" "04719268df4c56e6b5b897d42f4ebb8d6ba1f5fbd03237a6867e5c5e04bc5354"`
[INFO] running `"docker" "rm" "-f" "04719268df4c56e6b5b897d42f4ebb8d6ba1f5fbd03237a6867e5c5e04bc5354"`
[INFO] [stdout] 04719268df4c56e6b5b897d42f4ebb8d6ba1f5fbd03237a6867e5c5e04bc5354