[INFO] updating cached repository saschagrunert/git-journal [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/saschagrunert/git-journal [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/saschagrunert/git-journal" "work/ex/clippy-test-run/sources/stable/gh/saschagrunert/git-journal"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/saschagrunert/git-journal'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/saschagrunert/git-journal" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saschagrunert/git-journal"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saschagrunert/git-journal'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e79add6e446dde3ec24a43b62536eb4afd3d21ed [INFO] sha for GitHub repo saschagrunert/git-journal: e79add6e446dde3ec24a43b62536eb4afd3d21ed [INFO] validating manifest of saschagrunert/git-journal on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of saschagrunert/git-journal on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing saschagrunert/git-journal [INFO] finished frobbing saschagrunert/git-journal [INFO] frobbed toml for saschagrunert/git-journal written to work/ex/clippy-test-run/sources/stable/gh/saschagrunert/git-journal/Cargo.toml [INFO] started frobbing saschagrunert/git-journal [INFO] finished frobbing saschagrunert/git-journal [INFO] frobbed toml for saschagrunert/git-journal written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saschagrunert/git-journal/Cargo.toml [INFO] crate saschagrunert/git-journal has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting saschagrunert/git-journal against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/saschagrunert/git-journal:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1ebcf2d5088348febd5e3a31a92d830ebbcab31d915f7c314aa2e622eadbbc7e [INFO] running `"docker" "start" "-a" "1ebcf2d5088348febd5e3a31a92d830ebbcab31d915f7c314aa2e622eadbbc7e"` [INFO] [stderr] Compiling cc v1.0.5 [INFO] [stderr] Checking num-traits v0.2.1 [INFO] [stderr] Checking log v0.4.3 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Compiling rayon v1.0.2 [INFO] [stderr] Checking url v1.7.0 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Compiling serde_derive v1.0.71 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking regex v1.0.2 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Compiling openssl-sys v0.9.27 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling cmake v0.1.29 [INFO] [stderr] Compiling curl-sys v0.4.8 [INFO] [stderr] Checking num-integer v0.1.36 [INFO] [stderr] Compiling libssh2-sys v0.2.8 [INFO] [stderr] Compiling libgit2-sys v0.7.7 [INFO] [stderr] Checking chrono v0.4.5 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking mowl v2.0.0 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking git-journal v1.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `writeln!(term, "")` [INFO] [stderr] --> src/parser.rs:243:17 [INFO] [stderr] | [INFO] [stderr] 243 | writeln!(term, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(vec, "")` [INFO] [stderr] --> src/parser.rs:244:17 [INFO] [stderr] | [INFO] [stderr] 244 | writeln!(vec, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(vec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] warning: using `writeln!(term, "")` [INFO] [stderr] --> src/parser.rs:243:17 [INFO] [stderr] | [INFO] [stderr] 243 | writeln!(term, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(vec, "")` [INFO] [stderr] --> src/parser.rs:244:17 [INFO] [stderr] | [INFO] [stderr] 244 | writeln!(vec, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(vec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(term, "")` [INFO] [stderr] --> src/parser.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | writeln!(term, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(vec, "")` [INFO] [stderr] --> src/parser.rs:326:13 [INFO] [stderr] | [INFO] [stderr] 326 | writeln!(vec, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(vec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(term, "")` [INFO] [stderr] --> src/parser.rs:964:9 [INFO] [stderr] | [INFO] [stderr] 964 | writeln!(term, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(term, "")` [INFO] [stderr] --> src/parser.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | writeln!(term, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(vec, "")` [INFO] [stderr] --> src/parser.rs:326:13 [INFO] [stderr] | [INFO] [stderr] 326 | writeln!(vec, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(vec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(term, "")` [INFO] [stderr] --> src/parser.rs:964:9 [INFO] [stderr] | [INFO] [stderr] 964 | writeln!(term, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(term)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:138:20 [INFO] [stderr] | [INFO] [stderr] 138 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 139 | | if mowl::init_with_level_and_without_colors(LevelFilter::Info).is_err() { [INFO] [stderr] 140 | | warn!("Logger already set."); [INFO] [stderr] 141 | | }; [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 138 | } else if mowl::init_with_level_and_without_colors(LevelFilter::Info).is_err() { [INFO] [stderr] 139 | warn!("Logger already set."); [INFO] [stderr] 140 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:138:20 [INFO] [stderr] | [INFO] [stderr] 138 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 139 | | if mowl::init_with_level_and_without_colors(LevelFilter::Info).is_err() { [INFO] [stderr] 140 | | warn!("Logger already set."); [INFO] [stderr] 141 | | }; [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 138 | } else if mowl::init_with_level_and_without_colors(LevelFilter::Info).is_err() { [INFO] [stderr] 139 | warn!("Logger already set."); [INFO] [stderr] 140 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/parser.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | mut t: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/parser.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | mut t: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/parser.rs:90:19 [INFO] [stderr] | [INFO] [stderr] 90 | mut term: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/parser.rs:156:41 [INFO] [stderr] | [INFO] [stderr] 156 | fn print_default_term(&self, mut t: &mut Box, config: &Config) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/parser.rs:178:19 [INFO] [stderr] | [INFO] [stderr] 178 | mut term: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parser.rs:180:18 [INFO] [stderr] | [INFO] [stderr] 180 | compact: &bool, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/parser.rs:256:19 [INFO] [stderr] | [INFO] [stderr] 256 | mut term: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parser.rs:261:18 [INFO] [stderr] | [INFO] [stderr] 261 | compact: &bool, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/parser.rs:343:15 [INFO] [stderr] | [INFO] [stderr] 343 | term: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parser.rs:948:34 [INFO] [stderr] | [INFO] [stderr] 948 | pub fn print(&self, compact: &bool, template: Option<&str>) -> Result, Error> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:413:25 [INFO] [stderr] | [INFO] [stderr] 413 | max_tags_count: &u32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:414:14 [INFO] [stderr] | [INFO] [stderr] 414 | all: &bool, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:415:26 [INFO] [stderr] | [INFO] [stderr] 415 | skip_unreleased: &bool, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/parser.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | mut t: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/parser.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | mut t: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/parser.rs:90:19 [INFO] [stderr] | [INFO] [stderr] 90 | mut term: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/parser.rs:156:41 [INFO] [stderr] | [INFO] [stderr] 156 | fn print_default_term(&self, mut t: &mut Box, config: &Config) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/parser.rs:178:19 [INFO] [stderr] | [INFO] [stderr] 178 | mut term: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parser.rs:180:18 [INFO] [stderr] | [INFO] [stderr] 180 | compact: &bool, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/parser.rs:256:19 [INFO] [stderr] | [INFO] [stderr] 256 | mut term: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parser.rs:261:18 [INFO] [stderr] | [INFO] [stderr] 261 | compact: &bool, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/parser.rs:343:15 [INFO] [stderr] | [INFO] [stderr] 343 | term: &mut Box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parser.rs:948:34 [INFO] [stderr] | [INFO] [stderr] 948 | pub fn print(&self, compact: &bool, template: Option<&str>) -> Result, Error> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:413:25 [INFO] [stderr] | [INFO] [stderr] 413 | max_tags_count: &u32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:414:14 [INFO] [stderr] | [INFO] [stderr] 414 | all: &bool, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:415:26 [INFO] [stderr] | [INFO] [stderr] 415 | skip_unreleased: &bool, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `git-journal`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:99:98 [INFO] [stderr] | [INFO] [stderr] 99 | let ignore_tags: Option> = matches.value_of("ignore_tags").map(|s| s.split(",").collect()); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:99:98 [INFO] [stderr] | [INFO] [stderr] 99 | let ignore_tags: Option> = matches.value_of("ignore_tags").map(|s| s.split(",").collect()); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "1ebcf2d5088348febd5e3a31a92d830ebbcab31d915f7c314aa2e622eadbbc7e"` [INFO] running `"docker" "rm" "-f" "1ebcf2d5088348febd5e3a31a92d830ebbcab31d915f7c314aa2e622eadbbc7e"` [INFO] [stdout] 1ebcf2d5088348febd5e3a31a92d830ebbcab31d915f7c314aa2e622eadbbc7e